Uh oh!
There was an error while loading. Please reload this page.
fix(spec): correct stale tags note in doc.json liveness ledger - #9317
Merged
Conversation
doc.json's `_note` claimed DocSchema declares no `tags` key, so the
book-side `include: { tag }` rule could never match. That was true
when written, but doc.zod.ts:126 has declared `tags` since 17.0.0
(#4509, ADR-0049) — the enforce half of enforce-or-remove for this
key. Correct the note to a current-state statement instead of
deleting it: it still carries load-bearing cross-references (the
book-side rule, the REST corpus offset) that are worth keeping, now
pointed at the props.tags entry for the fix's full history.
No behaviour change; no verdict changes.
Fixes#9310Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 1 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 113 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
os-steve
marked this pull request as ready for review
August 17, 2026 13:29
Uh oh!
There was an error while loading. Please reload this page.
os-steve pushed a commit
that referenced
this pull request
Aug 17, 2026
… book.json and liveness README Same class as #9310/#9317: DocSchema declared `tags` in 17.0.0 (#4509, ADR-0049), making the book `include: { tag }` include variant live, but two more places in the liveness tree still restated the pre-fix claim that the tag rule can never match: - packages/spec/liveness/book.json — the `groups.include` prop's note - packages/spec/liveness/README.md — the `book` row Both corrected to current-state truth, matching the #9317 wording posture and preserving load-bearing cross-references (the #4667 tombstone paragraph on the README row). No verdict change, no behaviour change — ledger prose only. Fixes#9316 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fs18A2DdXLVN2h8PaaFBcP
This was referenced Aug 17, 2026
akarma-synetal pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Aug 23, 2026
… book.json and liveness README (objectstack-ai#9357) Same class as objectstack-ai#9310/objectstack-ai#9317: DocSchema declared `tags` in 17.0.0 (objectstack-ai#4509, ADR-0049), making the book `include: { tag }` include variant live, but two more places in the liveness tree still restated the pre-fix claim that the tag rule can never match: - packages/spec/liveness/book.json — the `groups.include` prop's note - packages/spec/liveness/README.md — the `book` row Both corrected to current-state truth, matching the objectstack-ai#9317 wording posture and preserving load-bearing cross-references (the objectstack-ai#4667 tombstone paragraph on the README row). No verdict change, no behaviour change — ledger prose only. Fixesobjectstack-ai#9316 Claude-Session: https://claude.ai/code/session_01Fs18A2DdXLVN2h8PaaFBcP Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9310
What was stale
packages/spec/liveness/doc.json's_noteclaimedDocSchemadeclares notagskey, so authoringtags:on a doc was a parse error, every docreached the resolver with
tags === undefined, and a book group'sinclude: { tag: '<t>' }rule could therefore never match.That was true when the note was written, but
doc.zod.ts:126has declaredtags: z.array(z.string()).optional()since 17.0.0 (#4509, ADR-0049) — theenforce half of enforce-or-remove for this key, with the fix's own history
in the comment block immediately above the declaration (L111–L122). The
ledger's own
props.tagsentry already reflectsstatus: "live"with thatfull history; only the top-level
_noteparagraph had gone stale.What changed
Corrected the note's last sentence to a current-state statement rather than
deleting it outright: it still carries load-bearing cross-references (the
book-side
include: { tag }rule, the REST corpus offset atrest-server.ts:2965) that are useful context for a reader of the ledger,so it now says
tagswas declared and the{ tag }variant went live, andpoints at the
props.tagsentry below for the full history instead ofrepeating it. No behaviour change, no verdict changes, no other rows
touched.
Local gates (HEAD
1543ad904)Derived via
node scripts/pm/dispatch-gates.mjs packages/spec/liveness/doc.json:pnpm --filter @objectstack/spec run check:empty-state— passpnpm --filter @objectstack/spec run check:liveness— passpnpm --filter @objectstack/spec run check:strictness-ledger— passpnpm --filter @objectstack/spec run check:variant-docs— passnode scripts/check-nul-bytes.mjs packages/spec/liveness/doc.json— passNot run:
pnpm --filter @objectstack/spec test— no test suite readsliveness/doc.json's_note(checked via grep acrosspackages/spec/**/*.test.*).Out-of-scope findings (same stale claim restated elsewhere)
The file surface for this card is
packages/spec/liveness/doc.jsononly.Grepping sibling liveness files for the same assertion found it restated in
two more places, both outside this diff — filed as #9316:
packages/spec/liveness/book.json:77(props.include.note)packages/spec/liveness/README.md:808(thebookrow)Generated by Claude Code
Generated by Claude Code