Skip to content

docs(spec): STORED_TYPE_NOT_CANONICAL ledger comment names both producers and their atomicity#9411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-steve merged 1 commit into from
Aug 18, 2026
+18 −1
Merged

docs(spec): STORED_TYPE_NOT_CANONICAL ledger comment names both producers and their atomicity #9411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .changeset/error-code-ledger-stored-type-not-canonical-two-producers.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
---
"@objectstack/spec": patch
---

docs(spec): `STORED_TYPE_NOT_CANONICAL` ledger comment names both producers and their atomicity (#9361)

The ledger entry at `error-code-ledger.zod.ts:381` described `STORED_TYPE_NOT_CANONICAL`'s
only producer as the publish pre-flight ("refused at the publish pre-flight, batch-atomic").
PR #9360 (#9174) added a second producer — `revertCommit`'s restore limb, which refuses
per-item on its existing `failed[]` channel and is explicitly NOT batch-atomic — leaving the
comment naming one of two producers, with the wrong atomicity for the one it omitted.

The comment now names both: the publish pre-flight (batch-atomic, `#8908`) and
`revertCommit`'s restore limb (per-item on `failed[]`, NOT batch-atomic, `#9174`).

Text-only change — accept/reject behavior, the error code, and its envelope are all
unchanged.
2 changes: 1 addition & 1 deletion packages/spec/src/api/error-code-ledger.zod.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -378,7 +378,7 @@ export const ERROR_CODE_LEDGER = {
'QUERY_OBJECT_MISMATCH',
'REGISTRY_TYPE_NOT_CANONICAL', // [#9111] a SchemaRegistry overlay entry was offered a non-canonical metadata `type` — the mint door asserts, the caller folds
'ROLLED_BACK', // atomic data-batch row was written, then undone by the batch rollback (#4793)
'STORED_TYPE_NOT_CANONICAL', // [#8908] a package draft is stored under a non-canonical metadata type (pre-#7894 second-namespace residue) — refused at the publish pre-flight, batch-atomic
'STORED_TYPE_NOT_CANONICAL', // [#8908] a package draft is stored under a non-canonical metadata type (pre-#7894 second-namespace residue) — refused at the publish pre-flight, batch-atomic; [#9174] also refused on `revertCommit`'s restore limb, per-item on `failed[]`, NOT batch-atomic
'TENANT_SCOPE_REQUIRED', // [#7780] destructive call named neither an organization nor an explicit cross-tenant intent; needs an explicit opt-in
'UNSUPPORTED_QUERY_PARAM',
'VALIDATION_FAILED',
Expand Down
Loading