Skip to content

fix(pm): close the block comment that swallowed dispatch-gates' maskComments re-export#9760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-steve merged 1 commit into from
Aug 19, 2026
Merged

fix(pm): close the block comment that swallowed dispatch-gates' maskComments re-export #9760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions scripts/pm/dispatch-gates.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -500,6 +500,7 @@ export function resolveCheckToFiles(checkName, scriptsMap) {
*
* Re-exported because this tool's self-test drives the SAME masker the gates
* run, not a copy of it.
*/
export { maskComments };

/**
Expand DownExpand Up@@ -2182,6 +2183,24 @@ function selfTest() {
t('a quote inside a regex literal does not open a string', commentHints.includes('packages/client/src'));
t('masking preserves every offset', maskComments(commented).length === commented.length);

// ...and the re-export of that masker is CODE, not comment text (#9640). The
// statement sits at the end of the longest docblock in this file, and a
// missing `*/` swallows it into prose that still parses: the module then has
// no `maskComments` export while its header says it has one, and nothing goes
// red — every gate stayed green over it until someone parsed for it. Asked of
// this file's own source with this file's own masker, which is what the
// docblock claims. Column 0 only, and a match the scan flags as literal is
// rejected, so no fixture spelling in this self-test can stand in for the
// statement.
const ownSource = readFileSync(new URL(import.meta.url), 'utf8');
const ownScan = scanSource(ownSource);
t(
'the maskComments re-export is code, not comment text',
[...ownSource.matchAll(/^export \{ maskComments \};$/gm)].some(
(m) => !ownScan.comment[m.index] && !ownScan.literal[m.index],
),
);

// The self-test boundary. The fixture puts a column-0 `}` inside a template
// literal on purpose: that is the shape this tree really has (a check script
// whose self-test embeds TS sources as fixtures), and a boundary that stopped
Expand Down
Loading