Grid toolbar inline-edit toggle is not gated on `can(object, 'update')`; `userActions.editInline` is declared in spec but has no consumer

[baozhoutao]

Summary

Two related gaps around list-view inline editing, observed on @objectstack/console@17.0.0 (stable):

1. The list toolbar's inline-edit toggle (toolbar-inline-edit-toggle) renders for every user, with no object update permission gate.
2. ListViewSchema.userActions.editInline (spec ui/view.zod.ts, boolean) is declared but consumed nowhere in console — so authors cannot even switch inline editing off wholesale.

Gap 1: no permission gate on the toggle

Render condition, verified in the console dist (plugins-views chunk):

viewType === 'grid' && onInlineEditChange callback present && !compactToolbar

…and the host passes onInlineEditChange unconditionally. There is no can(object, 'update') anywhere in this path. In the same component, the bulk-delete entry is gated with can(obj, 'delete') — inline edit is the one affordance on the toolbar without a permission check.

Consequence (tested with a read-only role)

An account without update permission on the object can:

1. flip the toggle and enter inline-edit mode,
2. modify cells,
3. click Save all,

…and is only stopped by the server-side 403. No data lands (the server gate is solid — this is not a security issue), but the UI walks the user through a full editing round-trip that is guaranteed to fail. It is also inconsistent: on the very same toolbar, New and Import are correctly hidden for this account by permission — inline edit alone remains available.

Gap 2: userActions.editInline has zero consumers

Across the entire console dist, editInline appears only as an i18n label key. The spec-declared ListViewSchema.userActions.editInline boolean is never read — declared-but-inert metadata: a view author cannot disable inline editing even unconditionally.

Expected

1. Gate the inline-edit toggle on can(object, 'update'), aligned with the existing practice in the same bundle (record-detail showEdit, related-list edit affordances).
2. Consume userActions.editInline so the declared switch actually controls whether the toggle is offered.

Related (same family, different surfaces — all fixed)

• 列表行内建【编辑】【删除】没接权限门:只与 apiOperations 求交,而它与用户无关 ⇒ 无写权账号恒可见 #4096 — row kebab built-in Edit/Delete gated on apiOperations instead of the caller's permission (fixed in PR fix(grid,list,app-shell): gate row Edit/Delete on the caller's permission, not just apiOperations #4108). Same "missing permission gate on one affordance while siblings have it" shape; this issue is the toolbar-inline-edit member.
• fix(plugin-grid): 批量操作按钮忽略 requiredPermissions，且布尔 visible 被判为故障导致按钮全员隐藏 #3492 — bulk action buttons ignored requiredPermissions.

Downstream tracking: steedos-labs/os-project-titanwind-ehr#1071 (private repo; covers gap 1).

[os-zhuang]

Triage: pm:queue, type Bug. Gap 1: the inline-edit toggle is the one ungated affordance on its own toolbar — family precedent #4096 / #3492 (both fixed) makes this pattern-inherited, no new decision needed; gate on can(object, 'update') aligned with the same bundle's practice. Gap 2: consume the declared userActions.editInline (declared-but-inert boolean). Serial note: shares the list-toolbar surface with #4646 — dispatch serially or to one dev.

---

Generated by Claude Code

[yinlianghui]

认领(与 #4646 合单)(PM 派发,objectui 分片,批次 23):session_01GTRjn8xBqp75dk7kFupVRt,分支 claude/issue-4646-toolbar-action-gates,os-dev 席即将开工。

按分诊席 serial note 合单(共享 list-toolbar 面),PR 用 Fixes #4646 + Fixes #4647。本卡半:gap 1 = inline-edit toggle 加 can(object, 'update') 门(同 toolbar bulk-delete 的 can(obj,'delete') 形,家族先例 #4096/#3492 均已修);gap 2 = 消费 declared-but-inert 的 userActions.editInline。

---

Generated by Claude Code