Measured while implementing #4508 (bucket identity), and deliberately not widened into that card: different defect class, different verification surface.
What is wrong
AdvancedChartImpl.handleCartesianClick builds the drill event from payload.activePayload:
constap=Array.isArray(payload.activePayload) ? payload.activePayload[0] : undefined;onChartClick({category: payload.activeLabel!=null ? String(payload.activeLabel) : undefined,series: ap?.dataKey ? String(ap.dataKey) : undefined,value: typeofap?.value==='number' ? ap.value : undefined,});activePayload is a recharts 2 field. In recharts 3 (this repo is on ^3.10.1) the chart-level onClick receives a MouseHandlerDataParam, whose published type is exactly:
activeCoordinate, activeDataKey, activeIndex, activeLabel, activeTooltipIndex, isTooltipActive
(node_modules/recharts/types/synchronisation/types.d.ts, and the object is assembled verbatim in lib/state/externalEventsMiddleware.js. activePayload appears nowhere in the shipped lib/ or types/ except an unrelated local in component/Cursor.js.)
So ap is alwaysundefined, and every cartesian drill event is { category, series: undefined, value: undefined }. This is a v2 to v3 migration leftover: no type error, because the payload is typed any at the call site.
Why it matters
series is not cosmetic on the dataset path. DatasetWidget.handleChartDrill feeds it to findChartSeriesRow, whose pivot arm requires it:
returnsafeRows.findIndex((r)=>matchesX(r)&&String(r[gDim]??'')===s);
With seriesKey undefined, s is '', which matches only rows whose second dimension is null or empty. For an ordinary pivoted dataset chart (2 dimensions, 1 measure — grouped bars, the shape ADR-0021 / #1759 introduced) no row matches, the lookup returns -1, and handleChartDrill returns without opening the drawer. Every segment of every pivoted bar/line/area dashboard chart is a dead click.
Single-dimension charts are unaffected for series (the lookup does not read it there), but they still lose value, and the drawer title loses its series half (handleChartDrill composes the title from ev.category and ev.series).
Pie/donut and funnel are unaffected — they build their events from the sector/segment entry, not from this payload.
Repro sketch
A dataset widget with dimensions: ['status', 'priority'], values: ['est_hours'], drill enabled. Click any bar segment: nothing opens. The same click composed by hand with the series name resolves fine, which is what AdvancedChartImpl.pivotNullBucket.test.tsx and #4508's new tests do — they call findChartSeriesRow directly, so none of them can see this.
Likely shape of the fix (not measured, deliberately)
The payload does carry what is needed, under different names: activeDataKey for the series, and activeTooltipIndex (an index into the chart's own data) for the row, from which the measure can be read. #4508 already added the index read on this path for the bucket identity, so the row is in hand at the point the event is built. What needs measuring first is activeDataKey's value under a SHARED cartesian tooltip (several series under one cursor), where "the clicked series" may genuinely not be a single answer — that judgement is why this is filed rather than patched inside #4508.
Test gap this leaves
No test asserts the payload shape this handler is fed. The existing chart drill tests either call the pure lookup directly or stub the chart component, so the one seam that broke is the one nothing covers. Whatever the fix, it wants a case pinned against the recharts payload as recharts 3 actually sends it.
Related: #4508 (bucket identity, in flight — touches the same handler but not this field), #4497, #4466.
Measured while implementing #4508 (bucket identity), and deliberately not widened into that card: different defect class, different verification surface.
What is wrong
AdvancedChartImpl.handleCartesianClickbuilds the drill event frompayload.activePayload:activePayloadis a recharts 2 field. In recharts 3 (this repo is on^3.10.1) the chart-levelonClickreceives aMouseHandlerDataParam, whose published type is exactly:(
node_modules/recharts/types/synchronisation/types.d.ts, and the object is assembled verbatim inlib/state/externalEventsMiddleware.js.activePayloadappears nowhere in the shippedlib/ortypes/except an unrelated local incomponent/Cursor.js.)So
apis alwaysundefined, and every cartesian drill event is{ category, series: undefined, value: undefined }. This is a v2 to v3 migration leftover: no type error, because the payload is typedanyat the call site.Why it matters
seriesis not cosmetic on the dataset path.DatasetWidget.handleChartDrillfeeds it tofindChartSeriesRow, whose pivot arm requires it:With
seriesKeyundefined,sis'', which matches only rows whose second dimension is null or empty. For an ordinary pivoted dataset chart (2 dimensions, 1 measure — grouped bars, the shape ADR-0021 / #1759 introduced) no row matches, the lookup returns -1, andhandleChartDrillreturns without opening the drawer. Every segment of every pivoted bar/line/area dashboard chart is a dead click.Single-dimension charts are unaffected for
series(the lookup does not read it there), but they still losevalue, and the drawer title loses its series half (handleChartDrillcomposes the title fromev.categoryandev.series).Pie/donut and funnel are unaffected — they build their events from the sector/segment entry, not from this payload.
Repro sketch
A dataset widget with
dimensions: ['status', 'priority'], values: ['est_hours'], drill enabled. Click any bar segment: nothing opens. The same click composed by hand with the series name resolves fine, which is whatAdvancedChartImpl.pivotNullBucket.test.tsxand #4508's new tests do — they callfindChartSeriesRowdirectly, so none of them can see this.Likely shape of the fix (not measured, deliberately)
The payload does carry what is needed, under different names:
activeDataKeyfor the series, andactiveTooltipIndex(an index into the chart's owndata) for the row, from which the measure can be read. #4508 already added the index read on this path for the bucket identity, so the row is in hand at the point the event is built. What needs measuring first isactiveDataKey's value under a SHARED cartesian tooltip (several series under one cursor), where "the clicked series" may genuinely not be a single answer — that judgement is why this is filed rather than patched inside #4508.Test gap this leaves
No test asserts the payload shape this handler is fed. The existing chart drill tests either call the pure lookup directly or stub the chart component, so the one seam that broke is the one nothing covers. Whatever the fix, it wants a case pinned against the recharts payload as recharts 3 actually sends it.
Related: #4508 (bucket identity, in flight — touches the same handler but not this field), #4497, #4466.