Observation recorded while fixing #5237 (PR #5245). Filed unassigned, not claiming; no fix proposed here.
What was observed
The root package.json declares:
"check": "node packages/cli/dist/cli.js check"
Grepping .github/workflows/** for that script finds no caller. ci.yml and lint.yml run the check:* family (check:phantom-deps, check:control-bytes, check:node-esm-load, and the rest), but the bare check script — the product's own objectui check command, pointed at this repository — is run by nothing.
Why it is worth recording
This is the reason #5237 was able to happen. objectui check exited 1 with 64 errors at this repo's root, on main, and had presumably done so since the first tsconfig.json grew a comment. No gate observed it, so nobody found out until someone ran the command by hand while measuring something else.
The same is true going forward: after #5245 the command reports 0 errors and exit 0, and nothing in CI will notice if that stops being true. Whatever the next regression in this command is, it will be found the same way this one was — by accident.
Worth noting alongside it: the command currently prints 47 warnings at this repo's root (the subject of #5127, still open). So "wire it into CI" is not a free action — it needs a decision about whether the warning arm is acceptable noise in a required job, which is why this is filed as an observation for triage rather than as a fix.
Not prejudged
Options range from adding the script to an existing lint job, to running it only on a schedule, to concluding that a self-check against the repo's own tree is not a meaningful gate and the script should be dropped instead. That call, and its interaction with #5127's warning arm, belongs to triage.
Observation recorded while fixing #5237 (PR #5245). Filed unassigned, not claiming; no fix proposed here.
What was observed
The root
package.jsondeclares:Grepping
.github/workflows/**for that script finds no caller.ci.ymlandlint.ymlrun thecheck:*family (check:phantom-deps,check:control-bytes,check:node-esm-load, and the rest), but the barecheckscript — the product's ownobjectui checkcommand, pointed at this repository — is run by nothing.Why it is worth recording
This is the reason #5237 was able to happen.
objectui checkexited 1 with 64 errors at this repo's root, onmain, and had presumably done so since the firsttsconfig.jsongrew a comment. No gate observed it, so nobody found out until someone ran the command by hand while measuring something else.The same is true going forward: after #5245 the command reports 0 errors and exit 0, and nothing in CI will notice if that stops being true. Whatever the next regression in this command is, it will be found the same way this one was — by accident.
Worth noting alongside it: the command currently prints 47 warnings at this repo's root (the subject of #5127, still open). So "wire it into CI" is not a free action — it needs a decision about whether the warning arm is acceptable noise in a required job, which is why this is filed as an observation for triage rather than as a fix.
Not prejudged
Options range from adding the script to an existing lint job, to running it only on a schedule, to concluding that a self-check against the repo's own tree is not a meaningful gate and the script should be dropped instead. That call, and its interaction with #5127's warning arm, belongs to triage.