[finding] ObjectSettingsPanel re-declares OWD_WIDTH inline instead of calling `owd-sharing.ts`'s `isExternalWider` — the module that exists to be the single home for exactly that comparison

[os-support-ai]

Observed while working #5418. Not fixed there — untouched by that card's change, and folding it in would have widened a security-surface diff for a cleanup.

packages/app-shell/src/views/studio-design/owd-sharing.ts states its own purpose:

> The per-object Settings tab (ObjectSettingsPanel) and the package-level OWD overview (PackageOwdOverviewPanel) both edit the SAME record-sharing baseline (…). This module is the single home for the pieces they must agree on: the canonical value set, the D11 "external ≤ internal" width comparison, and the master-object derivation (…)

ObjectSettingsPanel.tsx then computes that comparison inline instead of importing it:

const OWD_WIDTH: Record<string, number> = { private: 0, public_read: 1, public_read_write: 2 };
const externalWider =
 externalSharingModel in OWD_WIDTH &&
 sharingModel in OWD_WIDTH &&
 OWD_WIDTH[externalSharingModel] > OWD_WIDTH[sharingModel];

owd-sharing.ts exports isExternalWider(internal, external) doing the same thing, and its docstring acknowledges the split — "mirrors the comparison ObjectSettingsPanel implemented inline" — so this is a known state rather than an accidental one.

Why it is still worth closing. The two are equivalent today, and the inline copy's guards happen to line up with the exported one's. They are not pinned to each other by anything: no test compares them, and the shared module is where the ADR-0090 D11 semantics are documented. A future D11 refinement lands in owd-sharing.ts and the Settings tab — the surface an author actually uses to set the dial — keeps the old rule, silently.

Scope. Replace the inline block with the import, and consider whether PackageOwdOverviewPanel (which does use the shared module) grows a test that both surfaces agree.

[os-zhuang]

Triage (first-touch grading): promoted to pm:queue, domain:ui, type Task. Behavior-preserving cleanup restoring the module's own declared invariant (owd-sharing.ts exists to be the single home for the D11 comparison) — no decision needed. Dispatch notes: replace the inline OWD_WIDTH block with the isExternalWider import, and add the agreement pin the card suggests so the two surfaces cannot drift silently again — that pin is the substantive half; the import swap alone re-arms nothing but also proves nothing. Security-adjacent file, so keep the diff to exactly this convergence. Size/model suggestion: S, sonnet-opus.

---

Generated by Claude Code

[os-sales]

Claim: PM loop round 3
Session: session_012u2pRjcqAYtoEjgr3wwhnK
Branch: claude/issue-5477-owd-width-single-home
Worktree: objectui-issue-5477
Domain: domain:ui
File surface: packages/app-shell/src/views/studio-design/ObjectSettingsPanel.tsx + its tests + a changeset. owd-sharing.ts is the reuse target and is read-only unless you report why it must change (stop on breach; explain in the report)
Container & model: S-M, mode:subagent, model: opus — no path-derived mandate. Collapsing a duplicated comparison onto its canonical home is mechanical only once you have proved the two are actually the same comparison; that proof is the judgment, and an inline copy that has silently drifted is the interesting outcome.
Clause-②: no — calling an existing module instead of re-declaring its constant changes no accept/reject behaviour and widens no public surface.
Serial constraints cleared: packages/app-shell/** — released 13:49:41Z when PR #5570 merged (#5554, which touched views/RecordApprovalsPanel.tsx). Different directory from this card's views/studio-design/**, and nothing else in this lane is in flight on the package. Re-verify against current origin/main regardless.

Located on origin/main this round: OWD_WIDTH / isExternalWider live in packages/app-shell/src/views/studio-design/owd-sharing.ts (with owd-sharing.test.ts beside it), and the inline re-declaration is in ObjectSettingsPanel.tsx. A third consumer, PackageOwdOverviewPanel.tsx, also references that vocabulary — read it before deciding the shape, and report whether it is already calling the shared module or is a second inline copy. If it is a second copy, say so rather than silently widening this card to cover it.

⚠️ Do not assume the inline copy and the module agree. If they have drifted, the drift is the finding and the behaviour change needs calling out explicitly — a "pure refactor" that quietly changes a comparison is the worst outcome available here.

Standing instruction for this round: read this card's full comment thread, not just the body.

---

Generated by Claude Code