[finding] `record:alert`'s CTA path shares the same unpinned resultDialog-through-shared-runner gap as record:quick_actions

[os-zhuang]

Follow-up from #5711 ("Worth checking in the same sweep whether record:alert's CTA path … shares the gap").

The observation

record-alert.tsx's own header comment claims its CTA runs through "the same pipeline that record:quick_actions uses" — and it does: it calls useActionEngine (packages/plugin-detail/src/renderers/record-alert.tsx), which reuses the surrounding <ActionProvider>'s shared ActionRunner when one is mounted and falls back to a local, unwired one otherwise (packages/react/src/hooks/useActionEngine.ts). resultDialog is honoured centrally in ActionRunner.handlePostExecution — same mechanism #5711 pins for record:quick_actions.

Checked (not recalled): grep -in "resultDialog\|ActionProvider" packages/plugin-detail/src/renderers/__tests__/record-alert*.test.tsx → only one hit, a comment in record-alert.test.tsx noting the renderer "require[s] a live provider tree (RecordContext, ActionProvider, …)" — no assertion anywhere in the four record-alert*.test.tsx files that a handler registered on an ambient <ActionProvider> is actually reachable from record:alert's CTA button, and no assertion of the negative (no-provider) leg either.

Why it matters

Identical failure shape to #5711: if a refactor ever caused record:alert's CTA to fall back to a local runner, an action declaring resultDialog would keep reporting success, the success toast would stay suppressed (suppression is unconditional on resultDialog being set, independent of whether a handler exists), and the user would see nothing. Only trace is a console.warn.

Suggested shape

Mirror #5711's PR (packages/plugin-detail/src/renderers/__tests__/record-quick-actions.resultDialog.test.tsx): mount record:alert under <ActionProvider onResultDialog onToast> with a CTA action declaring resultDialog, assert the dialog opens with the response value and the toast is suppressed; plus the negative leg with no provider.

observation-class, unassigned.

[claude]

Finding concentration round (triage seat, session session_01Kktexqp6uVuFMztvvTMf3V, 2026-08-24, maintainer-invoked): promoted → pm:queue (domain:ui), Task (test-only). Add the missing pin: record:alert's CTA honours resultDialog through the shared ActionRunner when an <ActionProvider> is mounted — mirror #5711's pin shape for record:quick_actions, including the fallback-runner (unwired) branch.

---

Generated by Claude Code

[yinlianghui]

Claim: PM loop round 38 (refill slot)
Session: session_01CSoz9uGhaaSgiq3hshtN7L
Branch: claude/issue-5808-record-alert-resultdialog-pin
Worktree: objectui-issue-5808
Domain: domain:ui
File surface: packages/plugin-detail/src/renderers/__tests__/ (a new pin file) + a changeset if the gates demand one. record-alert.tsx, useActionEngine.ts and ActionRunner are read-only — this is a test-only card.
Container & model: S, mode:subagent, model: opus
Clause-②: no — a missing pin is added. Nothing declared moves.
Serial constraints cleared: packages/plugin-detail/** — no in-flight claim (#5998 landed as PR #6015 earlier this round; rebase past it). Concurrent siblings: #5927 (packages/types/src/zod/**), #5565 (apps/console + a seam in packages/app-shell), #5835 (packages/app-shell/src/views/RecordDetailView.tsx), #6010 (packages/components/src/renderers/form/form.tsx). Disjoint by full path.

裁决 — triage's fence, carried verbatim

Triage seat, 2026-08-24 (finding concentration round, maintainer-invoked), promoted → pm:queue / Task, test-only. Verbatim:

Add the missing pin: record:alert's CTA honours resultDialog through the shared ActionRunner when an ActionProvider is mounted — mirror #5711's pin shape for record:quick_actions, including the fallback-runner (unwired) branch.

⚠️ Read #5711's PR first — it is the worked example, and the fence says mirror its shape, specifically packages/plugin-detail/src/renderers/__tests__/record-quick-actions.resultDialog.test.tsx. ⛔ Do not invent a different pin shape for the sibling surface; two pins for one mechanism that disagree in structure are worse than one.

⚠️ The card's own text is sanitizer-damaged — do not read the empty backticks as empty

This repo's issue sanitizer eats short angle-bracket fragments, including inside backticks. In the card body, "mount record:alert under "* and *"registered on an ambient" both had <ActionProvider> in them. Same for "reuses the surrounding ``'s shared ActionRunner". ⛔ Do not conclude a component name is missing or that the card is incomplete — reconstruct from context, and ⛔ avoid angle-bracket placeholders in your own report for the same reason.

The measured gap

record-alert.tsx calls useActionEngine (packages/react/src/hooks/useActionEngine.ts), which reuses the surrounding ActionProvider's shared ActionRunner when one is mounted and falls back to a local, unwired one otherwise. resultDialog is honoured centrally in ActionRunner.handlePostExecution — the same mechanism #5711 pins for record:quick_actions.

The card checked rather than recalled: across the four record-alert*.test.tsx files there is one hit for resultDialog|ActionProvider, and it is a comment noting the renderer "require[s] a live provider tree". No assertion that a handler registered on an ambient provider is reachable from record:alert's CTA, and no assertion of the negative (no-provider) leg.

Why it matters, and it is the reason this is worth a card rather than a shrug: if a refactor ever made the CTA fall back to the local runner, an action declaring resultDialog would keep reporting success, the success toast would stay suppressed — suppression is unconditional on resultDialog being set, independent of whether a handler exists — and the user would see nothing. The only trace is a console.warn. ⚠️ That is a silent-success failure, the hardest class to notice in production and the easiest to pin.

PM mechanism assumptions — measure, do not assume

1. The card is from 2026-08-23 and packages/plugin-detail moved twice since. This seat merged fix(plugin-detail,i18n): localize record:path's container labels and announce its goal terminus #6000 (record:path container labels + goal-terminus announcement) and PR fix(plugin-detail): give record:path one stage classification both rows read #6015 / record:path classifies a won stage differently on desktop and mobile, so one stage paints (and now announces) two ways by viewport #5998 (record:path one-classification) into this package today. ⛔ Re-derive the card's grep on your merge-base and report the delta — in particular, re-run resultDialog|ActionProvider across the record-alert* suites yourself and quote the current hit count. If a pin has appeared since, ⛔ stop and report; the card would then close as already-covered.
2. ⚠️ The suppression claim is the load-bearing one and it is a claim about running code. Verify in ActionRunner's own source that toast suppression keys on resultDialog being set rather than on a handler existing. If it actually keys on the handler, the silent-success framing collapses and the pin you write should be shaped to what is actually true — say so before writing it.
3. Both legs are required and they are not symmetric. The positive leg (provider mounted → dialog opens with the response value, toast suppressed) and the negative leg (no provider → the fallback runner path). ⛔ Shipping only the positive leg re-creates exactly the gap this card is about, one branch over.
4. useActionEngine is shared. If your reading shows other renderers take the same fallback with the same unpinned exposure, ⛔ do not widen this card to cover them — name them in the report and let triage grade a sweep.

Verification

A pin whose failure you have not seen is not a pin. For each leg, predict the direction before running, then make it fail on demand: force the CTA down the fallback path (or unmount the provider) and show the positive leg goes red; the negative leg must go red if the fallback branch is made to behave like the wired one.

⚠️ Counter-probe required, and it is the one that matters here: an action without resultDialog must still show its success toast, on both legs. Without it, "the toast is suppressed" is satisfiable by a harness in which no toast ever appears — and that is precisely the shape of false green this card exists to prevent. A console.warn assertion is not a substitute: warn-only is the very signal the card says is the sole trace today.

Prove every mutation on disk by grepping the injected text and separately the removed text. ⚠️ Print the landing site of each mutation rather than assuming it — a mis-anchored mutation that still moves the number is the worst species of false green, measured on #4730 in this same round. Restore under trap … EXIT INT TERM; confirm git diff HEAD --stat empty afterwards.

Gates by name with exit codes: pnpm --filter @object-ui/plugin-detail type-check (⚠️ hyphenated type-check; echo the script name so a zero-match silent pass cannot read as green — and a first RED reading Cannot find module @object-ui/... is the unbuilt-closure signature, not a real failure), root-form vitest over packages/plugin-detail/src (⚠️ this repo's vitest guard refuses the --filter forms — use pnpm exec vitest run <paths> from the repo root), and eslint on the changed file with the merge-base delta stated. ⚠️ This repo's eslint spelling is a plain eslint . per package — ⛔ do not add --no-inline-config; it disables legitimate inline disables and manufactures phantom errors (measured twice today, on #5605 and #4730).

Run node scripts/check-changeset-presence.mjs rather than guessing whether a changeset is owed; empty frontmatter is this repo's "releases nothing" declaration, and a test-only change is its typical case. Draft PR, Fixes #5808. ⛔ Do not mark it ready, ⛔ do not enqueue, ⛔ do not enable auto-merge — the PM lands it. Post the terminal report here (plain-text first-line marker os-dev-report; ⛔ avoid short angle-bracket placeholders in prose — this repo's sanitizer eats them) and return it.

---

Generated by Claude Code