finding: phase2-schemas.test.ts imports 9 schemas no test uses — unused-import warnings overstate the file's pin coverage

[claude]

Measured while executing #5647 (lint pass over the edited files). Filed unassigned, observational — pre-existing, warning-level, no gate is red.

Measurement

packages/types/src/__tests__/phase2-schemas.test.ts imports 10 schema names from ../zod/index.zod that no test in the file uses. On the pre-PR-#5823 baseline (ad404e057), package-level eslint reports 10 @typescript-eslint/no-unused-vars warnings on the import block:

• AppActionSchema, AppMenuItemSchema, ThemePreviewSchema, ReportViewerSchema, BlockEditorSchema, BlockInstanceSchema, ActionExecutionModeSchema, ActionCallbackSchema, ActionConditionSchema, CRUDSchema

PR #5823 removes ThemePreviewSchema (name retired), leaving 9. The rule is warning-level in this repo, so nothing is red — but each unused import mildly overstates what the file covers: a reader (or a coverage-by-import census) sees ReportViewerSchema imported by the acceptance suite and can conclude it is pinned, when nothing asserts against it.

Shape of the cleanup

Drop the unused names from the import block (one mechanical edit), or add the missing acceptance assertions if any of these schemas are meant to be pinned here — that choice is per-name and belongs to whoever takes the card. Note the same census method applies to the other big acceptance files in packages/types/src/__tests__/ and was not run there; this card measured only phase2-schemas.test.ts.

Positive control on the same pipeline: the baseline lint run also flags nothing else in this file, and the count moved 10 → 9 exactly when one name was retired — the warnings track real imports, not lint noise.

---

Generated by Claude Code

---

Generated by Claude Code

[claude]

Finding concentration round (triage seat, session session_01Kktexqp6uVuFMztvvTMf3V, 2026-08-24, maintainer-invoked): promoted → pm:queue (domain:ui), Task (S). Drop the 9 unused schema imports from phase2-schemas.test.ts (re-measure the list on current main first — #5823 already removed one) so import-based coverage reading stops overstating the file.

---

Generated by Claude Code

[yinlianghui]

Claim: PM loop round 38
Session: session_01CSoz9uGhaaSgiq3hshtN7L
Branch: claude/issue-5824-phase2-unused-schema-imports
Worktree: objectui-issue-5824
Domain: domain:ui
File surface: packages/types/src/__tests__/phase2-schemas.test.ts (the import block) + a changeset if the repo's changeset gates demand one for a test-only edit (they may not — measure, don't assume)
Container & model: S, mode:subagent, model: opus
Clause-②: no — a test file's unused import block. No contract accept/reject behaviour moves, no public surface widens.
Serial constraints cleared: packages/types/src/__tests__/phase2-schemas.test.ts — no in-flight claim. Concurrent siblings this round: #5927 (packages/types/src/zod/** + __tests__/zod-mirror-parity.test.ts), #5631 (packages/types/layout + renderers/basic), #4730 (packages/i18n/src/locales/**), #5293 rework (packages/plugin-view prose). Disjoint by full path — but #5927 and #5631 are in the same package, so ⛔ do not touch anything outside your one file.

裁决 — triage ruling, carry it

Triage seat, 2026-08-24 (session_01Kktexqp6uVuFMztvvTMf3V), promoted to pm:queue / Task (S), verbatim: "Drop the 9 unused schema imports from phase2-schemas.test.ts (re-measure the list on current main first — #5823 already removed one) so import-based coverage reading stops overstating the file."

The card offers a per-name fork — drop the import, or add the missing acceptance assertions if a schema was meant to be pinned here. Default to dropping. Adding assertions is authoring new coverage for schemas nobody asked this file to cover, and it silently widens an S card into an unbounded one. If you find a name where the file's own surrounding structure makes the omission look like a bug rather than leftovers (an adjacent describe block that pins every sibling schema and skips exactly this one), ⛔ do not write the assertion — name it in the report and leave the import dropped.

PM mechanism assumptions — measure, do not assume

1. ⚠️ The card's list of 10 names is stale in at least two ways, and this is the main trap. It was measured at ad404e057. feat(types)!: retire ThemeSwitcherSchema / ThemePreviewSchema and ThemeUnionSchema #5823 retired ThemePreviewSchema (10 → 9, per the card itself). Since then feat(types)!: retire the ActionCondition branch shape from ActionSchema.condition #5981 landed on main — feat(types)!: retire the ActionCondition branch shape from ActionSchema.condition — which removed the ActionCondition interface and replaced ActionConditionSchema with a module-local predicate schema. So ActionConditionSchema may no longer be importable at all, and the count may already be 8. ⛔ Do not copy the card's list. Re-derive it from the tree with the tool, and report the delta against the card's 10 explicitly, name by name.
2. The measurement instrument is eslint's @typescript-eslint/no-unused-vars at warning level. Re-run it on the file at your merge-base and read the count from --format json, not by eye. A name can be unused-as-a-value but still load-bearing as a type-only import in this file — check each before dropping.
3. Counter-probe required, both directions. A zero-hit grep proves nothing without a known-present control: for each name you drop, show it has no other occurrence in the file (and that a name you keep does). After the edit, re-run eslint on the file and show the warning count fell by exactly the number of names you dropped — no more, no less. A larger drop means you removed something that was in use elsewhere in the block.

Verification

Reverse-verify the way this seat requires: predict the direction before running. Re-add one dropped import and show the warning count goes back up by exactly one; prove the mutation landed on disk by grepping for the injected text and separately for the removed text (an editor's exit code proves nothing on a zero-hit anchor); restore under trap … EXIT INT TERM and confirm the tree is byte-identical to HEAD afterwards.

Gates by name with exit codes: pnpm --filter @object-ui/types type-check, the root-form vitest over packages/types/src/__tests__, and eslint on the changed file. A test-only import change that moves a test verdict is a red flag — report it, do not absorb it.

Draft PR, Fixes #5824. Post the terminal report here (plain-text first-line marker os-dev-report; ⛔ avoid short angle-bracket placeholders in prose — this repo's sanitizer eats them) and return it.

---

Generated by Claude Code