Found while implementing #5692. Out of that card's fence (the two plugin-dashboard files + their tests + core's expand-fields.ts docblock), so it is filed rather than fixed in passing.
What is there
#5692 established that #5312's "LAST private copy" claim was false — plugin-dashboard held two more copies of the reference-bearing rule that predate that sweep. #5692's PR corrects the record in the family's canonical home, packages/core/src/utils/expand-fields.ts.
The claim itself is written in two app-shell files, and both still stand:
packages/app-shell/src/utils/paramToField.ts — "This face held the fourth and last private copy of it"packages/app-shell/src/utils/paramToField.test.ts — "This module held the FOURTH and last hand-maintained answer to one question"
Both were true-as-far-as-measured when written and are now known false: there were at least six, and #5874 records four more beyond #5692's two.
Why it matters rather than being a typo
It is the exact failure mode #5692 exists to record. The next consolidation reads the nearest authoritative-sounding sentence, and that sentence says the sweep is finished. #5312 itself started from the same kind of claim in the comment it replaced ("moves in lockstep with plugin-grid's bulkParamToField twin"), which its own measurement then falsified in both senses.
Fix
Prose only, no behaviour: replace "fourth and last" with what is now measured — this face was the fourth converted, not the last copy — and point at expand-fields.ts's falsification note rather than restating the count locally. Hand-kept counts of this table are what keeps going stale; the mechanical fact is the identity pins.
Related: #5312, #5692, #5874, #4770, #4790, #4815.
Generated by Claude Code
Found while implementing #5692. Out of that card's fence (the two
plugin-dashboardfiles + their tests + core'sexpand-fields.tsdocblock), so it is filed rather than fixed in passing.What is there
#5692 established that #5312's "LAST private copy" claim was false —
plugin-dashboardheld two more copies of the reference-bearing rule that predate that sweep. #5692's PR corrects the record in the family's canonical home,packages/core/src/utils/expand-fields.ts.The claim itself is written in two
app-shellfiles, and both still stand:packages/app-shell/src/utils/paramToField.ts— "This face held the fourth and last private copy of it"packages/app-shell/src/utils/paramToField.test.ts— "This module held the FOURTH and last hand-maintained answer to one question"Both were true-as-far-as-measured when written and are now known false: there were at least six, and #5874 records four more beyond #5692's two.
Why it matters rather than being a typo
It is the exact failure mode #5692 exists to record. The next consolidation reads the nearest authoritative-sounding sentence, and that sentence says the sweep is finished. #5312 itself started from the same kind of claim in the comment it replaced ("moves in lockstep with plugin-grid's
bulkParamToFieldtwin"), which its own measurement then falsified in both senses.Fix
Prose only, no behaviour: replace "fourth and last" with what is now measured — this face was the fourth converted, not the last copy — and point at
expand-fields.ts's falsification note rather than restating the count locally. Hand-kept counts of this table are what keeps going stale; the mechanical fact is the identity pins.Related: #5312, #5692, #5874, #4770, #4790, #4815.
Generated by Claude Code