You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Measured while implementing #5953 (PR #5975). Comment-only; filing rather than riding it in, because that PR's whole claim about this file is that it leaves it untouched.
// The title is a real read, not a forwarded prop: `getMapConfig` resolves
// `titleField`, the marker transform reads `record[titleField]`, and the
// popup renders it. Before the forward landed this read `'Marker'` — the
// literal `getMapConfig` falls back to — which is the `undefined`/placeholder
// marker-title symptom the card was filed for.
'Marker' was never a literal getMapConfig fell back to, even before that change — it is the else-arm of the read site's ternary (mapConfig.titleField ? record[mapConfig.titleField] : 'Marker'). What getMapConfig fell back to was 'name', which is a different placeholder reached on a different branch. The two produce visibly different symptoms — a declared map block omitting titleField yielded the uniform 'Marker'; the flat and default branches yielded undefined — and the comment merges them.
"the marker transform reads record[titleField]" is also now a stale description of the mechanism (it resolves through getRecordDisplayName), though the sentence's actual claim — that the title is a real read rather than a forwarded prop — is still true and is still what the arm pins.
Scope note
No assertion is involved and no coverage is affected. Every arm in the file asserts a positive title from a declared titleField, and all six stayed green through #5953 unchanged; this is purely the historical narration above one of them.
Measured while implementing #5953 (PR #5975). Comment-only; filing rather than riding it in, because that PR's whole claim about this file is that it leaves it untouched.
What was measured
packages/plugin-map/src/ObjectMap.listViewMapConfigReach.test.tsx:136-140:Two things in it are now false against
main:getMapConfigfalls back to" is present tense about a literalObjectMapis the only view renderer that does not resolve marker titles throughgetRecordDisplayName— it reads a hard-coded'name'key instead #5953 removed.getMapConfigno longer fills an absent title binding at all, in either the flat branch or the default branch.'Marker'was never a literalgetMapConfigfell back to, even before that change — it is the else-arm of the read site's ternary (mapConfig.titleField ? record[mapConfig.titleField] : 'Marker'). WhatgetMapConfigfell back to was'name', which is a different placeholder reached on a different branch. The two produce visibly different symptoms — a declaredmapblock omittingtitleFieldyielded the uniform'Marker'; the flat and default branches yieldedundefined— and the comment merges them."the marker transform reads
record[titleField]" is also now a stale description of the mechanism (it resolves throughgetRecordDisplayName), though the sentence's actual claim — that the title is a real read rather than a forwarded prop — is still true and is still what the arm pins.Scope note
No assertion is involved and no coverage is affected. Every arm in the file asserts a positive title from a declared
titleField, and all six stayed green through #5953 unchanged; this is purely the historical narration above one of them.Unassigned; filed plainly for triage to grade.
Generated by Claude Code