finding(plugin-grid): ObjectGrid's `generateColumns()` is untyped (`any[]`), so nothing type-checks what it writes into `DataTableSchema.columns: TableColumn[]` — the hole that hid #5853 and #5453

[yinlianghui]

Found while measuring #5853 (TableColumn.type's three-way divergence). Filed unassigned, deliberately NOT absorbed into #5853, whose fence is data-display.ts + its zod mirror + data-table.tsx. This card is in plugin-grid and is the structural reason that class of drift stays invisible.

Measured (at 8d3a5294a)

packages/types/src/data-display.ts:487 types the boundary strictly:

columns: TableColumn[];

But the producer that fills it is untyped — packages/plugin-grid/src/ObjectGrid.tsx:1495:

const generateColumns = useCallback(() => {

No return-type annotation, and its call site at :2197 re-widens explicitly:

const columns = generateColumns().map((col: any) => {

So every column object ObjectGrid hands to data-table reaches a TableColumn[] slot as any. tsc checks nothing there.

Why it matters

The untyped boundary is not cosmetic — it is what lets producer/consumer vocabularies drift with a green build. Two independently-filed cards are the same hole seen from two sides:

• finding(types): TableColumn.type disagrees three ways — interface declares 8 literals, zod mirror accepts any string, renderer's live read set handles values outside the union via an as any cast #5853 — ObjectGrid.tsx:2206 writes next.type = fieldDef.type, forwarding the @objectstack/spec FieldType value verbatim (49 options). TableColumn.type declares 8 literals. 42 of those spec spellings are outside the declared union and tsc has never said a word — the mismatch only surfaced as an as any cast down in data-table.tsx:2151.
• [finding] ObjectGrid forwards a per-column wrap into the DataTable column object, but nothing in data-table.tsx ever reads it #5453 — ObjectGrid forwards a per-column wrap that nothing in data-table.tsx reads. An undeclared key surviving into a strict-typed slot is the same failure with the arrow reversed.

Typing the boundary turns both classes into build errors at the point they are introduced, instead of findings discovered months later by hand.

Suggested direction (not a decision — needs sizing)

Annotate generateColumns(): TableColumn[] and drop the (col: any) at the call site. Expect this to go red immediately and usefully: the type widening decision in #5853 is a prerequisite for the type key specifically, and the extra keys ObjectGrid attaches (headerIcon, options, pinned, wrap, essential) each need a verdict — declare on TableColumn, or stop forwarding. That triage is the substance of the card, so it should be sized before dispatch rather than treated as a one-line annotation.

Related

• finding(types): TableColumn.type disagrees three ways — interface declares 8 literals, zod mirror accepts any string, renderer's live read set handles values outside the union via an as any cast #5853 — the type value-vocabulary divergence this hole hid (blocked on a maintainer ruling on the canonical set)
• [finding] ObjectGrid forwards a per-column wrap into the DataTable column object, but nothing in data-table.tsx ever reads it #5453 — the unread wrap key, same untyped boundary
• finding(plugin-grid): ObjectGrid 在 ObjectGridSchema.columns 上容忍未声明的 accessorKey / header 拼写 —— 声明类型是 strict 的 ListColumn,#3104 的列身份门禁结构上看不见这条支路 #5068 / finding(react): bridgeListView emits object-grid columns in the undeclared accessorKey / header spelling — the one in-repo producer that depends on ObjectGrid's tolerance branch #5340 — the ListColumn input side of ObjectGrid's column tolerance (this card is the output side)

Generated by Claude Code

[os-zhuang]

Triage (label repair): filed bare — finding + domain:ui applied (plugin-grid producer boundary; observation awaiting first-touch grading). Note for the grading round: this is the structural hole named by both the #5853 escalation (now back in the decision box) and #5453 — grade it after #5853's ruling lands, since the ruled canonical-vocabulary shape decides what typing this boundary should assert.

---

Generated by Claude Code

[claude]

Concentrated triage round: finding → pm:queue, Task, domain:ui stands. Structural typing fix: annotate generateColumns(): TableColumn[] and remove the (col: any) re-widening at :2197, then repair the fallout honestly (each compile error is a real producer/consumer divergence of the class that hid #5853 and #5453 — fixing one by widening a type back to any is the outcome this card exists to prevent). Size: M, opus.

---

Generated by Claude Code