Skip to content

ObjectGantt.tsx: the navConfig comment is duplicated verbatim, two lines for two lines #6258

Description

@yinlianghui

Noticed while correcting the navigation example in packages/plugin-gantt/README.md (#6050). Out of that card's scope, so filed rather than fixed there.

The fact

packages/plugin-gantt/src/ObjectGantt.tsx:1148-1152 on main (2dc4aa709):

// Default to a right-side drawer so clicking a task opens an editable// detail panel inline (no full-page navigation). Schema can override by// providing its own `navigation` config (e.g., page mode).// detail panel inline (no full-page navigation). Schema can override by// providing its own `navigation` config (e.g., page mode).constnavConfig=schema.navigation??{mode: 'drawer',width: 'min(960px, 60vw)'};

The second and third comment lines are repeated verbatim as the fourth and fifth. The first line of the sentence (// Default to a right-side drawer so clicking a task opens an editable) is not repeated, so the duplicate reads as a mid-sentence fragment: the block now says "…providing its own navigation config (e.g., page mode). detail panel inline (no full-page navigation). Schema can override by providing its own navigation config (e.g., page mode)."

Severity

Cosmetic — comments only, no behaviour. Filed because the triage call on how much this class matters is not the implementer's to make at file time, and because the shape (a partial re-paste that leaves a sentence fragment behind) is the kind of thing that survives indefinitely once nobody re-reads the block.

Not in scope of #6050

#6050 is the README's navigation example. This block was read as the consumer evidence for that card — it is where schema.navigation lands — and the duplication was visible while reading it. The README fix touches no source file.

Metadata

Metadata

Assignees

Labels

domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpm:dispatched

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions