finding(components): `ui:context-menu` never reads an item's authored `icon` — dropdown-menu's identical twin, left behind by #5930

[yinlianghui-tw]

Found while re-measuring the lucide gate's header parenthetical for #5992 (PR #6277). Filed unassigned; out of that card's fence — #5992 changes what the gate judges, this is a renderer repair.

Sub-issue of #5931, which already owns "catalog fixtures declare child icon keys the renderer never reads" for button-group, breadcrumb and command. This adds a fourth container to that set, and it is the one with a materially different answer available.

What was measured

At ef2a3bd8d, every untyped node carrying a string icon in the schema catalog was enumerated and grouped by its nearest typed ancestor, then each container's renderer was read to see what it does with the key:

container	names	what the renderer does with icon
dropdown-menu	3	resolveIcon(item.icon) — repaired by #5930
context-menu	4	never reads icon
button-group	8	never reads button.icon (#5931)
breadcrumb	3	never reads icon (#5931)
command	9	never reads icon (#5931)
timeline	4	raw text, <span>{item.icon}</span> — the authored names are emoji, so this is arguably correct as-is
tree-view	30	a two-valued literal switch, node.icon === 'folder' — never a name lookup

packages/components/src/renderers/overlay/context-menu.tsx has no reference to icon at all. Its renderContextMenuItems is line-for-line the shape dropdown-menu.tsx had before #5930, including the same submenu recursion:

if (item.type === 'separator') return <ContextMenuSeparator key={i} />;
if (item.type === 'label') return <ContextMenuLabel key={i}>{item.label}</ContextMenuLabel>;
if (item.children) { … <ContextMenuSubTrigger inset={item.inset}>{item.label}</ContextMenuSubTrigger> … }
return (
 <ContextMenuItem key={i} …>
 {item.label}
 {item.shortcut && <ContextMenuShortcut>{item.shortcut}</ContextMenuShortcut>}
 </ContextMenuItem>
);

The four authored names live in examples/schema-catalog/src/schemas/components-overlay-context-menu/basic-context-menu.json — copy, scissors, clipboard, trash. All four are live icons keys today, so nothing renders wrong; they simply render nothing.

Why this one is different from #5931's other three

For button-group/breadcrumb/command the open question is whether the key should exist at all. For context-menu it is not open: its twin was answered three weeks ago. #5930 decided the shape (route through resolveIcon, i.e. the RECORD surface; LazyIcon explicitly ruled out because it degrades an unknown name to the Database glyph, trading a no-icon failure for a wrong-icon one) and decided that repairing only the leaf arm and not the submenu-trigger arm would be a narrower version of the same bug. A context-menu repair is that diff again, in a file next door.

Note on what will and will not catch it

#5992/PR #6277 makes the gate judge icon names on untyped child items of a container that declares it reads them. context-menu will correctly not declare that while its renderer does not read the key — so the gate stays silent here by construction, and correctly so. When this card is repaired, the census entry should be added in the same PR: one line, 'context-menu': { paths: [], descendants: true, min: 1, resolver: … }, and the fixture's four names come under judgement.

References

• packages/components/src/renderers/overlay/context-menu.tsx — the renderer
• packages/components/src/renderers/overlay/dropdown-menu.tsx — the repaired twin
• examples/schema-catalog/src/schemas/components-overlay-context-menu/basic-context-menu.json — the four names
• ui:dropdown-menu renders an item's authored icon as raw TEXT — the catalog fixture named with-icons.json draws the words "edit", "copy", "trash" beside its labels #5930 — the twin's repair, and the resolver-surface decision it records
• Catalog fixtures declare child icon keys that button-group, breadcrumb and command never read — two of them are named with-icons.json and render none #5931 — the parent class
• finding(tooling): the lucide icon-record gate cannot see icons on UNTYPED child nodes, so dropdown-menu item icons stay unjudged even now that they reach a resolver #5992 / fix(tooling): judge lucide icon names on untyped child items of a declared container #6277 — where this was measured; the gate change is not addressed by this card and this card is not addressed there

Generated by Claude Code

[yinlianghui-tw]

Triage: pm:queue + domain:ui, type Bug — four authored icon names render nothing today, and unlike the parent #5931's other three containers this one's question is already answered: inherit the #5930 twin ruling with its reasons (route through resolveIcon, the RECORD surface; LazyIcon stays ruled out — it trades a no-icon failure for a wrong-icon one; repair BOTH the leaf arm and the submenu-trigger arm, since #5930 records that a leaf-only repair is a narrower version of the same bug). Add the census entry ('context-menu': { … }) in the same PR so the four fixture names come under the gate's judgement, per the card's own note. Only a real semantic difference from the dropdown-menu shape re-opens the ruling — bounce, don't improvise. Parent #5931 keeps the three genuinely-open containers; this card does not decide them.

---

Generated by Claude Code

[os-support-ai]

Claim: PM loop round R1 (wave 3 — Bug-first, on the maintainer's standing order 「本车道应该优先处理bug」)
Session: session_011SfZeFWrhGLHmfq61xbz4q
Branch: claude/issue-6278-context-menu-icon
Worktree: objectui-issue-6278
Domain: domain:ui
File surface: packages/components/src/renderers/overlay/context-menu.tsx + its tests (stop on breach; explain in the report)
Container & model: M, mode:subagent, model: opus
Clause-②: no — a renderer starts reading a key its authored fixtures already carry and its twin already honours. No contract schema, no accept set, no public surface.
Serial constraints cleared — checked by file, ⛔ not by package name:

• ⚠️ PR fix(components): forward the declared onSuccess block on all four action surfaces #6304 is open on packages/components (onSuccess is authorable as of @objectstack/spec 17.1.0 and honoured by ActionRunner, but all four declared action surfaces drop it one hop before the runner #5493, the onSuccess forward). Its exact changed-file list was read: 8 files, all under renderers/action/ plus scripts/check-action-forward-parity.mjs and a changeset. Zero under renderers/overlay/. Disjoint — but branch from a freshly fetched main, it may land while you work.
• ⛔ Consolidate the eight lucide record-reading icon resolvers into one seam — three tokenisers and a 5-of-8 alias map mean the same authored name renders on one surface and not another #5935 is queued on the shared icon seam ("consolidate the eight lucide record-reading icon resolvers"). It is not in flight and ⛔ must not be dispatched alongside this card — it would rewrite the very resolver this card routes into. Recording the serial here so the next picker sees it.
• Other cards in flight this wave are on packages/plugin-designer + app-shell/services, examples/schema-catalog + apps/site, packages/plugin-gantt, and packages/fields/src/widgets/ — all disjoint.

裁决 (binding)

Mirror #5930's repair, which decided this exact shape three weeks ago on this file's twin. Route the item's authored icon through resolveIcon — the RECORD surface.

⛔ LazyIcon is explicitly ruled out and this is not reopenable: it degrades an unknown name to the Database glyph, trading a no-icon failure for a wrong-icon one. #5930 made that call for dropdown-menu; the same reasoning governs here.

⭐ Repair BOTH arms — the leaf item AND the submenu trigger. #5930 also decided that fixing only the leaf arm and leaving the submenu-trigger arm is "a narrower version of the same bug". renderContextMenuItems carries the same submenu recursion dropdown-menu.tsx had before #5930.

⭐ Read #5930's diff before writing. This card's own framing is that the repair is "that diff again, in a file next door". ⛔ Do not reinvent the shape; port it.

PM 机制假设 (verify — rebut freely; 实测优先)

1. Card measured at ef2a3bd8d; main is now well past it. ⛔ Re-derive every line number, and re-confirm context-menu.tsx still has no reference to icon at all. ⭐ A zero-hit is only a reading once a known-present control has been probed on the same pathspec — probe something you know is there (shortcut, label) and quote both numbers.
2. The four authored names live in examples/schema-catalog/src/schemas/components-overlay-context-menu/basic-context-menu.json — copy, scissors, clipboard, trash. The card says all four are live icons keys today, so nothing renders wrong, they simply render nothing. Verify they still resolve — if any has been retired since, the fixture needs its own answer and that is worth reporting before you build.
3. ⚠️ This is a sub-issue of Catalog fixtures declare child icon keys that button-group, breadcrumb and command never read — two of them are named with-icons.json and render none #5931, which owns the same shape for button-group, breadcrumb and command. ⛔ Those three are NOT in scope — for them the open question is whether the key should exist at all, and Catalog fixtures declare child icon keys that button-group, breadcrumb and command never read — two of them are named with-icons.json and render none #5931 is pm:blocked on that. This card is separable only because its twin was already answered. ⛔ Do not touch them, and ⛔ do not "generalise" the fix across containers.
4. timeline (raw text, emoji) and tree-view (a two-valued literal switch) are deliberately different per the card's own table. ⛔ Not in scope.

Verification

⭐ The assertion must distinguish the two worlds. Assert the rendered icon element for an item with an authored icon, ⛔ not "the menu renders" and ⛔ not that the label is present — both pass today. Prove it red before the fix, on both arms (leaf item and submenu trigger) as separate rows, so a leaf-only repair cannot read as complete.

⭐ Ablation: revert each arm alone, prove the mutation on disk in both directions (grep the injected text and separately the removed text — a mutation that silently no-ops while exiting 0 has already cost a run in this lane today), show only that arm's row go red. Restore under trap … EXIT INT TERM with a cwd-independent command; git diff HEAD --stat empty afterwards. Commit before you ablate.

⚠️ Trap species by name: ghost assertion (cannot fail in either world) · degenerate control (control reads the same as subject because the harness did nothing — a positive control is the only catch) · blind instrument (asserting a className rather than the resolved icon) · stale dist/ (a cached turbo green is not a measurement — use --force) · cross-test leakage.

⚠️ Repo facts: vitest from the repo root (pnpm exec vitest run PATHS) — ⛔ --filter / cd packages/x forms hit a guard (objectui#3378) that in one observed form silently ran the wrong package and reported green; sanity-check the reported file/test count against the target's own. vitest's console is silenced here — write results to a file. type-check is hyphenated. ⚠️ The full packages/components suite (190 files) has twice today failed to produce a result inside the container's ~10-minute foreground cap under contention — if you narrow, narrow on a measured population and declare it; ⛔ never report an unrun suite as green. Changeset: node scripts/check-changeset-presence.mjs; ⛔ never major.

⭐ Read-channel clause — CORRECTED this round, use the new order

1. git first — free. Shallow clone: git fetch --deepen=500 origin before any merge-base/A...B work.
2. ⭐ UNAUTHENTICATED REST — https://api.github.com/repos/objectstack-ai/objectui/issues/6278 and .../comments?per_page=100. Measured working today: HTTP 200, complete. The seat post's "every repo-scoped REST path is 403" holds only with a token — drop the auth header and it works. Wrapper: python3 /home/user/pmtools/gh_issue.py 6278, which now reads REST and prints a completeness verdict.
3. ⛔ The rendered HTML page is FALLBACK ONLY and it silently truncates — measured today it served 15 of 31 timeline items while reporting no error, which is how a comment went missing and got misdiagnosed as lag. ⛔ Never treat a record count as complete without comparing it to a declared total.
4. MCP/GraphQL for writes, plus the one dedup search before filing an out-of-scope finding (explicitly exempt — REST /search/issues is 403 through this proxy, so MCP search_issues is the only route; validate its zero-hit with a positive control).

Deliverables

• ⭐ Leave your OWN claim comment on finding(components): ui:context-menu never reads an item's authored icon — dropdown-menu's identical twin, left behind by #5930 #6278 with your own branch and worktree. ⚠️ Your session id will match the PM's (you run as a subagent inside it) — say so explicitly rather than omitting the line; branch + worktree are what distinguish the seat. ⛔ Do not touch the assignee.
• Draft PR targeting main, first line Fixes #6278. ⛔ Do not mark ready, enqueue, or enable auto-merge.
• Terminal report as an issue comment on finding(components): ui:context-menu never reads an item's authored icon — dropdown-menu's identical twin, left behind by #5930 #6278 first, then as your return message. ⛔ The HTML-comment marker does not survive this repo's sanitizer — plain-text first line os-dev-report, then the JSON.
• ⭐ Predict the direction of each measurement before running it, and report every place you were wrong.

---

Generated by Claude Code

[os-support-ai]

Dev claim (os-dev seat, dispatched by the PM claim above).

• Session: session_011SfZeFWrhGLHmfq61xbz4q — the same id as the PM's claim comment above, by construction: I run as a subagent inside that session. Branch + worktree are what distinguish this seat, not the session id.
• Branch: claude/issue-6278-context-menu-icon (pushed empty at 090927f4f as a write-route probe before any edit — probe green)
• Worktree: /home/user/objectui-issue-6278
• Base: freshly fetched origin/main = 090927f4f (well past the card's ef2a3bd8d; PR fix(components): forward the declared onSuccess block on all four action surfaces #6304 not yet landed at branch point)
• File surface: packages/components/src/renderers/overlay/context-menu.tsx + its tests, plus the finding(tooling): the lucide icon-record gate cannot see icons on UNTYPED child nodes, so dropdown-menu item icons stay unjudged even now that they reach a resolver #5992/fix(tooling): judge lucide icon names on untyped child items of a declared container #6277 census entry the card's own note asks for in the same PR. Assignee untouched.

Scope taken exactly as ruled: mirror #5930 (resolveIcon, the RECORD surface; LazyIcon ruled out), both arms — leaf item and submenu trigger. Not touching button-group/breadcrumb/command (#5931, pm:blocked), timeline, tree-view, or the #5935 resolver consolidation.

---

Generated by Claude Code