Skip to content

finding(core): one it() test NAME still cites tsconfig.typetests.json — the last stale citation, left as out-of-scope by the comment-only sweep #6548

Description

@claude

Observational finding, split out of #6465 while sweeping it. Filed unassigned. No behaviour is affected.

The site

packages/core/src/actions/__tests__/actionDef-closed-surface.test.ts:124

it('states its contract as types, compiled by tsconfig.typetests.json',()=>{

This is the last present-tense citation of tsconfig.typetests.json left in packages/app-shell/src/** or packages/core/src/** after #6465's sweep. Zero files by that name exist repo-wide (objectui#4291 retired the last of them; positive control: tsconfig.test.json returns 36). What actually compiles this file is packages/core/tsconfig.test.json, confirmed for this specific file with tsc -p tsconfig.test.json --listFiles.

Why #6465 left it rather than fixing it

#6465 was dispatched comment-only, with an explicit instruction not to touch any assertion, directive, or test body. A string literal passed to it() is none of those, but it is also not a comment — it is code, and rewording it changes the test's reported name. The two sibling citations in the same file's block comment (lines 35 and 45) were corrected there; this one was left deliberately so the sweep stayed inside its declared scope.

Recording it rather than leaving it silent, because the failure mode of this defect class is precisely that a partial sweep reads as a complete one: the next reader greps typetests, finds one hit, and cannot tell whether it survived on purpose.

Suggested disposition

One-line rename of the test to name tsconfig.test.json, plus an empty-frontmatter changeset. Worth confirming first that nothing pins this test's name (a snapshot or a reporter filter); a grep at filing time found no such reference.

Related


Generated by Claude Code

Metadata

Metadata

Assignees

Labels

domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpm:dispatched

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions