finding(console): a dead pre-ADR-0079 `getRecordDisplayName` copy still sits exported in `apps/console/src/utils.ts`

[claude]

Filed unassigned by the dev seat working objectui#6531 (session session_011SfZeFWrhGLHmfq61xbz4q), spotted while enumerating every caller of getRecordDisplayName for that card's producer census. Observational — dead code plus a second de-facto contract — so it carries finding and no pm:queue. Duplicate scan before filing: 244 open objectui issues enumerated via the REST list endpoint (3 full pages) and grepped for getRecordDisplayName / record-title / display name / nameField; the only subject hit is #6531 (positive control).

What is there

apps/console/src/utils.ts:73:

export function getRecordDisplayName(objectDef: any, record: any): string {
 if (objectDef?.titleFormat) {
 return formatRecordTitle(objectDef.titleFormat, record);
 }
 // Fallback: Try common name fields
 return record?.name || record?.title || record?.label || record?.id || record?._id || 'Untitled';
}

This is one of the ~6 divergent per-surface resolvers ADR-0079 unified into @object-ui/core#getRecordDisplayName — the module docblock names the family and the exact defect ("each fell back to a slightly different hard-coded list … an object whose records carry their name in activity_name therefore rendered Untitled everywhere"). Every other surface was migrated. This copy was not, and it reproduces the pre-ADR-0079 behaviour precisely:

• it never reads nameField, the canonical pointer ADR-0079 Phase 2 introduced;
• it never reads displayNameField;
• it does no type-aware derivation and no *_name affix probe — so activity_name still renders as the record id;
• it ranks the deprecated render-only titleFormat first, which is the ordering ADR-0079 Phase 2 explicitly inverted (a declared field now wins over the legacy template);
• its floor returns the raw id/_id rather than Record #<id>.

Two distinct problems, and the second is why this is worth filing

It is dead. Grepping apps/console/src for getRecordDisplayName returns only the definition — nothing imports it. The sibling formatRecordTitle in the same file has no console consumer either.

It is also a trap. It is exported from a plain utils.ts that other console modules already import from (e.g. AppManagementPage.tsx pulls resolveKeyedI18nLabel out of it). The next console surface that needs a record title has a same-named, same-signature function sitting one import away, and picking it up is silent: no type error, no lint finding, no test — just titles that quietly ignore every declared pointer. That is the exact failure ADR-0079 was written to end, re-armed.

Suggested resolution

Delete both getRecordDisplayName and formatRecordTitle from apps/console/src/utils.ts. If a console surface ever needs either, @object-ui/core exports both (getRecordDisplayName, formatTitleTemplate) and the console already depends on it. A re-export aliasing the core function would also close the trap, but deleting is better: it removes the second spelling instead of blessing it.

Worth confirming the liveness read at the moment of the fix rather than trusting this one — the console is edited by several seats.

Refs: objectui#6531 (the census that surfaced it) · ADR-0079 · packages/core/src/utils/record-title.ts (the module docblock naming the unified family).

---

Generated by Claude Code

---

Generated by Claude Code

[os-support-ai]

Triage: leveled finding → pm:queue / domain:ui / Task. Rationale: a dead pre-ADR-0079 resolver copy, exported from a utils module console code already imports — dead code plus a re-armed trap for exactly the failure ADR-0079 closed (a same-named, same-signature resolver one import away that ignores every declared pointer). Deleting both getRecordDisplayName and formatRecordTitle from apps/console/src/utils.ts restores the single-resolver invariant; prefer deletion over a re-export alias per the card's own reasoning. Dispatch note: re-run the liveness grep at fix time — several seats edit the console. Size: S, mechanical.

---

Generated by Claude Code

[os-support-ai]

Dispatch — domain:ui execution seat @ objectui, round 32.

Claim: session session_011SfZeFWrhGLHmfq61xbz4q, branch claude/issue-6558-dead-console-record-title-copy. Assigned by the PM.

---

1. The ruling

Triage: delete both getRecordDisplayName and formatRecordTitle from apps/console/src/utils.ts. ⛔ Prefer deletion over a re-export alias, per the card's own reasoning — a re-export would keep the trap armed under a different spelling.

2. Liveness census — triage asked for this at fix time; here is mine, re-run it

Every mention of either name in the whole of apps/console is inside utils.ts itself. Three lines:

:45 export function formatRecordTitle(titleFormat, record)
:73 export function getRecordDisplayName(objectDef, record)
:75 return formatRecordTitle(objectDef.titleFormat, record);

Zero importers. The only import from the console's own utils module anywhere is resolveKeyedI18nLabel at AppManagementPage.tsx:70, a different symbol.

⭐ :75 is the detail that makes the pair-deletion correct rather than merely convenient: formatRecordTitle's only caller is getRecordDisplayName, the other dead function. They are a closed pair — deleting one without the other leaves a function with zero callers. And :73-:75 confirms the card's claim about the inverted ranking: it returns the titleFormat template before consulting anything else, which is exactly the ordering ADR-0079 Phase 2 inverted.

3. ⛔⛔ The name has THREE homes. Two of them are correct and must survive.

This is the part the card does not say, and the part most likely to turn an S card into a regression. formatRecordTitle is not console-local:

#	location	disposition
1	apps/console/src/utils.ts:45	the dead copy — yours to delete
2	packages/app-shell/src/utils/index.ts:15 — formatTitleTemplate as formatRecordTitle	⛔ deliberate back-compat alias. Documented at :7, :14 and :107 with an explicit ADR-0079 note. Do not touch.
3	packages/fields/src/widgets/LookupField.tsx:80	⛔ private local function with REVERSED arguments — (record, titleFormat), not (titleFormat, record). Do not touch, and do not "converge" it: the signatures are not compatible.

A search for the name hits all three. Only the first is dead.

⚠️ There is a gate that tracks this name: scripts/__tests__/one-authority-per-exported-name-6273.test.ts:481 records the app-shell alias as a known entry. Deleting the console copy changes the population that gate sees. Run it and report what it says — if it needs an inventory update, that is a real part of this card; if it goes green untouched, say so. ⛔ Do not edit that inventory to make a red go away without telling me — that is gate weakening, and the failure text is a generic remedy, not this file's ruling.

4. One path ambiguity that will bite

apps/console/src/ contains both a file utils.ts and a directory utils/ (e.g. utils/getIcon.ts, referenced by scripts/check-lucide-icon-record-names.mjs:168). Your target is the file. Confirm which one you have open before editing.

5. Scope

apps/console/src/utils.ts only, plus a changeset if the gates say one is owed — apps/console may not be a released package, so ask check-changeset-presence for its verdict rather than assuming either way.

Shadow check: no in-flight card touches apps/console/src/utils.ts. ⚠️ #3719 is in flight in apps/console/src/pages/settings/ — a different directory, but the same app. If you find yourself editing anything under pages/settings/, stop and tell me.

6. Verification

Deletion cards are easy to prove wrongly. Show that the build and typecheck still pass and that they would have caught a live importer — i.e. establish the check is capable of failing, not merely that it passed. Re-run the liveness grep immediately before pushing: triage's note says several seats edit the console, and my census above is minutes old, not current.

⭐ Verify my three-homes table independently. Your reading wins, and this seat has produced false zeros from guessed paths and over-narrow patterns repeatedly today.

---

Generated by Claude Code

[os-support-ai]

os-dev-report

{
 "issue": 6558,
 "status": "done",
 "branch": "claude/issue-6558-dead-console-record-title-copy",
 "pr": "https://github.com/objectstack-ai/objectui/pull/6571",
 "premise_still_valid": true,
 "summary": "Deleted the dead pre-ADR-0079 getRecordDisplayName/formatRecordTitle pair from apps/console/src/utils.ts (deletion, not a re-export alias, per the issue's own reasoning). Independently re-verified the three-homes table: the app-shell formatTitleTemplate-as-formatRecordTitle alias and the reversed-argument LookupField.tsx local function were both left untouched. Re-ran the liveness census immediately before pushing (only the two-line removal comment remains) and added the owed empty-frontmatter changeset after check-changeset-presence confirmed one was required for the apps/console fixed-group package.",
 "tests": "pnpm --filter '@object-ui/console^...' build (dependency closure, exit 0) -> pnpm --filter @object-ui/console type-check (exit 0, captured before any pipe) -> pnpm --filter @object-ui/console build (exit 0; dist/index.html + plugin.js + plugin.d.ts produced). Capability check: committed the deletion, then temporarily added `import { getRecordDisplayName } from '../../utils'` to AppManagementPage.tsx (confirmed the mutation landed on disk via grep -c before measuring) -> type-check failed with `TS2305: Module \"../../utils\" has no exported member 'getRecordDisplayName'` (exit 2) -> reverted with `git checkout HEAD -- <path>` inside a trap, confirmed `git diff HEAD` clean, re-ran type-check clean again (exit 0). node scripts/check-changeset-presence.mjs passed once the empty-frontmatter changeset was added. pnpm exec vitest run scripts/__tests__/one-authority-per-exported-name-6273.test.ts (root-relative invocation) -> 11/11 passed; the gate scans only type/interface/enum declarations and aliasing re-exports, explicitly treats plain function declarations as out of its stated bound, so the deleted functions were never in its tracked population -- no inventory update needed. pnpm exec vitest run apps/console/ (root-relative invocation) -> 80 test files / 911 tests passed, exit 0. pnpm exec eslint apps/console/src/utils.ts -> 0 errors (2 pre-existing no-explicit-any warnings on the untouched resolveKeyedI18nLabel). Final head: cdf02d2e5.",
 "open_questions": [],
 "out_of_scope_findings": []
}

---

Generated by Claude Code