Skip to content

finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

Description

@os-sam

Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

What was measured

#6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

workspace-specifier call sites : 545
inherits : 240
frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere

Per specifier:

specifierfrozen
@object-ui/auth92
@object-ui/i18n34
@object-ui/collaboration25
@object-ui/plugin-form24
@object-ui/components22
@object-ui/permissions20
@object-ui/app-shell20
@object-ui/plugin-grid17
@object-ui/plugin-chatbot11
@object-ui/plugin-designer10
@object-ui/fields8
@object-ui/plugin-list6
@object-ui/plugin-detail4
@object-ui/plugin-dashboard2
@object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

Reproduce with the guard on this tree:

node scripts/check-vi-mock-inherit.mjs --list

...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

Why each of these is the same defect

A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

@object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

Why the guard cannot simply be widened today

Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

Suggested shape

One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
       blocks
      (function() {
      function addCopyButtons() {
      document.querySelectorAll('pre code').forEach(function(codeBlock) {
      if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
      codeBlock.parentElement.setAttribute('data-copy-added', 'true');
      var btn = document.createElement('button');
      btn.textContent = 'Copy';
      btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
      btn.onmouseover = function() { this.style.opacity = '1'; };
      btn.onmouseout = function() { this.style.opacity = '0.7'; };
      btn.onclick = function() {
      navigator.clipboard.writeText(codeBlock.textContent).then(function() {
      btn.textContent = 'Copied!';
      setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
      });
      };
      codeBlock.parentElement.style.position = 'relative';
      codeBlock.parentElement.appendChild(btn);
      });
      }
      addCopyButtons();
      // Re-run on dynamic content
      var observer = new MutationObserver(addCopyButtons);
      observer.observe(document.body, { childList: true, subtree: true });
      })();
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      finding(test-infra): 298 more `vi.mock` factories freeze a workspace package's export surface — the per-specifier sweep worklist · Issue #6892 · objectstack-ai/objectui · GitHub
      Skip to content

      finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

      Description

      @os-sam

      Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

      What was measured

      #6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

      workspace-specifier call sites : 545
      inherits : 240
      frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere
      

      Per specifier:

      specifierfrozen
      @object-ui/auth92
      @object-ui/i18n34
      @object-ui/collaboration25
      @object-ui/plugin-form24
      @object-ui/components22
      @object-ui/permissions20
      @object-ui/app-shell20
      @object-ui/plugin-grid17
      @object-ui/plugin-chatbot11
      @object-ui/plugin-designer10
      @object-ui/fields8
      @object-ui/plugin-list6
      @object-ui/plugin-detail4
      @object-ui/plugin-dashboard2
      @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

      Reproduce with the guard on this tree:

      node scripts/check-vi-mock-inherit.mjs --list
      

      ...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

      Why each of these is the same defect

      A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

      @object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

      Why the guard cannot simply be widened today

      Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

      Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

      So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

      Suggested shape

      One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

      PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

      ⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

      Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' finding(test-infra): 298 more `vi.mock` factories freeze a workspace package's export surface — the per-specifier sweep worklist · Issue #6892 · objectstack-ai/objectui · GitHub
          Skip to content

          finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

          Description

          @os-sam

          Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

          What was measured

          #6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

          workspace-specifier call sites : 545
          inherits : 240
          frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere
          

          Per specifier:

          specifierfrozen
          @object-ui/auth92
          @object-ui/i18n34
          @object-ui/collaboration25
          @object-ui/plugin-form24
          @object-ui/components22
          @object-ui/permissions20
          @object-ui/app-shell20
          @object-ui/plugin-grid17
          @object-ui/plugin-chatbot11
          @object-ui/plugin-designer10
          @object-ui/fields8
          @object-ui/plugin-list6
          @object-ui/plugin-detail4
          @object-ui/plugin-dashboard2
          @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

          Reproduce with the guard on this tree:

          node scripts/check-vi-mock-inherit.mjs --list
          

          ...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

          Why each of these is the same defect

          A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

          @object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

          Why the guard cannot simply be widened today

          Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

          Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

          So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

          Suggested shape

          One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

          PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

          ⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

          Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' finding(test-infra): 298 more `vi.mock` factories freeze a workspace package's export surface — the per-specifier sweep worklist · Issue #6892 · objectstack-ai/objectui · GitHub
              Skip to content

              finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

              Description

              @os-sam

              Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

              What was measured

              #6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

              workspace-specifier call sites : 545
              inherits : 240
              frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere
              

              Per specifier:

              specifierfrozen
              @object-ui/auth92
              @object-ui/i18n34
              @object-ui/collaboration25
              @object-ui/plugin-form24
              @object-ui/components22
              @object-ui/permissions20
              @object-ui/app-shell20
              @object-ui/plugin-grid17
              @object-ui/plugin-chatbot11
              @object-ui/plugin-designer10
              @object-ui/fields8
              @object-ui/plugin-list6
              @object-ui/plugin-detail4
              @object-ui/plugin-dashboard2
              @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

              Reproduce with the guard on this tree:

              node scripts/check-vi-mock-inherit.mjs --list
              

              ...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

              Why each of these is the same defect

              A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

              @object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

              Why the guard cannot simply be widened today

              Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

              Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

              So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

              Suggested shape

              One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

              PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

              ⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

              Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' finding(test-infra): 298 more `vi.mock` factories freeze a workspace package's export surface — the per-specifier sweep worklist · Issue #6892 · objectstack-ai/objectui · GitHub
                  Skip to content

                  finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

                  Description

                  @os-sam

                  Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

                  What was measured

                  #6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

                  workspace-specifier call sites : 545
                  inherits : 240
                  frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere
                  

                  Per specifier:

                  specifierfrozen
                  @object-ui/auth92
                  @object-ui/i18n34
                  @object-ui/collaboration25
                  @object-ui/plugin-form24
                  @object-ui/components22
                  @object-ui/permissions20
                  @object-ui/app-shell20
                  @object-ui/plugin-grid17
                  @object-ui/plugin-chatbot11
                  @object-ui/plugin-designer10
                  @object-ui/fields8
                  @object-ui/plugin-list6
                  @object-ui/plugin-detail4
                  @object-ui/plugin-dashboard2
                  @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

                  Reproduce with the guard on this tree:

                  node scripts/check-vi-mock-inherit.mjs --list
                  

                  ...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

                  Why each of these is the same defect

                  A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

                  @object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

                  Why the guard cannot simply be widened today

                  Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

                  Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

                  So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

                  Suggested shape

                  One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

                  PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

                  ⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

                  Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Type

                    No type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' finding(test-infra): 298 more `vi.mock` factories freeze a workspace package's export surface — the per-specifier sweep worklist · Issue #6892 · objectstack-ai/objectui · GitHub
                      Skip to content

                      finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

                      Description

                      @os-sam

                      Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

                      What was measured

                      #6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

                      workspace-specifier call sites : 545
                      inherits : 240
                      frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere
                      

                      Per specifier:

                      specifierfrozen
                      @object-ui/auth92
                      @object-ui/i18n34
                      @object-ui/collaboration25
                      @object-ui/plugin-form24
                      @object-ui/components22
                      @object-ui/permissions20
                      @object-ui/app-shell20
                      @object-ui/plugin-grid17
                      @object-ui/plugin-chatbot11
                      @object-ui/plugin-designer10
                      @object-ui/fields8
                      @object-ui/plugin-list6
                      @object-ui/plugin-detail4
                      @object-ui/plugin-dashboard2
                      @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

                      Reproduce with the guard on this tree:

                      node scripts/check-vi-mock-inherit.mjs --list
                      

                      ...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

                      Why each of these is the same defect

                      A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

                      @object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

                      Why the guard cannot simply be widened today

                      Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

                      Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

                      So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

                      Suggested shape

                      One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

                      PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

                      ⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

                      Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Type

                        No type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' finding(test-infra): 298 more `vi.mock` factories freeze a workspace package's export surface — the per-specifier sweep worklist · Issue #6892 · objectstack-ai/objectui · GitHub
                          Skip to content

                          finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

                          Description

                          @os-sam

                          Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

                          What was measured

                          #6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

                          workspace-specifier call sites : 545
                          inherits : 240
                          frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere
                          

                          Per specifier:

                          specifierfrozen
                          @object-ui/auth92
                          @object-ui/i18n34
                          @object-ui/collaboration25
                          @object-ui/plugin-form24
                          @object-ui/components22
                          @object-ui/permissions20
                          @object-ui/app-shell20
                          @object-ui/plugin-grid17
                          @object-ui/plugin-chatbot11
                          @object-ui/plugin-designer10
                          @object-ui/fields8
                          @object-ui/plugin-list6
                          @object-ui/plugin-detail4
                          @object-ui/plugin-dashboard2
                          @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

                          Reproduce with the guard on this tree:

                          node scripts/check-vi-mock-inherit.mjs --list
                          

                          ...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

                          Why each of these is the same defect

                          A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

                          @object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

                          Why the guard cannot simply be widened today

                          Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

                          Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

                          So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

                          Suggested shape

                          One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

                          PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

                          ⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

                          Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Type

                            No type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); finding(test-infra): 298 more `vi.mock` factories freeze a workspace package's export surface — the per-specifier sweep worklist · Issue #6892 · objectstack-ai/objectui · GitHub
                              Skip to content

                              finding(test-infra): 298 more vi.mock factories freeze a workspace package's export surface — the per-specifier sweep worklist #6892

                              Description

                              @os-sam

                              Surfaced while implementing #6849. Filed unassigned. Deliberately not fixed there — that card installs the ratchet on the one specifier that has been swept; this is the population the ratchet cannot cover yet.

                              What was measured

                              #6849's guard (scripts/check-vi-mock-inherit.mjs) classifies every vi.mock factory in the tree by whether it OBTAINS the real module (a callback parameter under any name, or vi.importActual of the same specifier) and SPREADS it. Run over all 1,499 call sites at 9ce20233f, restricted to workspace specifiers:

                              workspace-specifier call sites : 545
                              inherits : 240
                              frozen : 299 <- 1 on @object-ui/react (fixed in #6849), 298 elsewhere
                              

                              Per specifier:

                              specifierfrozen
                              @object-ui/auth92
                              @object-ui/i18n34
                              @object-ui/collaboration25
                              @object-ui/plugin-form24
                              @object-ui/components22
                              @object-ui/permissions20
                              @object-ui/app-shell20
                              @object-ui/plugin-grid17
                              @object-ui/plugin-chatbot11
                              @object-ui/plugin-designer10
                              @object-ui/fields8
                              @object-ui/plugin-list6
                              @object-ui/plugin-detail4
                              @object-ui/plugin-dashboard2
                              @object-ui/plugin-markdown, @object-ui/data-objectstack, @object-ui/plugin-report1 each

                              Reproduce with the guard on this tree:

                              node scripts/check-vi-mock-inherit.mjs --list
                              

                              ...and widen COVERED_SPECIFIERS locally to re-derive the table. ⛔ Do not commit a widened list without the sweep — see below.

                              Why each of these is the same defect

                              A factory that hand-lists its exports pins the mock at whatever was typed that day. The next export any module in the file's import graph reads AT MODULE SCOPE resolves to undefined and the file dies during COLLECTION. Measured on #6768: Test Files 3 failed | 546 passed with Tests 6694 passedzero failed assertions, because those files' tests never ran. It reads as flake, and the bill lands on whoever added the export, in a red suite that does not point at them.

                              @object-ui/auth at 92 sites is worth its own sentence: it is the single largest frozen population in the tree and it is a package whose surface grows.

                              Why the guard cannot simply be widened today

                              Triage's ruling on #6849 (R+34) was NARROW, on the explicit ground that the gate is free while the tree is at zero — "窄口径今天是免费的。树在 0/106,门以棘轮起步". That is true of @object-ui/react and of nothing else: pointing the same gate at every @object-ui/* specifier lands it RED on 298 sites, which is a sweep, not a ratchet.

                              Triage also ruled out the escape hatch, and was right to: "宽了以后要收窄,是在一堆红里做例外表 —— 那正是例外表长成沼泽的路径". A 298-entry exemption ledger is exactly that swamp.

                              So the guard's COVERED_SPECIFIERS is grow-only and its documented widening precondition is a sweep, per specifier: convert that specifier's frozen factories to the inheriting form, confirm the guard reads zero for it, and add it to the list in the same PR. That is what this card is the worklist for.

                              Suggested shape

                              One card per specifier rather than one card for 298 sites — each is independently landable, each ends with a one-line addition to COVERED_SPECIFIERS, and a stalled one blocks nothing. @object-ui/auth first, on population; @object-ui/plugin-markdown / @object-ui/data-objectstack / @object-ui/plugin-report are one site each and are effectively free.

                              PR #6847 is the worked example of the conversion (25 sites, with a two-leg ablation demonstrating the failure and its removal).

                              ⚠️Re-derive the numbers before acting on them. They are a snapshot at 9ce20233f, taken with the guard rather than with a grep — and the whole reason #6849 exists is that the previous figures came from a grep and were wrong in both directions.

                              Related: #6580 (a different importOriginal concern — the ~10s cost of inheriting through the source-aliased @object-ui/app-shell barrel). Worth reading before sweeping @object-ui/app-shell's 20, since inheriting is what that card measures the cost of.

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Type

                                No type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions