') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); finding(fields): FieldEditWidget declares the whole DOM pass-through block but forwards only `autoFocus` — a host's `onBlur` / `onFocus` / `id` / `name` / `tabIndex` silently never reach the control · Issue #6909 · objectstack-ai/objectui · GitHub
Skip to content

finding(fields): FieldEditWidget declares the whole DOM pass-through block but forwards only autoFocus — a host's onBlur / onFocus / id / name / tabIndex silently never reach the control #6909

Description

@claude

Found while measuring objectui#6859. Filed rather than folded in: it is a different
defect class from that card (which is about the data table's commit path), and it sits
one layer ABOVE the widgets rather than in them.

What

packages/fields/src/FieldEditWidget.tsx declares its props as
FieldWidgetComponentProps (generic over any). That type is the controlled-input keys
intersected with FieldWidgetDomProps, AriaAttributes, and an open data- family, so
a caller may pass id, name, autoFocus, tabIndex, onBlur, onFocus, onClick,
any aria- and any data- attribute with no type error at all.

The component body then destructures { field, value, onChange, readonly, autoFocus }
and renders the resolved widget with exactly those five plus compact. Everything
else is silently dropped.
Only autoFocus survives out of the whole DOM pass-through
block, and its doc comment explains why it in particular was forwarded — which reads
like an incomplete pass-through rather than a designed narrowing.

Why this is the repo's own first-class class

This is the @object-ui/fields DECLARED-BUT-NOT-DELIVERED shape, named as first-class
in packages/fields/src/widgets/toDomProps.ts — "a key that type-checks, reads as
supported, and silently never reaches the element" (objectui#3290's aria-required,
objectui#3222's validation slot). The compile-time assertions in that file bind the
widget contract to the whitelist in both directions. Nothing binds THIS factory to
either.

The measurement that makes it concrete

Counted over EDIT_WIDGETS for objectui#6859: all 27 components the map resolves to
already deliver the host's DOM set to a real control — 26 call toDomProps themselves,
UserField delegates its whole props object to LookupField. None of them strips
onBlur.

So the widgets are not the gap; this factory is. Concretely: the data table's
renderCellEditor seam could never hand an injected cell editor an onBlur, however
willing the widget, because a host handler cannot get past this destructure.

Hosts to weigh before grading: ObjectGrid.renderCellEditor (packages/plugin-grid),
InlineFieldInput (packages/plugin-detail), RequiredFieldsDialog
(packages/plugin-kanban). Whether any passes one of these keys today is the triage
question; the compiler currently says all of them may.

Directions (not a proposal to widen anything)

  1. Forward the declared block — declared = enforced, the direction toDomProps itself
    takes. The widgets already whitelist what may reach the DOM, so the factory would be
    passing through, not reopening a spread.
  2. Or narrow this component's declared prop type to the five keys it actually honours,
    so passing the others becomes a compile error instead of a silent drop.

Either closes it; the first matches how the rest of the package resolved the same
question. Unassigned and ungraded on purpose — filed by the objectui#6859 seat.

Generated by Claude Code


Generated by Claude Code

Metadata

Metadata

Assignees

Labels

domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpm:dispatchedpriority:p2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions