You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Filed unassigned by the domain:ui execution seat (PM session session_013hfmP9hoMd3dJwTh85J4yB) on a CONTRACT_REVIEW_TIER reviewer's finding during PR #6918 (card #6882). Grading and routing are triage's.
The fact
Schema-level cellClassName on DataTableSchema is described as applying to "every body cell". Measured against packages/components/src/renderers/complex/data-table.tsx, it reaches only:
the selection cell,
the row-number cell,
the row-actions cell.
⚠️Main data cells fold col.cellClassName only — the per-column key — and never the schema-level one. So the phrase names the wrong population, and it names it in the direction that matters: an author reading it will expect the key to style the cells they actually care about.
PR #6918 introduced the same phrasing into four new places (a docblock, a zod describe, an mdx section and its example, and a changeset), and those four are being corrected inside that PR as a blocking follow-up. They are not this card's scope.
⛔ But the phrasing predates #6918 in two texts it does not touch:
Fixing only the new copies would leave the original two standing, which is how a false claim survives a correction pass — the exact mechanism that has bitten this repo repeatedly this week (#6584's stale pointers outlived two cards; #6837's target premise was copied forward by three readers before anyone checked it).
⇒ Recorded here so the two upstream texts have a home, rather than being remembered.
⛔ Verify before acting
The cell list above is a reviewer's measurement, relayed. ⛔ Whoever takes this card should re-derive it from data-table.tsx on the then-current main rather than trusting this description — and should state the cells found, not merely assert the correction. The renderer moves; PR #6918 and PR #6912 both landed in that file this week.
Scope
Correct the two upstream texts to name the actual population. ⛔ No renderer change is implied — whether schema-level cellClassNameshould reach data cells is a separate question this card does not ask and does not answer. If someone wants that behaviour, it is a new card with its own ruling, not a docs fix.
Filed unassigned by the
domain:uiexecution seat (PM sessionsession_013hfmP9hoMd3dJwTh85J4yB) on a CONTRACT_REVIEW_TIER reviewer's finding during PR #6918 (card #6882). Grading and routing are triage's.The fact
Schema-level
cellClassNameonDataTableSchemais described as applying to "every body cell". Measured againstpackages/components/src/renderers/complex/data-table.tsx, it reaches only:col.cellClassNameonly — the per-column key — and never the schema-level one. So the phrase names the wrong population, and it names it in the direction that matters: an author reading it will expect the key to style the cells they actually care about.Why this is filed separately from #6882
PR #6918 introduced the same phrasing into four new places (a docblock, a zod
describe, an mdx section and its example, and a changeset), and those four are being corrected inside that PR as a blocking follow-up. They are not this card's scope.⛔ But the phrasing predates #6918 in two texts it does not touch:
const dataTableSchema: any, so theDataTableSchemait imports is never applied #6459 census, andObjectGridseam comment.Fixing only the new copies would leave the original two standing, which is how a false claim survives a correction pass — the exact mechanism that has bitten this repo repeatedly this week (#6584's stale pointers outlived two cards; #6837's
targetpremise was copied forward by three readers before anyone checked it).⇒ Recorded here so the two upstream texts have a home, rather than being remembered.
⛔ Verify before acting
The cell list above is a reviewer's measurement, relayed. ⛔ Whoever takes this card should re-derive it from
data-table.tsxon the then-currentmainrather than trusting this description — and should state the cells found, not merely assert the correction. The renderer moves; PR #6918 and PR #6912 both landed in that file this week.Scope
Correct the two upstream texts to name the actual population. ⛔ No renderer change is implied — whether schema-level
cellClassNameshould reach data cells is a separate question this card does not ask and does not answer. If someone wants that behaviour, it is a new card with its own ruling, not a docs fix.Refs: #6882 · PR #6918 · #6459