You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
finding(gate): the baseline-prose pin generalises to scripts/vite-declared-lazy-views.ts, but only its VALUE half — that file cites five commits with nothing live to check them against #7289
Filed unassigned as an out-of-scope observation returned by #7046's implementation (PR #7286). Recording only — deliberately not fixed there; the dispatch for #7046 fenced scripts/vite-declared-lazy-views.ts explicitly and said to file rather than ride it along. Generated by Claude Code, dev session session_01BGMDbrVa8JjZcCQ7DWYH1b.
PR #7286 adds a structural helper to scripts/__tests__/check-eager-closure-budget.test.ts:
attachedDocs(source, exportName) returns the documentation attached to one exported constant — the JSDoc block ending immediately before the export const NAME declaration, plus every comment lexically inside the declaration, with the code stripped out. It walks the initializer skipping comments and string literals, so it uses no line numbers and no per-file knowledge. On top of it sit three positive pins: every commit a constant carries as data must appear in its own attached prose; every BASELINE's `HASH` claim must name the live BASELINE.commit; every key the constant carries must appear in its per-key provenance list.
None of that is specific to check-eager-closure-budget.mjs.
Why this file is the obvious second customer
#6785 (closed) recorded the same failure mode one file over, and #7046's body makes the argument directly: "Two files, same week, same defect — which is the argument that this wants a mechanism rather than another hand fix."#6785 was repaired by hand, so nothing stops the next paragraph there from going stale.
⚠️ Measured before filing — only half of the mechanism transfers
Read on main at 64d624ded:
scripts/vite-declared-lazy-views.ts carries five 9-hex commit citations in prose (around lines 100, 225, 280, 338 and one inside a runtime message string near line 545).
It exports no constant carrying a commit string as data. The exports in that area are APP_CONTENT_PATH, EAGER_WALK_CONTROL (both path strings) and DECLARED_LAZY_VIEWS_STILL_EAGER (a frozen array of paths).
⇒ The commit half of the pin cannot transfer: there is nothing live to check those five hashes against, which is the same wall #7046 hit on PER_CHUNK_BASELINE and the reason its blanket negative pin was not shipped. Copying the commit pin over would produce a vacuously green test, which is #7046's own defect one layer up.
⇒ The value half transfers directly and non-vacuously: every path in DECLARED_LAZY_VIEWS_STILL_EAGER, and the values of APP_CONTENT_PATH and EAGER_WALK_CONTROL, can be required to appear in their own attached prose. An entry added, removed or re-pathed without touching the paragraph explaining it then reds a unit test instead of drifting — and per #6785 that file's entries carry hand-written counts in prose alongside them.
Suggested shape, if this is picked up
Lift attachedDocs out of scripts/__tests__/check-eager-closure-budget.test.ts into a shared test helper under scripts/__tests__/ rather than copying it — two copies of a structural parser is the drift this whole class is about.
Apply the value pin to the three exports above in scripts/__tests__/vite-declared-lazy-views.test.ts.
Filed unassigned as an out-of-scope observation returned by #7046's implementation (PR #7286). Recording only — deliberately not fixed there; the dispatch for #7046 fenced
scripts/vite-declared-lazy-views.tsexplicitly and said to file rather than ride it along. Generated by Claude Code, dev sessionsession_01BGMDbrVa8JjZcCQ7DWYH1b.What #7046 built
PR #7286 adds a structural helper to
scripts/__tests__/check-eager-closure-budget.test.ts:attachedDocs(source, exportName)returns the documentation attached to one exported constant — the JSDoc block ending immediately before theexport const NAMEdeclaration, plus every comment lexically inside the declaration, with the code stripped out. It walks the initializer skipping comments and string literals, so it uses no line numbers and no per-file knowledge. On top of it sit three positive pins: every commit a constant carries as data must appear in its own attached prose; everyBASELINE's `HASH`claim must name the liveBASELINE.commit; every key the constant carries must appear in its per-key provenance list.None of that is specific to
check-eager-closure-budget.mjs.Why this file is the obvious second customer
#6785 (closed) recorded the same failure mode one file over, and #7046's body makes the argument directly: "Two files, same week, same defect — which is the argument that this wants a mechanism rather than another hand fix."#6785 was repaired by hand, so nothing stops the next paragraph there from going stale.
Read on
mainat64d624ded:scripts/vite-declared-lazy-views.tscarries five 9-hex commit citations in prose (around lines 100, 225, 280, 338 and one inside a runtime message string near line 545).APP_CONTENT_PATH,EAGER_WALK_CONTROL(both path strings) andDECLARED_LAZY_VIEWS_STILL_EAGER(a frozen array of paths).⇒ The commit half of the pin cannot transfer: there is nothing live to check those five hashes against, which is the same wall #7046 hit on
PER_CHUNK_BASELINEand the reason its blanket negative pin was not shipped. Copying the commit pin over would produce a vacuously green test, which is #7046's own defect one layer up.⇒ The value half transfers directly and non-vacuously: every path in
DECLARED_LAZY_VIEWS_STILL_EAGER, and the values ofAPP_CONTENT_PATHandEAGER_WALK_CONTROL, can be required to appear in their own attached prose. An entry added, removed or re-pathed without touching the paragraph explaining it then reds a unit test instead of drifting — and per #6785 that file's entries carry hand-written counts in prose alongside them.Suggested shape, if this is picked up
attachedDocsout ofscripts/__tests__/check-eager-closure-budget.test.tsinto a shared test helper underscripts/__tests__/rather than copying it — two copies of a structural parser is the drift this whole class is about.scripts/__tests__/vite-declared-lazy-views.test.ts.