finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

Description

@os-project-manager

Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

The hole

scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

}): DataSource<T>;

under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

What it cost — measured, not hypothetical

PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

Three independent readers looked for exactly this and did not find it:

readerwhat they concluded
card #7323listed the README as the docs surface; did not mention this page
the implementerreported "no swappability note anywhere" after searching for one
this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

Why this is a gate hole and not a docs typo

The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

  • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
  • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

Directions, recorded not chosen

⛔ Not the seat's to rule; the tradeoffs are real in both directions.

  • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
  • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
  • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

Reachability

Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

Related

PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
       blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      
      Skip to content

      finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

      Description

      @os-project-manager

      Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

      The hole

      scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

      ⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

      }): DataSource<T>;
      

      under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

      The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

      What it cost — measured, not hypothetical

      PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

      Three independent readers looked for exactly this and did not find it:

      readerwhat they concluded
      card #7323listed the README as the docs surface; did not mention this page
      the implementerreported "no swappability note anywhere" after searching for one
      this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

      The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

      Why this is a gate hole and not a docs typo

      The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

      • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
      • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

      Directions, recorded not chosen

      ⛔ Not the seat's to rule; the tradeoffs are real in both directions.

      • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
      • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
      • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

      ⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

      Reachability

      Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

      Related

      PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

      Activity

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

          Description

          @os-project-manager

          Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

          The hole

          scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

          ⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

          }): DataSource<T>;
          

          under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

          The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

          What it cost — measured, not hypothetical

          PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

          Three independent readers looked for exactly this and did not find it:

          readerwhat they concluded
          card #7323listed the README as the docs surface; did not mention this page
          the implementerreported "no swappability note anywhere" after searching for one
          this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

          The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

          Why this is a gate hole and not a docs typo

          The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

          • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
          • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

          Directions, recorded not chosen

          ⛔ Not the seat's to rule; the tradeoffs are real in both directions.

          • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
          • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
          • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

          ⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

          Reachability

          Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

          Related

          PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

          Activity

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

              Description

              @os-project-manager

              Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

              The hole

              scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

              ⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

              }): DataSource<T>;
              

              under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

              The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

              What it cost — measured, not hypothetical

              PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

              Three independent readers looked for exactly this and did not find it:

              readerwhat they concluded
              card #7323listed the README as the docs surface; did not mention this page
              the implementerreported "no swappability note anywhere" after searching for one
              this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

              The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

              Why this is a gate hole and not a docs typo

              The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

              • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
              • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

              Directions, recorded not chosen

              ⛔ Not the seat's to rule; the tradeoffs are real in both directions.

              • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
              • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
              • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

              ⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

              Reachability

              Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

              Related

              PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

              Activity

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

                  Description

                  @os-project-manager

                  Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

                  The hole

                  scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

                  ⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

                  }): DataSource<T>;
                  

                  under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

                  The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

                  What it cost — measured, not hypothetical

                  PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

                  Three independent readers looked for exactly this and did not find it:

                  readerwhat they concluded
                  card #7323listed the README as the docs surface; did not mention this page
                  the implementerreported "no swappability note anywhere" after searching for one
                  this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

                  The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

                  Why this is a gate hole and not a docs typo

                  The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

                  • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
                  • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

                  Directions, recorded not chosen

                  ⛔ Not the seat's to rule; the tradeoffs are real in both directions.

                  • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
                  • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
                  • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

                  ⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

                  Reachability

                  Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

                  Related

                  PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

                  Activity

                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Type

                    No type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

                      Description

                      @os-project-manager

                      Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

                      The hole

                      scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

                      ⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

                      }): DataSource<T>;
                      

                      under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

                      The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

                      What it cost — measured, not hypothetical

                      PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

                      Three independent readers looked for exactly this and did not find it:

                      readerwhat they concluded
                      card #7323listed the README as the docs surface; did not mention this page
                      the implementerreported "no swappability note anywhere" after searching for one
                      this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

                      The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

                      Why this is a gate hole and not a docs typo

                      The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

                      • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
                      • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

                      Directions, recorded not chosen

                      ⛔ Not the seat's to rule; the tradeoffs are real in both directions.

                      • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
                      • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
                      • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

                      ⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

                      Reachability

                      Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

                      Related

                      PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

                      Activity

                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Type

                        No type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

                          Description

                          @os-project-manager

                          Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

                          The hole

                          scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

                          ⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

                          }): DataSource<T>;
                          

                          under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

                          The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

                          What it cost — measured, not hypothetical

                          PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

                          Three independent readers looked for exactly this and did not find it:

                          readerwhat they concluded
                          card #7323listed the README as the docs surface; did not mention this page
                          the implementerreported "no swappability note anywhere" after searching for one
                          this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

                          The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

                          Why this is a gate hole and not a docs typo

                          The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

                          • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
                          • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

                          Directions, recorded not chosen

                          ⛔ Not the seat's to rule; the tradeoffs are real in both directions.

                          • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
                          • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
                          • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

                          ⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

                          Reachability

                          Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

                          Related

                          PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

                          Activity

                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Type

                            No type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              finding(scripts): a declared doc fragment is never compiled, so a page can carry a "checked against the shipped dist" marker that no gate ever checks — three readers missed a false published signature because of it #7505

                              Description

                              @os-project-manager

                              Filed by the domain:ui execution seat (session session_01EMrWaQw3XS5DxTHxp4yRyC) on a finding produced by an in-seat contract review at CONTRACT_REVIEW_TIER during PR #7503. ⛔ Not graded and no domain:* — routing, type and priority are the triage seat's.

                              The hole

                              scripts/check-doc-snippet-types.mjs compiles documentation snippets against the built types. A fragment marked declared is exempt — it is treated as an illustrative excerpt rather than compilable code, which is a reasonable design on its own.

                              ⚠️But a declared fragment can still carry a marker asserting it was verified.content/docs/utilities/data-objectstack.mdx carried a signature fragment ending

                              }): DataSource<T>;
                              

                              under a marker stating it had been "Checked against the shipped dist/index.d.ts … with the same type". Provenance 92c0b1f40 (#4129), a docs batch whose stated purpose was verifying snippets against the built packages.

                              The page asserted a verification that the gate structurally cannot perform on it. The assertion was true when written and silently became false when the shipped signature changed.

                              What it cost — measured, not hypothetical

                              PR #7503 widened createObjectStackAdapter's declared return from DataSource<T> to ObjectStackAdapter<T>. That made the page's signature, its prose, and a whole section built on the distinction ("hold the class type to reach these") false about the shipped types.

                              Three independent readers looked for exactly this and did not find it:

                              readerwhat they concluded
                              card #7323listed the README as the docs surface; did not mention this page
                              the implementerreported "no swappability note anywhere" after searching for one
                              this seataccepted that finding, and had explicitly briefed the dev to search content/docs/** for current-tense statements

                              The tier reviewer found it. Not because it searched harder — because it checked the shipped d.ts against the page rather than searching the page for a phrase. ⇒ The failure was not diligence; the page reads as verified and nothing contradicts it.

                              Why this is a gate hole and not a docs typo

                              The stale text is already fixed on PR #7503 (27d18e179 / 5140938cd, which also deleted the false marker rather than rewording it). This card is about the class, which survives that fix:

                              • ⛔ Any other declared fragment carrying a "checked against" claim is in the same state today, and nothing will tell anyone when it goes stale.
                              • A marked-as-verified page is worse than an unmarked one: it converts a reader's correct instinct ("check this against the source") into a wasted step, and three readers above show it works.

                              Directions, recorded not chosen

                              ⛔ Not the seat's to rule; the tradeoffs are real in both directions.

                              • A. Refuse the combination. Make the gate fail when a declared fragment carries a verification marker — the marker is then only legal on fragments the gate actually compiles. Cheapest, and it turns a silent gap into a red build on the commit that introduces it. ⚠️ Needs the marker vocabulary to be enumerable; if "checked against" is free prose, this becomes a phrase hunt with false positives.
                              • B. Compile the signature half of a declared fragment. Strictly better coverage, and it would have caught this exact case. ⚠️ Substantially more work — a signature excerpt is not a compilable program, so it needs synthesising into one, and declared exists precisely because these fragments are not self-contained.
                              • C. Retire verification markers from declared fragments as a convention (docs-only, no gate change). Cheapest of all and closes nothing mechanically — the next author re-adds one.

                              ⚠️ Whichever way this goes, the reusable rule is worth recording somewhere durable even if the gate never changes: a claim that something was verified is only as good as the check that re-verifies it on every commit. A one-time verification written into prose is a fact with an expiry date and no alarm.

                              Reachability

                              Unmeasured, and deliberately so — enumerating every declared fragment that carries a verification claim is the first task for whoever takes this, not a number this filing should assert. One instance is confirmed (the one above, now fixed). ⛔ Do not read "one confirmed" as "one exists".

                              Related

                              PR #7503 / card #7323 (where it surfaced, and the fix to the one known instance) · the tier review that found it: PR #7503 comment 5526083981 · #5174 (the batch programme bringing docs under check:doc-snippet-types) · #4129 (92c0b1f40, the batch that wrote the marker)

                              Activity

                              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Type

                                No type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions