Uh oh!
There was an error while loading. Please reload this page.
[WIP] Enhance UI components for forms and layouts - #12
Merged
Conversation
Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
huangyiirene
marked this pull request as ready for review
January 13, 2026 18:44
Copilot stopped work on behalf of huangyiirene due to an error
January 13, 2026 18:44
This was referenced Feb 16, 2026
9 tasks
This was referenced Jul 28, 2026
akarma-synetal pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Aug 3, 2026
…ce (objectstack-ai#3232) (objectstack-ai#3244) The widget resolved its fullscreen affordance through a four-way `??` chain: a `mobileFullscreen` (camelCase) prop, `field.mobile_fullscreen`, a `mobile_fullscreen` prop, and `schema.mobile_fullscreen`. Three of the four were permanently `undefined`: - `mobileFullscreen` had no producer anywhere in the repo — the only two occurrences of that spelling were this widget's own read and the destructure that kept it off the DOM spread. The doc comment claimed "the host form passes `mobileFullscreen`", so it documented a contract that never held. - `mobile_fullscreen` as a prop cannot arrive: `stripRegisteredFieldProps` (components/src/renderers/form/form.tsx) removes it, and `fullscreen`, from the props forwarded to registered field widgets. - `schema.mobile_fullscreen` restates the object `field || schema` already resolves into `textareaField`. What is left is the one live source: the field metadata flag ObjectForm stamps onto long-text fields from `ObjectFormSchema.mobile.fullscreenLongText`. The doc comment now describes that, names the producer, and records why there is deliberately no host-override prop. No behaviour change. The metadata path is pinned by new tests covering the button, the dialog and the committed edit, so the cleanup cannot have removed the working affordance; the retired spellings are pinned inert at compile time (they are not on the closed `FieldWidgetComponentProps`, objectstack-ai#3221) and at runtime. The built-in (unregistered) `textarea` branch of the form renderer, which reads `mobile_fullscreen || fullscreen` off the form-field props and renders its own `FullscreenTextarea`, is a separate live path and is untouched. Per AGENTS.md #0.1 and Prime Directive objectstack-ai#12: divergence converges at the producer, not by accumulating tolerance at the consumer. Fixesobjectstack-ai#3232 Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Aug 3, 2026
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Complete Component Library
Based on the problem statement, I need to implement/enhance the following components:
Forms Components
Data Components
Layout Components
Feedback Components
Implementation Complete
✅ All components have been implemented
✅ Added date-fns dependency for date formatting
✅ Updated index files to export new components
✅ Build successful
✅ Tests added and passing (9/9 tests)
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.