Uh oh!
There was an error while loading. Please reload this page.
feat(charts): treemap & sankey via Recharts + field-type coverage guard - #1438
Merged
xuyushun441-sys merged 1 commit intoJun 1, 2026
Merged
Conversation
…uard - plugin-charts/AdvancedChartImpl: add treemap (palette-colored leaves) and sankey (single-root flow weighted by value) branches using Recharts' Treemap/Sankey — no new charting dependency. - plugin-dashboard: move treemap/sankey into SUPPORTED_CHART_TYPES; the remaining geo / OHLC / distribution families stay as clean placeholders. - fields: add field-type-coverage.test — a regression guard asserting every specialized field type resolves to a dedicated form widget and cell renderer (never the text fallback), so the registry can't silently regress again. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two things:
treemap & sankey via Recharts (no new charting dependency — these were going to need ECharts, but Recharts 3.8 ships
Treemap/Sankey):AdvancedChartImpl: treemap (palette-colored leaves + labels) and sankey (single-root flow weighted by value) branches.DashboardRenderer: movetreemap/sankeyintoSUPPORTED_CHART_TYPES. Remaining geo / OHLC / distribution families (heatmap, sunburst, candlestick, box-plot, geo maps, word-cloud, …) stay as clean placeholders.Regression guard (
fields/field-type-coverage.test.ts): asserts every specialized field type resolves to a dedicated form widget (never thefield:textfallback) and a dedicated cell renderer (neverTextCellRenderer). This locks in the field-renderer fixes so the registry can't silently regress again. 87 cases.Verification
vitest run field-type-coverage.test.ts→ 87 passed.🤖 Generated with Claude Code