Skip to content

fix(react): repoint useClientNotifications to ADR-0030 client surface - #1440

Merged
xuyushun441-sys merged 1 commit into
mainfrom
feat/adr-30-inbox-notification-bell
Jun 1, 2026
Merged

fix(react): repoint useClientNotifications to ADR-0030 client surface#1440
xuyushun441-sys merged 1 commit into
mainfrom
feat/adr-30-inbox-notification-bell

Conversation

@xuyushun441-sys

Copy link
Copy Markdown
Contributor

What & why

Cross-repo cut-over for framework ADR-0030 — Notification Convergence. The objectui-side bell repoint (sys_notificationsys_inbox_message + sys_notification_receipt) and the receipt-upsert mark-read path already landed in #1429. This PR closes the remaining objectui item: the SDK consumer.

useClientNotifications (the only objectui surface that touches client.notifications.*) called the SDK with signatures that no longer exist on @objectstack/client@7.x, so it would throw at runtime:

  • registerDevice(token, platform) → SDK takes a single RegisterDeviceRequest object → now registerDevice({ token, platform }).
  • markAsRead(id) → no single-id method; SDK is markRead(ids: string[]) → now markRead([id]) (kept the friendly single-id hook API).

These helpers are the stable transport contract; server-side ADR-0030 routes them to the L5 sys_inbox_message materialization and the sys_notification_receipt read-state spine.

Cut-over runbook (in the changeset)

objectui is frontend-only and cannot run the server-side data migration. The new changeset records the operational order so whoever deploys runs it:

  1. Deploy framework ADR-0030 (objects + emit() + producers).
  2. Run migrateSysNotificationToEvent({ driver, data }) once (from @objectstack/metadata/migrations; idempotent, not_applicable on fresh installs) — server/data-engine step, not a Console step.
  3. Deploy the objectui repoint (this PR + the feat(app-shell): repoint Console bell to sys_inbox_message + receipts (ADR-0030) #1429 bell cut-over).

Verification

  • tsc --noEmit + eslint clean on the changed package (remaining lint warnings are pre-existing in untouched lines).
  • Browser end-to-end against a live ADR-0030 backend (showcase Console): seeded a sys_inbox_message + a deliveredsys_notification_receipt for a test user →
    • bell badge showed 1, popover rendered the row;
    • Mark all read flipped the existing receipt delivered → read in place (same row id, no duplicate) and cleared the badge to 0.

🤖 Generated with Claude Code

The `useClientNotifications` bridge hook called `client.notifications.*`
with signatures that no longer exist on `@objectstack/client@7.x`:
- `registerDevice(token, platform)` → SDK takes a single
`RegisterDeviceRequest` object (`{ token, platform }`).
- `markAsRead(id)` → no single-id method; SDK is `markRead(ids[])`.
The hook keeps its single-id public API and adapts to the batch call.
These helpers are the stable transport contract for ADR-0030 (Notification
Convergence): server-side they route to the L5 `sys_inbox_message`
materialization and the `sys_notification_receipt` read-state spine. The
changeset also records the cut-over runbook (deploy framework → run the
idempotent `migrateSysNotificationToEvent` once → deploy the objectui repoint).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 1, 2026 6:23pm

Request Review

@xuyushun441-sys
xuyushun441-sys merged commit abe8ebc into mainJun 1, 2026
10 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)265.7 KB350 KB
Entry fileindex-CiY4zPLP.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.56KB1.95KB
app-shell (runtime-config.js)4.21KB1.52KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)22.29KB5.30KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)393.42KB83.11KB
core (index.js)1.45KB0.54KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)89.39KB22.17KB
fields (index.js)137.99KB32.56KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.27KB0.91KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)18.42KB4.30KB
i18n (useSafeTranslation.js)1.63KB0.57KB
layout (index.js)36.05KB9.94KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.97KB12.64KB
plugin-charts (index.js)39.09KB11.07KB
plugin-chatbot (index.js)108.70KB26.74KB
plugin-dashboard (index.js)87.61KB20.96KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)191.60KB46.09KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)64.00KB14.83KB
plugin-gantt (index.js)28.28KB7.76KB
plugin-grid (index.js)108.86KB29.30KB
plugin-kanban (index.js)48.80KB13.12KB
plugin-list (index.js)87.85KB20.66KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)2.62KB1.18KB
plugin-report (index.js)129.03KB28.39KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)140.77KB28.99KB
plugin-workflow (index.js)69.35KB14.42KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)14.98KB4.84KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)4.80KB1.76KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB
types (workflow.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@xuyushun441-sys@os-zhuang