Skip to content

fix(app-shell): gate the runtime report/dashboard editors behind admin - #1508

Merged
os-zhuang merged 1 commit into
mainfrom
claude/gate-runtime-editors-admin
Jun 6, 2026
Merged

fix(app-shell): gate the runtime report/dashboard editors behind admin#1508
os-zhuang merged 1 commit into
mainfrom
claude/gate-runtime-editors-admin

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

背景

ADR-0034 调研中核实到一个独立的真实缺陷:运行时报表/仪表盘的编辑按钮无任何权限门控——而它们写的是共享记录(sys_report/sys_dashboard 单条),所以任何普通用户点"编辑"保存,就改了所有人的报表/仪表盘。视图编辑早已是 isAdmin 门控,这两处却没有。

改动

给 ReportView 与 DashboardView 的编辑入口补上管理员门控(对齐 ObjectView):

  • useAuth().user?.role === 'admin' 计算 isAdmin。
  • 编辑按钮仅管理员可见({isAdmin && <button .../>})。
  • 配置面板 open 加 && isAdmin 防御。

这是 ADR-0034 v1 的第一步(运行时编辑 = 管理员对共享定义的快速编辑),小、安全、独立可上线,不依赖后端。

验证

  • pnpm turbo run build --filter=@object-ui/app-shell:27/27 通过。
  • app-shell/src/views 测试:179 全过。
  • lint 改动文件 0 error。

https://claude.ai/code/session_01SZW3fVCCbijEibXtEH3ZGL

Generated by Claude Code

@claude
fix(app-shell): gate the runtime report/dashboard editors behind admin
2abf14a
Editing a report or dashboard mutates the SHARED definition (single
sys_report/sys_dashboard record), but the edit buttons were shown to every
user — any viewer could mutate a shared report/dashboard. Gate the edit
button and its config panel behind isAdmin, matching ObjectView's existing
view-config gate. First step of ADR-0034 (runtime edits = admin quick-edit
of the shared definition).
@vercel

vercelBot commented Jun 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 6, 2026 8:18am

Request Review

@github-actions

github-actionsBot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)264.9 KB350 KB
Entry fileindex-DLqmQpcR.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.77KB2.03KB
app-shell (runtime-config.js)4.29KB1.54KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)22.29KB5.30KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)397.93KB84.13KB
core (index.js)1.45KB0.54KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)91.35KB22.63KB
fields (index.js)144.92KB34.19KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.27KB0.91KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)18.42KB4.30KB
i18n (useSafeTranslation.js)1.63KB0.57KB
layout (index.js)36.05KB9.94KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)39.09KB11.07KB
plugin-chatbot (index.js)115.56KB28.13KB
plugin-dashboard (index.js)87.61KB20.96KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)192.46KB46.34KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)73.65KB17.12KB
plugin-gantt (index.js)28.30KB7.76KB
plugin-grid (index.js)110.04KB29.58KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)89.76KB21.04KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)2.62KB1.18KB
plugin-report (index.js)129.03KB28.39KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)81.50KB19.86KB
plugin-workflow (index.js)69.35KB14.42KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)14.98KB4.84KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)4.80KB1.76KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB
types (workflow.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review June 6, 2026 08:23
@os-zhuang
os-zhuang merged commit e133fae into mainJun 6, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the claude/gate-runtime-editors-admin branch June 6, 2026 08:23
This was referenced Jun 6, 2026
Closed
Closed
@os-zhuangos-zhuang mentioned this pull request Aug 21, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude