Uh oh!
There was an error while loading. Please reload this page.
feat(view): forward form-view subforms to ObjectForm - #1528
Merged
Conversation
ObjectView.buildFormSchema now passes schema.form.subforms through, so a form view declaring inline child collections renders as a master-detail form in ObjectView's create/edit form (no bespoke page). Pairs with spec FormViewSchema.subforms + ObjectForm's subforms rendering. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectView.buildFormSchemanow forwardsform.subformstoObjectForm. A form view that declares inline child collections renders as a master-detail form (parent fields + child grids, atomic save) in ObjectView's own create/edit form — no bespoke page.Pairs with
@objectstack/specFormViewSchema.subformsand ObjectForm's existingsubformsrendering (#1527).Scope note (honest): this covers the ObjectView-rendered form path. The console's standard "New/Edit" modal is built separately (app-shell
AppContent→ModalForm, which renders its body viaSchemaRendererand does not go through the ObjectForm dispatcher). Making that path render subforms needsModalForm/DrawerFormto hostMasterDetailForminside the dialog +AppContentto sourcesubformsfrom the object's form view — tracked as a follow-up (it carries a UX decision: master-detail inside a modal vs a full page).🤖 Generated with Claude Code