Uh oh!
There was an error while loading. Please reload this page.
feat(dashboard): render dataset widgets as their true chart type - #1624
Merged
Conversation
A dataset-bound widget always rendered a bar chart — a "Status Flow (Sankey)" or "Hours Treemap" widget drew bars, contradicting its title. DatasetWidget now dispatches on widget.type: - metric/kpi/gauge/solid-gauge/bullet (or no dimensions) → KPI value (label + format) - table/pivot → grouped table of dimensions + measures (measure format applied) - bar/column/horizontal-bar/line/area/pie/donut/funnel/scatter/radar/treemap/ sankey → the shared advanced `chart` renderer with the TRUE chart type and one series per measure (series carry the measure display label for the legend) - families with no distinct renderer map to their closest relative, never a silently-wrong bar. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A dataset-bound dashboard widget always rendered a bar chart —
DatasetWidgethardcodedtype: 'bar-chart'. So a "Status Flow (Sankey)", "Hours Treemap", "Priority Radar", or pie/donut widget all drew bars, contradicting their titles. (From the Chart Gallery review.)Fix
DatasetWidgetnow dispatches onwidget.type:dimensions+values(measureformatapplied).chartrenderer with the true chart type and one series per measure (series carry the measure display label for the legend).spline→line,stacked-area→area,pyramid→funnel, grouped/stacked/bi-polar→bar) — never a silently-wrong bar.Verification
plugin-dashboard suite green (3564 passing). Will browser-verify on the showcase Chart Gallery after the framework
.objectui-shabump.🤖 Generated with Claude Code