Skip to content

feat(console): business-first Approvals Inbox revamp - #1643

Merged
os-zhuang merged 1 commit into
mainfrom
feat-approvals-inbox-revamp
Jun 11, 2026
Merged

feat(console): business-first Approvals Inbox revamp#1643
os-zhuang merged 1 commit into
mainfrom
feat-approvals-inbox-revamp

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Companion to objectstack-ai/objectstack#1728. Rebuilds the Approvals Inbox from a developer debug view into a business workbench. Full e2e review + redesign rationale: tested against the showcase app (approve / reject / recall / multi-step chain / bulk / keyboard / mobile all verified in-browser).

P0 fixes

  • Role-addressed approvals never reached "My Pending": buildApproverIdentities only read a roles array, but better-auth sessions carry a single role string (possibly comma-separated). Both shapes resolve now.
  • Pending resolves every identity in ONE comma-separated approverId request (the server already supported it).
  • The tab badge is a dedicated my-pending count — it previously counted the active tab's rows, so it showed the global pending count while browsing "All".
  • Disabled Approve/Reject now always explain why (the explanation used to vanish whenever Recall was available); bulk approve gets a confirmation dialog; API errors toast as business language instead of HTTP_404: Not found.

P1 — information architecture

  • Rows lead with flow display label + record-title link + requester name (server-enriched), semantic status colors, relative times with aging tints.
  • Drawer: business summary card (record link, requester, formatted key payload fields), action timeline, raw JSON collapsed by default, actor override admin-only.
  • Search covers record titles / requester names / process labels ("Compliance Audit" went 0 → 3 hits); status filter added on non-pending tabs.
  • Full i18n: approvalsInbox.* keys in all ten locales (locale-parity test green).

P2 — efficiency

  • Hover quick approve/reject per row (reject confirms), j/k/Enter/x/a/r keyboard flow with a hint line, card layout on mobile (the table used to truncate to 2 columns at 375px).

Test plan

  • @object-ui/i18n: 100/100 (incl. locale-parity) ✅
  • console suite: 3598 passed / 24 skipped ✅
  • tsc --noEmit clean on console + i18n ✅
  • In-browser e2e against showcase (3700/5790): my-pending badge math, drawer approve with comment, inline reject confirm, recall confirm → recalled + timeline entry, bulk approve confirm → 2 approved, keyboard a/r, mobile cards, zero console errors ✅

🤖 Generated with Claude Code

@os-zhuang@claude
feat(console): business-first Approvals Inbox revamp
bb7b4ab
Rebuilds the approvals inbox from a developer debug view into a
business workbench, consuming the enriched row contract from
objectstack-ai/objectstack#1728:
- Rows lead with the flow's display label + record title link and the
requester's name instead of flow:manager_review / opaque ids; status
badges use semantic colors (emerald/amber/red/slate) and waiting
times get aging tints (amber >1d, red >3d).
- Drawer: business summary card (record link, requester, formatted key
payload fields), action timeline, raw JSON collapsed; actor override
is admin-only; disabled Approve/Reject always explain why; Recall is
wired to the new endpoint behind a confirmation.
- My Pending matching now sees better-auth's single `role` string
(incl. comma-separated lists) — role-addressed approvals previously
never reached the tab; pending resolves all identities in ONE
comma-separated request; the tab badge is a dedicated my-pending
count instead of drifting with the active tab's rows.
- Bulk approve gains a confirmation dialog (reject already had one)
and failures report which records failed, not just a count.
- Search covers record titles / requester names / process labels; new
status filter on the non-pending tabs.
- Quick actions on row hover, j/k/Enter/x/a/r keyboard flow, card
layout on mobile, humanized error toasts, and full i18n across all
ten locales (approvalsInbox.* keys).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@os-zhuang
os-zhuang merged commit 7c1d937 into mainJun 11, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the feat-approvals-inbox-revamp branch June 11, 2026 13:34
@vercel

vercelBot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 11, 2026 1:35pm

Request Review

@github-actions

github-actionsBot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)275.1 KB350 KB
Entry fileindex-CDKvarRZ.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.77KB2.03KB
app-shell (runtime-config.js)4.40KB1.57KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)22.29KB5.30KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)399.21KB84.50KB
core (index.js)1.45KB0.54KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)96.04KB23.89KB
fields (index.js)157.36KB37.46KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.27KB0.91KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)19.40KB4.48KB
i18n (useSafeTranslation.js)1.63KB0.57KB
layout (index.js)36.05KB9.94KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)39.79KB11.29KB
plugin-chatbot (index.js)130.09KB31.84KB
plugin-dashboard (index.js)93.20KB22.36KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)192.76KB46.42KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)89.69KB21.45KB
plugin-gantt (index.js)28.30KB7.76KB
plugin-grid (index.js)110.17KB29.64KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)90.23KB21.20KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)2.62KB1.18KB
plugin-report (index.js)134.39KB29.49KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)81.53KB19.87KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)14.98KB4.84KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

apps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang