Uh oh!
There was an error while loading. Please reload this page.
feat(report): dataset-native report editor + retire the legacy report surface (ADR-0021) - #1645
Merged
Merged
Conversation
… surface (ADR-0021) A 9.0 report is dataset-bound — it binds a semantic-layer dataset and selects its values (measures) grouped by rows (dimensions). This lands the editing surface for that shape and retires the query-form surface the 9.0 cutover left unreachable: app-shell (editor): - ReportDefaultInspector: curated dataset binding — dataset picker + values/rows lists fed by the bound dataset's measures/dimensions (new useDatasetCatalog/useDatasetSemantics, override-friendly) - report-schema: getReportForm() aligns the bundled spec form to the 9.0 schema (prunes query-form leftovers the schema strips; surfaces runtimeFilter) — a no-op once the bundled reportForm catches up - ReportPreview: non-dataset drafts get an actionable "bind a dataset" empty state; ReportColumnInspector unregistered and removed - ReportConfigPanel hosts the same inspector unchanged (runtime = studio) plugin-report (renderer): - retired: SpecReportGrid, MatrixRenderer, JoinedReportRenderer, drill helpers, ReportBuilder, ReportConfigPanel, ColumnsEditor, GroupingsBuilder, JoinedBlocksEditor, FieldPickerDialog, ChartConfig, specFilterAdapter, ScheduleConfig, buildChartData (only reachable from the removed query form) - ReportRenderer dispatch: dataset-bound → DatasetReportRenderer; stored pre-9.0 spec JSON → specReportToPresentation → ReportViewer (lossy bridge, finally exercised); presentation schemas → LegacyReportRenderer - ReportView passes its fetched rows so the bridge renders data Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the ADR-0021 single-form migration for the report surface. A 9.0 report is dataset-bound — it binds a semantic-layer
datasetand selects itsvalues(measures) grouped byrows(dimensions). This PR lands the dataset-native editing surface and retires the pre-9.0 query-form surface the cutover left unreachable.Upstream prerequisite already merged: framework#1730 aligned the spec's
reportFormwith the 9.0 schema. Until that ships in a bundled spec release,getReportForm()here applies the same alignment locally (schema-subset pruning +runtimeFiltersurfacing) — it degrades to a no-op once the bundle catches up.app-shell — dataset-native editor (Studio + runtime share it)
useDatasetCatalog/useDatasetSemantics, override-friendly and network-free for hosts/tests). TheobjectName+columnslayer is gone.getReportForm()prunes form fields the 9.0 schema strips at parse time (objectName/columns/groupingsDown/groupingsAcross/filter) and surfacesruntimeFilter.ReportColumnInspectorremoved + unregistered.plugin-report — legacy surface retired (major)
SpecReportGrid,MatrixRenderer,JoinedReportRenderer, drill helpers,ReportBuilder,ReportConfigPanel,ColumnsEditor,GroupingsBuilder,JoinedBlocksEditor,FieldPickerDialog,ChartConfig,specFilterAdapter,ScheduleConfig,buildChartData— all only reachable from the removed query form.ReportRendererdispatch: dataset-bound →DatasetReportRenderer; stored pre-9.0 spec JSON →specReportToPresentation→ReportViewer(the bridge finally has a consumer); presentation schemas →LegacyReportRenderer.ReportViewpasses its fetched rows so the pre-9.0 bridge renders data.useReportDatastays exported (itsmergeFiltersis shared by the dataset renderer; the hook itself is documented as migration-window API).Changeset: major on
@object-ui/plugin-report, minor on@object-ui/app-shell.Test plan
pnpm vitest run— 3548 passed, 24 skipped, 0 failedpnpm build— 41/41;pnpm type-check— 58/58pnpm --filter @object-ui/console exec vite build(CI's E2E build step)🤖 Generated with Claude Code