Skip to content

feat(report): dataset-native report editor + retire the legacy report surface (ADR-0021) - #1645

Merged
os-zhuang merged 1 commit into
mainfrom
feat-dataset-native-report-editor
Jun 11, 2026
Merged

feat(report): dataset-native report editor + retire the legacy report surface (ADR-0021)#1645
os-zhuang merged 1 commit into
mainfrom
feat-dataset-native-report-editor

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Summary

Completes the ADR-0021 single-form migration for the report surface. A 9.0 report is dataset-bound — it binds a semantic-layer dataset and selects its values (measures) grouped by rows (dimensions). This PR lands the dataset-native editing surface and retires the pre-9.0 query-form surface the cutover left unreachable.

Upstream prerequisite already merged: framework#1730 aligned the spec's reportForm with the 9.0 schema. Until that ships in a bundled spec release, getReportForm() here applies the same alignment locally (schema-subset pruning + runtimeFilter surfacing) — it degrades to a no-op once the bundle catches up.

app-shell — dataset-native editor (Studio + runtime share it)

  • ReportDefaultInspector: curated dataset binding — dataset picker plus values/rows reorderable lists fed by the bound dataset's measures/dimensions (new useDatasetCatalog / useDatasetSemantics, override-friendly and network-free for hosts/tests). The objectName+columns layer is gone.
  • report-schema: getReportForm() prunes form fields the 9.0 schema strips at parse time (objectName/columns/groupingsDown/groupingsAcross/filter) and surfaces runtimeFilter.
  • ReportPreview: non-dataset drafts get an actionable "bind a dataset" empty state instead of the retired legacy renderer; ReportColumnInspector removed + unregistered.

plugin-report — legacy surface retired (major)

  • Removed: SpecReportGrid, MatrixRenderer, JoinedReportRenderer, drill helpers, ReportBuilder, ReportConfigPanel, ColumnsEditor, GroupingsBuilder, JoinedBlocksEditor, FieldPickerDialog, ChartConfig, specFilterAdapter, ScheduleConfig, buildChartData — all only reachable from the removed query form.
  • ReportRenderer dispatch: dataset-bound → DatasetReportRenderer; stored pre-9.0 spec JSON → specReportToPresentationReportViewer (the bridge finally has a consumer); presentation schemas → LegacyReportRenderer.
  • ReportView passes its fetched rows so the pre-9.0 bridge renders data.
  • useReportData stays exported (its mergeFilters is shared by the dataset renderer; the hook itself is documented as migration-window API).

Changeset: major on @object-ui/plugin-report, minor on @object-ui/app-shell.

Test plan

  • pnpm vitest run — 3548 passed, 24 skipped, 0 failed
  • pnpm build — 41/41; pnpm type-check — 58/58
  • pnpm --filter @object-ui/console exec vite build (CI's E2E build step)
  • Touched files lint with 0 errors

🤖 Generated with Claude Code

… surface (ADR-0021)
A 9.0 report is dataset-bound — it binds a semantic-layer dataset and
selects its values (measures) grouped by rows (dimensions). This lands the
editing surface for that shape and retires the query-form surface the 9.0
cutover left unreachable:
app-shell (editor):
- ReportDefaultInspector: curated dataset binding — dataset picker +
values/rows lists fed by the bound dataset's measures/dimensions
(new useDatasetCatalog/useDatasetSemantics, override-friendly)
- report-schema: getReportForm() aligns the bundled spec form to the 9.0
schema (prunes query-form leftovers the schema strips; surfaces
runtimeFilter) — a no-op once the bundled reportForm catches up
- ReportPreview: non-dataset drafts get an actionable "bind a dataset"
empty state; ReportColumnInspector unregistered and removed
- ReportConfigPanel hosts the same inspector unchanged (runtime = studio)
plugin-report (renderer):
- retired: SpecReportGrid, MatrixRenderer, JoinedReportRenderer, drill
helpers, ReportBuilder, ReportConfigPanel, ColumnsEditor,
GroupingsBuilder, JoinedBlocksEditor, FieldPickerDialog, ChartConfig,
specFilterAdapter, ScheduleConfig, buildChartData (only reachable from
the removed query form)
- ReportRenderer dispatch: dataset-bound → DatasetReportRenderer; stored
pre-9.0 spec JSON → specReportToPresentation → ReportViewer (lossy
bridge, finally exercised); presentation schemas → LegacyReportRenderer
- ReportView passes its fetched rows so the bridge renders data
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 11, 2026 2:16pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)275.1 KB350 KB
Entry fileindex-CO3_5DFA.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.77KB2.03KB
app-shell (runtime-config.js)4.40KB1.57KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)22.29KB5.30KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)399.21KB84.50KB
core (index.js)1.45KB0.54KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)96.04KB23.89KB
fields (index.js)157.36KB37.46KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.27KB0.91KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)19.40KB4.48KB
i18n (useSafeTranslation.js)1.63KB0.57KB
layout (index.js)36.05KB9.94KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)39.79KB11.29KB
plugin-chatbot (index.js)130.09KB31.84KB
plugin-dashboard (index.js)93.20KB22.36KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)192.76KB46.42KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)89.69KB21.45KB
plugin-gantt (index.js)28.30KB7.76KB
plugin-grid (index.js)110.17KB29.64KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)90.23KB21.20KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)2.62KB1.18KB
plugin-report (index.js)39.71KB10.72KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)81.53KB19.87KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)14.98KB4.84KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit e089cfe into mainJun 11, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the feat-dataset-native-report-editor branch June 11, 2026 14:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang