Uh oh!
There was an error while loading. Please reload this page.
feat(plugin-chatbot): drive build liveness off the server keep-alive seq - #1702
Merged
Conversation
…e seq The build panel's liveness keys off a content signature (phase:done:items). During a seeding level the server now sends keep-alive heartbeats — but those are content-identical (the reconciled data-build-progress part has a stable id), so the content key wouldn't change and the panel would still flip to amber mid-build despite real bytes arriving. Read the server's monotonic `seq` (added in cloud #287) through extractBuildProgress into ChatBuildProgress, and prefer it as the build panel's activity key, falling back to the content signature when absent (older runtimes). `seq` advances on every emit including heartbeats, so a long quiet seed-generation window now reads as honestly "receiving" — driven by real server bytes, not a clock. Test: 72 pass. New one re-renders the panel with a bumped seq + identical content across a 9s span and asserts it never goes amber (vs the existing test where an unchanged snapshot correctly goes amber after 6s). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The build panel's liveness (from #1700) keys off a content signature (
phase:done:items). The server now sends keep-alive heartbeats during long, quiet seed-generation windows (cloud #287) — but those re-emits are content-identical (the reconcileddata-build-progresspart has a stable id), so the content key wouldn't change and the panel would still flip to amber mid-build despite real bytes arriving.What
Read the server's monotonic
seqthroughextractBuildProgressintoChatBuildProgress, and prefer it as the build panel's activity key — falling back to the content signature when it's absent (older runtimes).seqadvances on every emit including heartbeats, so a long quiet seed-generation window now reads as honestly "receiving" — driven by real server bytes, not a clock.Verification
seq+ identical content across a 9s span and asserts it never goes amber — directly contrasting the existing test where an unchanged snapshot correctly goes amber after 6s.tsc+vite buildclean; new code lint-clean.Pairs with cloud #287. Completes the honest-liveness arc: #1700 stopped the client from lying; #287 + this let the genuinely-busy quiet build windows read green truthfully.
🤖 Generated with Claude Code