Uh oh!
There was an error while loading. Please reload this page.
feat(app-shell): ADR-0047 — usable interface-page config panel - #1704
Merged
Conversation
Three protocol-driven fixes so the interface/list page inspector is usable (Airtable-parity), keeping the panel schema-driven: • SchemaForm: honour FormSectionSpec.collapsible/collapsed — render collapsible sections in a Collapsible with a chevron (defaultOpen = !collapsed). The spec already declares these flags; the renderer ignored them, so everything rendered flat/expanded. • Widget: array-of-enum → a real multi-select (MultiSelectWidget) of toggleable chips instead of the free-text tag fallback. Drives appearance.allowedVisualizations (pick, don't type). • InterfaceListPage: derive a default viz binding from the object when a viz is whitelisted but unbound (kanban groupField from the first select/status field, calendar from a date field, gallery from an image field) — like defaultColumnsFromObject. Fixes 'added kanban but the switcher only shows Grid': ListView only offers a viz when its binding resolves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…sections, default viz bindings • MultiSelectWidget: chips from enum, ordered toggle, clear→undefined, readOnly • SchemaForm: collapsed section hides body until expanded; collapsed:false opens; object/CEL visibleOn hides a section when false • InterfaceListPage default viz bindings (exported): kanban groupField from first select/status field, calendar date field, gallery cover; skips hidden/system fields Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The interface/list-page config panel (e.g.
showcase_task_workbench) was unusable: it dumped the whole generic page form (page type/template, data-context, region designer — none of which apply),Allowed Visualizationswas a free-text box, and selecting kanban did nothing (the live switcher only ever showed Grid).Per the product direction, the panel stays protocol/schema-driven — these are renderer + widget fixes plus a backend form reorg (see companion framework PR), not a bespoke inspector.
Changes
FormSectionSpec.collapsible/collapsedwere already declared by the spec but ignored by the renderer; now collapsible sections render in aCollapsiblewith a chevron (defaultOpen = !collapsed). Section-levelvisibleOn(CEL/object form) already filtered — confirmed by test.array<enum>.inferWidgetnow maps an enum-item array to a newmultiselectwidget (toggleable chips fromitems.enum) instead of the free-text tag fallback. Drivesappearance.allowedVisualizations— pick, don't type.defaultColumnsFromObject. Fixes "added kanban but the switcher only shows Grid":ListView.availableViewsonly offers a viz when its binding resolves.Tests
15 new component/unit tests (all green):
MultiSelectWidget.test.tsx,SchemaForm.collapsible.test.tsx(incl. sectionvisibleOnhiding),InterfaceListPage.defaults.test.tsx.Verification notes
Logic locked by the tests above; the served form reorg was API-verified against a local backend, and the renderer changes were confirmed active in the browser (collapsible section triggers render). Full live click-through was constrained by local dev-env instability (flapping backends + a cross-origin dev-auth cookie quirk) — the behaviour is covered deterministically by the tests.
Companion: framework PR reorganises
page.form.ts(hide region/data-context for list pages, prominent Interface section).🤖 Generated with Claude Code