fix(build): deterministic flat plugin .d.ts to stop flaky app-shell build (#1760) by os-zhuang · Pull Request #1766 · objectstack-ai/objectui

os-zhuang · 2026-06-15T16:07:35Z

Problem

Closes#1760. Under a full parallel turbo run build, @object-ui/app-shell's composite tsc intermittently failed with error TS2307: Cannot find module '@object-ui/plugin-*', flipping the Bundle Analysis / Build job red or flaky. Long-masked by the turbo cache, so any PR touching an app-shell dependency could trip it — eroding CI trust.

Root cause

Every dts-emitting package configured vite-plugin-dts with compilerOptions.rootDir at the monorepo root plus @object-ui/*resolve.alias entries pointing into sibling src. Consequences:

Deeply nested dist — dist/packages/<pkg>/src/*.d.ts, with dist/index.d.ts re-exporting the deep ./packages/<pkg>/src/index.js path.
Cross-package type imports rewritten to relative sibling-src paths (e.g. ../../types/src). Under the nested layout these pointed nowhere valid → consumers silently degraded those types to any (masking real type errors); flattened naively they resolve to raw src → consumers re-walk/recompile cross-package source.

Generating this nested, cross-src-walking .d.ts for ~15 plugins concurrently is unstable, so app-shell's composite tsc intermittently couldn't resolve a plugin's .d.ts. Building app-shell in isolation always succeeded — consistent with a concurrency race.

Fix

Applied consistently to all dts-emitting packages (vite.config.ts):

compilerOptions.rootDir → each package's own src ⇒ flat emit (dist/index.d.ts + dist/*.d.ts, no nested packages/<pkg>/src tree).
aliasesExclude: [/^@object-ui\//] ⇒ cross-package type imports stay bare (@object-ui/types) and resolve to each dependency's own built dist/*.d.ts, instead of being rewritten to relative sibling-src paths.

Plus packages/app-shell/src/views/ReportView.tsx: annotate viewerSchema as ReportViewerSchema — a real type error that was previously masked because the broken relative-path resolution degraded ReportViewer's prop type to any.

JS bundles are byte-identical — rollup already externalizes bare imports via rollupOptions.external; the aliases only fed the bundler/tests, not the published JS.

Verification

This is a flaky build-system fix, so it needs repeated proof:

Repro (before): clean turbo cache + full pnpm build reproduced app-shell failing with Cannot find module '@object-ui/plugin-report'.
After: the exact Bundle Analysis command pnpm turbo run build --filter='./packages/*' is green across 5 clean runs (turbo cache + *.tsbuildinfo + dist cleared each pass): 37/37 tasks, cannot-find=0, TSerr=0.
Spot-checked emitted .d.ts: flat layout, zero relative ../../*/src refs, all cross-package imports bare @object-ui/*. app-shell (a downstream consumer) type-checks against the plugin .d.ts and builds green.

Not declaring success on a single green — confirmed stability across repeated clean builds. Will wait for CI to be green and stable before merge.

🤖 Generated with Claude Code

…pecifiers (#1760) vite-plugin-dts was configured with compilerOptions.rootDir at the monorepo root plus @object-ui/* aliases pointing into sibling src. This produced a deeply nested dist layout (dist/packages/<pkg>/src/*.d.ts) and rewrote cross-package type imports to relative paths into sibling src (e.g. ../../types/src). Under a full parallel `turbo run build` this was non-deterministic: app-shell's composite tsc intermittently failed to resolve some plugin's .d.ts (error TS2307: Cannot find module '@object-ui/plugin-*'), flipping the Bundle Analysis / Build CI job red or flaky. Fix, applied consistently across all dts-emitting packages: - compilerOptions.rootDir -> each package's own src, so dts emit is flat (dist/index.d.ts + dist/*.d.ts; no nested packages/<pkg>/src tree). - aliasesExclude: [/^@object-ui\//], so cross-package type imports stay bare (`@object-ui/types`) and resolve to each dependency's own built dist .d.ts instead of being rewritten to relative sibling-src paths (which were broken under the nested layout and dragged raw cross-package src once flattened). JS bundles are byte-identical (rollup already externalizes bare imports; the aliases only fed the bundler/tests, not the published JS). app-shell ReportView: annotate viewerSchema as ReportViewerSchema. This is a real type error that was previously masked because the broken relative-path type resolution degraded ReportViewer's prop type to `any`; it surfaces once the plugin .d.ts resolve correctly. Verified: `turbo run build --filter='./packages/*'` (the Bundle Analysis CI job) is green and deterministic across repeated clean runs; previously the same command intermittently failed app-shell with TS2307. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

vercel · 2026-06-15T16:07:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jun 15, 2026 4:07pm

github-actions · 2026-06-15T16:11:10Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	116.9 KB	350 KB
Entry file	`index-B0hr-HId.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	5.95KB	2.10KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.16KB	3.44KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	5.11KB	1.92KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	24.74KB	6.00KB
auth (createAuthenticatedFetch.js)	3.33KB	1.32KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.01KB	0.79KB
auth (useIsWorkspaceAdmin.js)	1.28KB	0.70KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	399.89KB	84.82KB
core (index.js)	1.49KB	0.55KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	96.32KB	23.93KB
fields (index.js)	157.36KB	37.46KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.32KB	0.93KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	20.24KB	4.57KB
i18n (useSafeTranslation.js)	1.63KB	0.57KB
layout (index.js)	36.05KB	9.94KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	4.87KB	1.77KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.11KB	0.87KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.42KB	0.68KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.98KB	12.65KB
plugin-charts (index.js)	40.52KB	11.50KB
plugin-chatbot (index.js)	137.10KB	33.56KB
plugin-dashboard (index.js)	93.21KB	22.37KB
plugin-designer (index.js)	213.42KB	42.94KB
plugin-detail (index.js)	192.76KB	46.42KB
plugin-editor (index.js)	2.38KB	1.06KB
plugin-form (index.js)	90.39KB	21.59KB
plugin-gantt (index.js)	119.23KB	29.40KB
plugin-grid (index.js)	111.11KB	29.94KB
plugin-kanban (index.js)	48.82KB	13.13KB
plugin-list (index.js)	95.42KB	22.33KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	12.00KB	4.05KB
plugin-report (index.js)	34.79KB	9.13KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-view (index.js)	81.95KB	19.98KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	14.98KB	4.84KB
react (index.js)	0.76KB	0.42KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

Composite-tsc packages (composite: true) write incremental state to <package>/tsconfig.tsbuildinfo at the package root. turbo's `build` task only declared dist/**/.next/**/build/** as outputs, so the incremental build-info was neither hashed nor cached/restored in sync with dist. A turbo cache hit then restored dist but left whatever stale tsbuildinfo happened to be on disk, and a build run with a desynced tsbuildinfo could under-emit (e.g. tsc believing the project is up-to-date), producing a partial dist that turbo would then cache and replay — surfacing as `TS2307: Cannot find module '@object-ui/app-shell'` in consumers. Add **/*.tsbuildinfo to the `build` task outputs so incremental state is cached and restored atomically with dist. CI fresh checkouts were already safe (*.tsbuildinfo is gitignored → always a full emit); this closes the local / warm-cache desync. Follow-up to #1760 / #1766. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actionsBot added package: components plugin plugin: charts plugin: editor plugin: kanban plugin: markdown labels Jun 15, 2026

os-zhuang merged commit ac89278 into mainJun 15, 2026
10 checks passed

os-zhuang deleted the fix/app-shell-build-1760 branch June 15, 2026 16:14

os-zhuang mentioned this pull request Jun 15, 2026
fix(build): cache composite tsc .tsbuildinfo as a turbo output #1767
Merged

Navigation Menu

Uh oh!

fix(build): deterministic flat plugin .d.ts to stop flaky app-shell build (#1760) - #1766

fix(build): deterministic flat plugin .d.ts to stop flaky app-shell build (#1760)#1766
os-zhuang merged 1 commit into
mainfrom
fix/app-shell-build-1760

os-zhuang commented Jun 15, 2026

Uh oh!

vercelBot commented Jun 15, 2026

Uh oh!

github-actionsBot commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jun 15, 2026

Problem

Root cause

Fix

Verification

Uh oh!

vercelBot commented Jun 15, 2026

Uh oh!

github-actionsBot commented Jun 15, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant