Skip to content

refactor: remove view-level tabs; userFilters is the sole page filter (ADR-0053) - #1804

Merged
os-zhuang merged 1 commit into
mainfrom
worktree-listview-tabs
Jun 19, 2026
Merged

refactor: remove view-level tabs; userFilters is the sole page filter (ADR-0053)#1804
os-zhuang merged 1 commit into
mainfrom
worktree-listview-tabs

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Part of ADR-0053. Retires mechanism #3 (the view-level schema.tabs / TabBar).

Why (validated live against Airtable)

Airtable's Interface Designer separates User filters (None / Tabs / Dropdown — the end-user filter control; a tab is {name, filter}) from Visualizations (List / Timeline / Kanban — the view form). A tab filters data, never switches the view form. ObjectUI's schema.tabs carried a view switch, conflating the two → removed. userFilters (dropdown | tabs) is the single page-filter mechanism, matching Airtable.

Changes

  • types: drop ListViewSchema.tabs
  • plugin-list ListView: remove activeTab state, mount tab-filter effect, handleTabChange, the TabBar/TabBarSelect render row; simplify guard to filterElements = userFilters
  • plugin-view ObjectView: stop passing tabs
  • app-shell ObjectView: drop the tabs: undefined suppression
  • react spec-bridge: stop mapping spec.tabs (clean-build; a check rule flags it later)
  • TabBar kept (still used by plugin-view's view switcher)
  • tests: removed the schema.tabs suite; userFilters tabs tests untouched

Verification

type-check 58/58; affected tests 197 pass. Browser (showcase): one switcher row, legacy view-tabs row gone, 10 records load, no errors.

🤖 Generated with Claude Code

@os-zhuang@claude
refactor: remove view-level tabs (schema.tabs); userFilters is sole p…
cac0bda
…age filter (ADR-0053)
Validated against Airtable's Interface Designer: "User filters" (None/Tabs/
Dropdown) is the end-user filter control; a tab is just {name, filter} and never
switches the view form (that's "Visualizations", a separate axis). ObjectUI's
schema.tabs carried a "view" switch, conflating filter and form, so it is removed:
- types: drop ListViewSchema.tabs
- plugin-list ListView: remove activeTab state, mount tab-filter effect,
handleTabChange, the TabBar/TabBarSelect render row; simplify the
mutually-exclusive guard to filterElements = userFilters
- plugin-view ObjectView: stop passing tabs through
- app-shell ObjectView: drop the tabs:undefined suppression
- react spec-bridge: stop mapping spec.tabs (clean-build; check rule flags it)
- TabBar component kept (still used by plugin-view's view switcher)
- tests: remove schema.tabs "tabs rendering" suite; userFilters tabs tests stay
Full monorepo type-check 58/58; affected tests 197 pass. Browser: object list
shows one switcher row, no legacy tab row, list loads.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 19, 2026 10:19am

Request Review

@github-actions

github-actionsBot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)58.7 KB350 KB
Entry fileindex-BGKy59A-.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.95KB2.10KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)24.74KB6.00KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)413.83KB87.84KB
core (index.js)1.44KB0.53KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)96.65KB24.08KB
fields (index.js)157.75KB37.58KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.32KB0.93KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)1.63KB0.57KB
layout (index.js)36.05KB9.94KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)40.52KB11.50KB
plugin-chatbot (index.js)141.13KB34.56KB
plugin-dashboard (index.js)93.22KB22.37KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)193.28KB46.52KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)91.08KB22.18KB
plugin-gantt (index.js)119.55KB29.45KB
plugin-grid (index.js)114.50KB30.71KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)92.32KB21.76KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.58KB4.64KB
plugin-report (index.js)34.79KB9.13KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)84.13KB20.27KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)14.98KB4.84KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit ca5fdff into mainJun 19, 2026
9 of 10 checks passed
@os-zhuang
os-zhuang deleted the worktree-listview-tabs branch June 19, 2026 10:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: reactpackage: typesplugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang