Uh oh!
There was an error while loading. Please reload this page.
fix(sdui): page:card shadowing, matrix header, image cell URLs, gantt initial scroll - #1815
Merged
Conversation
… initial scroll
Four remaining renderer polish bugs found in the showcase QA pass. All
browser-verified on :5181.
1. page:card rendered EMPTY in page regions (title/body missing, schema props
leaked onto the DOM). Root cause: @object-ui/layout's thin `PageCard`
(a bare `<div {...props}>`) registered the bare `page:card` key WITHOUT
skipFallback, shadowing the record-aware PageCardRenderer in
@object-ui/components (depending on load order). Added `skipFallback: true`
to the layout registration — same fix the file already applies to
`page-header`. page:card now renders title + body/children, no prop leak.
2. matrix report row-dimension header showed the raw dimension NAME
("status"). The renderer only knows dimension names (not the dataset's
display labels), so humanize the header for display: "status" → "Status",
"created_at" → "Created At".
3. image grid cell rendered <img src=""> (broken thumbnail) for string-URL
image fields — ImageCellRenderer only read `value.url`/array, never a plain
string. Normalized to accept string | {url|src|href} | array; falls back to
EmptyValue when no URL. Cover thumbnails now load in grids.
4. gantt opened on an empty window when tasks sit weeks into the range — there
was no initial scroll (only on-demand jump buttons). Added a one-shot
post-layout scroll to today (when in range) else the earliest task's start.
Verified: report header reads "Status"; All Views cover column loads 10/10
thumbnails; Team Schedule opens centered on today with bars in view; My Work
page:cards render title+children. Changed-package tests pass (the standalone
layout/gantt-layout failures are a pre-existing jsdom localStorage.clear gap,
unaffected by these changes).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four remaining renderer polish bugs found in the showcase QA pass. All browser-verified on
:5181.1 —
page:cardrendered empty in page regionsTitle/body missing, schema props leaked onto the DOM. Root cause:
@object-ui/layout's thinPageCard(a bare<div {...props}>) registered the barepage:cardkey withoutskipFallback, shadowing the record-awarePageCardRendererin@object-ui/components(load-order dependent). AddedskipFallback: true— the same fix the file already applies topage-header. Now renders title + body/children, no prop leak.2 — Matrix report row-header showed raw dimension name
Showed
status(the dimension name). The renderer only knows dimension names, not the dataset's display labels, so humanize for display:status→ Status,created_at→ Created At.3 — Image grid cell broke on string-URL fields
ImageCellRendereronly readvalue.url/arrays, so a plain string URL (e.g. acoverCDN link) rendered<img src="">. Normalized to acceptstring | {url|src|href} | array, with anEmptyValuefallback. Cover thumbnails load in grids again.4 — Gantt opened on an empty window
No initial scroll — it opened at the padded left edge with tasks weeks off-screen. Added a one-shot post-layout scroll to today (when in range), else the earliest task's start.
Verified
Report header reads "Status"; All Views cover column loads 10/10 thumbnails; Team Schedule opens centered on today with bars in view; My Work
page:cards render title+children.Tests
Changed-package suites pass (fields 4000, plugin-report 32, plugin-gantt 179). The standalone
layout(32) andGanttView.layout.test(12) failures are a pre-existing jsdomlocalStorage.cleargap — identical with these changes stashed, so unaffected.Companion framework PR re-instates the showcase
page:cards on My Work.🤖 Generated with Claude Code