Skip to content

feat(dashboard): label headers, currency-correct amounts, i18n & drill-through for dataset widgets - #1825

Merged
xuyushun441-sys merged 2 commits into
mainfrom
fix/dashboard-report-ux
Jun 20, 2026
Merged

feat(dashboard): label headers, currency-correct amounts, i18n & drill-through for dataset widgets#1825
xuyushun441-sys merged 2 commits into
mainfrom
fix/dashboard-report-ux

Conversation

@xuyushun441-sys

@xuyushun441-sysxuyushun441-sys commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Why

From a user-perspective review of the report page (dashboard/showcase_chart_gallery), the "二维表"/table widgets — rendered by DatasetWidget — had four gaps:

  1. Headers showed raw field names (status) instead of labels (Status).
  2. Amounts showed a $ even when the field has no declared currency.
  3. Hardcoded English strings ("No rows", "Pick measures…", errors); no i18n.
  4. No data drill-through — rows were inert.

What

  • Headers: resolve via the server-enriched field label → i18n field-label convention → raw name.
  • Currency: formatMeasure derives the symbol from the field's currency via Intl (locale-correct) and renders a plain number when no currency is declared. A legacy $ literal in a format string is still honored.
  • i18n: strings go through useObjectTranslation (+ en/zh entries); graceful English fallback when no provider.
  • Drill-through: table/pivot rows open the DrillDownDrawer filtered by the clicked bucket, using the server's raw grouped values (drillRawRows) + dimension→field map — so select/lookup dims filter by the stored value, not the display label. Pure buildDrillFilter helper is unit-tested.
  • data-objectstack.queryDataset passes the new object/dimensionFields/drillRawRows metadata through.

Tests

DatasetWidget.test.tsx: header labels, currency (plain vs Intl symbol), drill enablement, and buildDrillFilter (raw value, field mapping, runtime-filter AND, null normalization). 21/21 green; package type-check green.

Requires

Server metadata from framework PR #2080 for the dimension labels (#1/#2) and drill-through (#4) to light up end-to-end.

🤖 Generated with Claude Code

@os-zhuang@claude
feat(dashboard): label headers, currency-correct amounts, i18n & dril…
b71c0a8
…l-through for dataset widgets
DatasetWidget (the renderer behind dataset-bound dashboard table/pivot/metric
widgets, e.g. the Chart Gallery) had four user-facing gaps:
- Headers showed raw field names. Now resolve via the server-enriched field
label, then the i18n field-label convention, then the raw name.
- Amounts showed a hardcoded "$" even with no declared currency. `formatMeasure`
now derives the symbol from the field's `currency` via `Intl` (locale-correct),
and renders a plain number when no currency is declared. A legacy "$" literal
in a format string is still honored.
- Hardcoded English strings ("No rows", "Pick measures…", the unsupported-source
error) now go through `useObjectTranslation` with en/zh entries.
- No data drill-through. Table/pivot rows are now clickable and open the
DrillDownDrawer filtered by the clicked bucket, using the server's RAW grouped
values (`drillRawRows`) + dimension→field map so select/lookup dims filter by
the stored value, not the display label. `buildDrillFilter` is unit-tested.
data-objectstack `queryDataset` passes the new `object`/`dimensionFields`/
`drillRawRows` drill metadata through.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 20, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 20, 2026 4:11pm

Request Review

@github-actions

github-actionsBot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)58.7 KB350 KB
Entry fileindex-vg0azzvC.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.95KB2.10KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)24.74KB6.00KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)414.34KB87.93KB
core (index.js)1.44KB0.53KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)96.97KB24.14KB
fields (index.js)158.94KB38.06KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.32KB0.93KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)1.63KB0.57KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)40.52KB11.50KB
plugin-chatbot (index.js)141.13KB34.56KB
plugin-dashboard (index.js)94.77KB23.54KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)195.27KB47.06KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)91.08KB22.18KB
plugin-gantt (index.js)122.36KB30.13KB
plugin-grid (index.js)114.52KB30.73KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)93.13KB21.89KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.58KB4.64KB
plugin-report (index.js)34.93KB9.20KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)84.13KB20.27KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)15.64KB5.08KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang@claude
feat(dashboard): render dataset pivot widgets as a true cross-tab
44c445c
A `type: 'pivot'` dataset widget rendered identically to `table` — a flat
grouped list (dimensions + measures as columns), so "Tasks by Status × Priority"
showed three columns instead of a matrix.
Now a pivot with ≥2 dimensions renders a real cross-tab: the LAST dimension
spreads across as columns, the rest go down as rows, measures fill the cells.
The dataset already returns one row per dimension combination, so cells just
place those pre-aggregated values — no client re-aggregation (an avg/min/max
can't be recombined). A single-dimension pivot degrades to the flat table.
Cells drill through using the same raw-value mapping as rows: clicking a cell
filters the records by BOTH dimensions' raw stored values (verified live:
clicking "Backlog × Low" opens exactly the matching task). `buildPivot` is a
pure, unit-tested helper.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actionsBot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)58.7 KB350 KB
Entry fileindex-DqqN7GZ1.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.95KB2.10KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)24.74KB6.00KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)414.34KB87.93KB
core (index.js)1.44KB0.53KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)96.97KB24.14KB
fields (index.js)158.94KB38.06KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.32KB0.93KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)1.63KB0.57KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)40.52KB11.50KB
plugin-chatbot (index.js)141.13KB34.56KB
plugin-dashboard (index.js)97.05KB24.11KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)195.27KB47.06KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)91.08KB22.18KB
plugin-gantt (index.js)122.36KB30.13KB
plugin-grid (index.js)114.52KB30.73KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)93.13KB21.89KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.58KB4.64KB
plugin-report (index.js)34.93KB9.20KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)84.13KB20.27KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)15.64KB5.08KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@xuyushun441-sys
xuyushun441-sys merged commit dea6a3d into mainJun 20, 2026
9 of 10 checks passed
@xuyushun441-sys
xuyushun441-sys deleted the fix/dashboard-report-ux branch June 20, 2026 16:21
This was referenced Jun 20, 2026
Merged
Merged
xuyushun441-sys added a commit that referenced this pull request Jun 20, 2026
@xuyushun441-sys@os-zhuang@claude
feat(plugin-report): currency-aware, i18n labels in the dataset repor…
93284b2
…t renderer (#1830)
Port the dashboard DatasetWidget fixes (PR #1825/#1827/#1828) to the standalone
Reports renderer, which had the same user-visible problems:
- Headers showed raw field names: DatasetReportTable rendered `{c}` and
DatasetMatrixTable used a Title-Case humanize() — neither the real label.
- Measures formatted as plain numbers with no currency awareness.
- No i18n: "Total" and friends were hardcoded English.
Changes:
- useDatasetRows now captures the server-returned `fields` (label/format/
currency) and `object` (queryDataset already returns them).
- Headers resolve via field label → i18n fieldLabel → raw name fallback
(drops the `{c}`/humanizeDimension fallbacks).
- Measure cells + server totals format with the field's currency (Intl symbol)
and numeral format, mirroring DatasetWidget.formatMeasure — never a bare
number or a misleading "$".
- i18n via useObjectTranslation / useSafeFieldLabel with graceful fallback;
"Total" uses tt('report.total', 'Total').
Drill-through and server-supplied totals are unchanged.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

data-adapterplugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xuyushun441-sys@os-zhuang