Skip to content

fix(currency): resolve tenant default currency across long-tail renderers - #1858

Merged
xuyushun441-sys merged 1 commit into
mainfrom
phase2b-currency-migration
Jun 21, 2026
Merged

fix(currency): resolve tenant default currency across long-tail renderers#1858
xuyushun441-sys merged 1 commit into
mainfrom
phase2b-currency-migration

Conversation

@xuyushun441-sys

Copy link
Copy Markdown
Contributor

What

Phase 2b (final) of the currency-resolution work (ADR-0053). The low-level field/cell renderers already funnel through resolveFieldCurrency + useLocalization (#1856/#1857). This unifies the remaining ("long-tail") renderers onto the same resolution chain so a tenant's localization.currency flows everywhere instead of being hard-coded to USD or read from only one of currency/defaultCurrency.

Resolution chain (shared resolveFieldCurrency): explicit field currencycurrencyConfig.defaultCurrency → legacy defaultCurrency → tenant localization.currency → plain number.

Renderers migrated

PackageSiteBefore
plugin-dashboardObjectMetricWidget inferred currencyread only defaultCurrency/currency
plugin-dashboardObjectDataTable symbol-format cellno tenant fallback
plugin-griduseColumnSummary footerread only currency/defaultCurrency
plugin-gridObjectGrid compact amount + name-inferred cellsbare number
plugin-detailDetailView summary metricsread only currency
plugin-ganttObjectGantt currency tooltipsno currency at all
componentselement:number (format: 'currency')baked-in USD

Architecture

resolveFieldCurrency moves into @object-ui/i18n (co-located with useLocalization, which supplies the tenant default); @object-ui/fields re-exports it, so the existing @object-ui/fields import path is unchanged. @object-ui/i18n added as a dep to plugin-grid / plugin-gantt / plugin-detail.

Compatibility

No behavior change when no tenant currency is configured: a field that declares its own currency, or a deployment with no localization.currency, renders exactly as before. element:number keeps USD as the last-resort fallback.

Tests

  • @object-ui/i18nresolveFieldCurrency precedence (canonical home).
  • @object-ui/plugin-griduseColumnSummary tenant-default footer (renderHook + LocalizationProvider); explicit column currency still wins; plain number with no tenant.
  • @object-ui/plugin-dashboardObjectDataTable renders a currency-type column with the tenant default through CurrencyCellRenderer.

All touched-package suites green; type-check clean across all 7 packages.

🤖 Generated with Claude Code

…rers
Phase 2b of the currency-resolution work (ADR-0053). The field/cell renderers
already funnelled through resolveFieldCurrency + useLocalization (#1856); this
unifies the remaining renderers onto the same chain (explicit field currency ->
currencyConfig.defaultCurrency -> legacy defaultCurrency -> tenant
localization.currency -> plain number):
- plugin-dashboard: ObjectMetricWidget inferred currency, ObjectDataTable
symbol-format fallback.
- plugin-grid: useColumnSummary footer + ObjectGrid compact/name-inferred cells.
- plugin-detail: DetailView summary metrics.
- plugin-gantt: ObjectGantt currency tooltips.
- components: element:number (format:'currency') — tenant default + tenant locale
instead of a baked-in USD.
resolveFieldCurrency moves to @object-ui/i18n (co-located with useLocalization,
which supplies the tenant default); @object-ui/fields re-exports it so the
existing import path is unchanged. No behavior change when no tenant currency is
configured. Adds i18n unit + plugin-grid hook + dashboard table integration tests.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 21, 2026 11:37am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)58.8 KB350 KB
Entry fileindex-Dl9Dn_L5.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)5.95KB2.10KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.16KB3.44KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)5.11KB1.92KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)24.74KB6.00KB
auth (createAuthenticatedFetch.js)3.33KB1.32KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.01KB0.79KB
auth (useIsWorkspaceAdmin.js)1.28KB0.70KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)414.48KB88.02KB
core (index.js)1.48KB0.54KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)97.05KB24.16KB
fields (index.js)159.20KB38.10KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)4.87KB1.77KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.11KB0.87KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.42KB0.68KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)40.52KB11.50KB
plugin-chatbot (index.js)141.13KB34.56KB
plugin-dashboard (index.js)99.09KB24.59KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)195.59KB47.19KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)93.07KB22.68KB
plugin-gantt (index.js)122.48KB30.19KB
plugin-grid (index.js)114.67KB30.78KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)93.15KB21.90KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.58KB4.64KB
plugin-report (index.js)35.93KB9.50KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-view (index.js)84.13KB20.27KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)15.64KB5.08KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@xuyushun441-sys
xuyushun441-sys merged commit bd8b054 into mainJun 21, 2026
10 checks passed
@xuyushun441-sys
xuyushun441-sys deleted the phase2b-currency-migration branch June 21, 2026 11:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@xuyushun441-sys@os-zhuang