Uh oh!
There was an error while loading. Please reload this page.
Add Markdown component with GFM support and XSS protection - #19
Merged
Conversation
Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Markdown component to Object UI, enabling schema-driven rendering of markdown content with GitHub Flavored Markdown support and XSS protection.
Changes:
- Added markdown UI component with Tailwind prose styling and security hardening
- Created markdown renderer component and registered it with ComponentRegistry
- Added comprehensive test coverage and a working demo in the prototype application
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/ui/markdown.tsx | New UI component wrapping react-markdown with Tailwind styling and security |
| packages/components/src/ui/index.ts | Export statement for the new markdown component |
| packages/components/src/renderers/data-display/markdown.tsx | Renderer component registering markdown with ComponentRegistry |
| packages/components/src/renderers/data-display/index.ts | Import statement to include markdown renderer |
| packages/components/src/new-components.test.ts | Test case verifying markdown component registration |
| packages/components/package.json | Added react-markdown, remark-gfm, and rehype-sanitize dependencies |
| examples/prototype/src/App.tsx | Demo implementation showcasing markdown component features |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comment on lines
+7
to
+10
| export interface MarkdownProps { | ||
| content: string | ||
| className?: string | ||
| } |
There was a problem hiding this comment.
The MarkdownProps interface lacks JSDoc comments. According to Rule #3 ('Schema First' Mindset), every property in the Schema MUST have JSDoc to enable auto-generated documentation for the open-source community. Add JSDoc describing the purpose of 'content' and 'className' properties.
ContributorAuthor
There was a problem hiding this comment.
Added comprehensive JSDoc documentation to the MarkdownProps interface describing the purpose and supported features of each property. Documentation follows the "Schema First" principle to enable auto-generated API docs. (commit c31876c)
| import { Markdown } from '@/ui'; | ||
| ComponentRegistry.register('markdown', | ||
| ({ schema, className, ...props }) => ( |
There was a problem hiding this comment.
The renderer component function lacks JSDoc documentation. Add a JSDoc comment explaining that this is a Schema-driven renderer for markdown content, following the 'Schema First' principle outlined in Rule #3.
ContributorAuthor
There was a problem hiding this comment.
Added detailed JSDoc documentation to the markdown renderer component explaining its schema-driven architecture and usage. Includes example JSON configuration and lists all supported features. (commit c31876c)
CopilotAI
changed the title
[WIP] Add new markdown componentAdd Markdown component with GFM support and XSS protectionJan 14, 2026
Contributor
✅ All checks passed!
|
huangyiirene
commented
Jan 14, 2026
Collaborator
@copilot 从主分支之更新最新代码并修正代码冲突 |
Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
ContributorAuthor
Copilot stopped work on behalf of huangyiirene due to an error
January 14, 2026 00:48
Contributor
✅ All checks passed!
|
hotlong
marked this pull request as ready for review
January 14, 2026 01:01
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 31, 2026
os-sam pushed a commit
that referenced
this pull request
Aug 31, 2026
…iews that declared none A view carrying no `calendar:` block used to have a complete-looking calendar config synthesized for it: `ObjectView` fabricated `startDateField: 'due_date'` and `titleField: 'name'`, and `ListView`'s calendar branch floored the same two bindings at `'start_date'` / `'end_date'` one layer down. `ObjectCalendar` decides whether it has a usable configuration by asking whether a start-date binding is PRESENT, so the fabrication short-circuited its own refusal screen — which has existed all along and was simply unreachable from this route. Both faces now forward only what the author declared. With no binding to forward, the capability gate stops offering the Calendar toggle to views that configured none, and a view forced onto the renderer reaches the refusal screen instead of a plausible, fully wrong one. Ruled on objectstack#13748 (director batch #19, option A). The spec half — cross-field validation of a half-written declaration — is objectstack#13817. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
akarma-synetal pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 1, 2026
…mes, so the refusal screen becomes reachable (objectstack-ai#7062) * fix(app-shell,plugin-list): stop inventing calendar field names for views that declared none A view carrying no `calendar:` block used to have a complete-looking calendar config synthesized for it: `ObjectView` fabricated `startDateField: 'due_date'` and `titleField: 'name'`, and `ListView`'s calendar branch floored the same two bindings at `'start_date'` / `'end_date'` one layer down. `ObjectCalendar` decides whether it has a usable configuration by asking whether a start-date binding is PRESENT, so the fabrication short-circuited its own refusal screen — which has existed all along and was simply unreachable from this route. Both faces now forward only what the author declared. With no binding to forward, the capability gate stops offering the Calendar toggle to views that configured none, and a view forced onto the renderer reaches the refusal screen instead of a plausible, fully wrong one. Ruled on objectstack#13748 (director batch objectstack-ai#19, option A). The spec half — cross-field validation of a half-written declaration — is objectstack#13817. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB * fix(plugin-view): stop inventing calendar bindings on the element route too `generateViewSchema` runs when no host supplies `renderListView` — the authored `object-view` element — so it bypasses `ListView` and carried its own copy of the fabrication (`start_date` / `end_date` / `name`). Same defect, same ruling (objectstack#13748: no invented field names either way); fixing only the console route would have left this one producing the same wrong screen. Also retargets `ObjectView.titleFieldConvergence.test.tsx`: its `calendar` column pinned the `|| 'name'` floor this card deletes, and the seam count drops from seven to six. What objectui#6557 owns is unchanged and still pinned. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB * chore(changeset): objectui#7029 — no invented calendar field names Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Plan for Markdown Component
Summary
Successfully implemented a new Markdown component for Object UI with comprehensive JSDoc documentation and merged latest changes from main branch.
Changes in This Update
✅ Added JSDoc Documentation
MarkdownPropsinterface✅ Merged Main Branch
Component Features
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.