fix(studio): localize lookup picker config + keep published org objects editable by os-zhuang · Pull Request #1937 · objectstack-ai/objectui

os-zhuang · 2026-06-24T03:35:51Z

Found while dogfooding Studio's object designer as a business user.

1. i18n — lookup "Picker config" sub-panel was hard-coded English

In an otherwise-Chinese designer, the lookup field's advanced Picker config
block ("Picker config", "Display field", "Description field", "Search fields…",
"Selectable records", "Add filter", "No filter — every … record is selectable.",
"Depends on …", "Picker page size", "Allow quick-create", …) rendered in English.
Routed every literal through t()/tFormat() with new designer.field.lookup.*
keys (en + zh). Browser-verified: all strings now Chinese, zero English left.

2. Published org objects read back as read-only

After publishing a custom (org-authored) object, its active version surfaces in
the layered code slot — but tagged with the sys_metadata provenance sentinel,
not a real package. ResourceEditPage computed isArtifactItem = layered?.code != null,
treating it as a packaged artifact (which needs allowOrgOverride, a capability
the object type lacks) → the object the user just created locked itself
read-only. Mirror the server's isArtifactBacked(), which excludes
_packageId === 'sys_metadata', so org items stay editable.

Complements framework #2252 (which stops stamping runtime metadata into a loaded
code package). #2252 fixes the persisted package_id; this closes the matching
front-end gate so the object is actually editable end-to-end.

Verification

@object-ui/app-shell vitest (ObjectFieldInspector + _shared.select): 19/19 green.
i18n localization confirmed live in the browser (console dev server → showcase backend).
The editable fix mirrors the server's own artifact-provenance rule; validated
against layered metadata (org object code._packageId = sys_metadata vs a real
code object = com.example.showcase).

🤖 Generated with Claude Code

…ts editable Two dogfooding fixes in the object-field designer: 1. i18n — the lookup field's "Picker config" sub-panel (display/description field, selectable-records filters, depends-on, page size, quick-create) was hard-coded English in an otherwise-Chinese designer. Routed every literal through t()/tFormat() with new designer.field.lookup.* keys (en + zh). 2. Published org objects read back as read-only. After publish, an org object's active version surfaces in the layered 'code' slot tagged with the 'sys_metadata' provenance sentinel. ResourceEditPage treated any non-null 'code' as a packaged artifact (needs allowOrgOverride, which 'object' lacks), so a freshly-published custom object locked itself read-only. Mirror the server's isArtifactBacked() — which excludes _packageId === 'sys_metadata' — so org-authored items stay editable. Complements the framework-side fix that stops stamping runtime metadata into a loaded code package. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-06-24T03:35:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jun 24, 2026 3:35am

github-actions · 2026-06-24T03:39:32Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	58.8 KB	350 KB
Entry file	`index-L2zUa3A0.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	6.59KB	2.34KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.16KB	3.44KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	5.11KB	1.92KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	24.74KB	6.00KB
auth (createAuthenticatedFetch.js)	3.33KB	1.32KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.01KB	0.79KB
auth (useIsWorkspaceAdmin.js)	1.28KB	0.70KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	415.54KB	88.49KB
core (index.js)	1.52KB	0.55KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	97.73KB	24.27KB
fields (index.js)	166.21KB	40.08KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	36.30KB	10.04KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.98KB	12.65KB
plugin-charts (index.js)	45.71KB	12.82KB
plugin-chatbot (index.js)	153.41KB	37.19KB
plugin-dashboard (index.js)	106.67KB	26.41KB
plugin-designer (index.js)	213.42KB	42.94KB
plugin-detail (index.js)	195.59KB	47.19KB
plugin-editor (index.js)	2.38KB	1.06KB
plugin-form (index.js)	93.24KB	22.71KB
plugin-gantt (index.js)	133.11KB	32.92KB
plugin-grid (index.js)	115.41KB	31.01KB
plugin-kanban (index.js)	48.82KB	13.13KB
plugin-list (index.js)	94.53KB	22.32KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	13.58KB	4.64KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.04KB	2.70KB
plugin-view (index.js)	84.45KB	20.36KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	17.06KB	5.59KB
react (index.js)	0.76KB	0.42KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…estore F6 wording (#1941) * test(metadata-admin): add data-testid hooks to the Studio object designer Stable selectors for the live-e2e/dogfood gate (no behavior change): object-name-input, field-apiname-input, field-label-input (via an optional InspectorTextField testId prop), package-id-input/package-name-input, package-switcher, source-editor, metadata-validation-banner, readonly-banner. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(metadata-admin): Studio object-designer dogfood gate (F1-F6) A "drive the Studio designer as a user" regression gate for the UX classes fixed in #1926 — the kind static gates (build/unit/spec-liveness) miss because the break only appears when a real user drives the real controlled inputs against the real spec validator. Live e2e (e2e/live/studio-object-designer.spec.ts, runs against the real stack): F2 — object Name accepts a TYPED underscore. Must pressSequentially, not fill(): .fill() sets the value in one shot and hides the per-keystroke trim. Proven to go red when the trailing-trim bug is reintroduced. F3 — a field API name derives from its label on blur. F4 — adding a picklist + an empty option row does NOT trip spec validation. Live validation is debounced, so the negative assertion settles first; proven red when empty rows are persisted again. F1 — a newly created package appears in the switcher without a reload (creates + cleans up a throwaway package). Component/unit (fast layer, no backend): F5 — JsonSourceEditor falls back to an editable textarea when Monaco can't paint (offline/CSP/worker-blocked). fallbackDelayMs added so the test doesn't wait the full grace period. F6 — artifactLockedBanner wording (en + zh): not "shipped by a code package", and states the real edit path. This gate immediately earned its keep: the F6 test failed on first run because a parallel PR (#1937, branched off pre-#1926 main) had silently reverted the banner wording. Re-applied here (i18n.ts) — exactly the regression class the gate exists to catch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

os-zhuangand others added 2 commits June 24, 2026 11:21

chore(changeset): studio lookup i18n + org-object editable (patch)
cb1f577
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

os-zhuang merged commit 44d4582 into mainJun 24, 2026
10 checks passed

os-zhuang deleted the fix/studio-field-inspector-ux branch June 24, 2026 03:43

os-zhuang mentioned this pull request Jun 24, 2026
test(metadata-admin): Studio object-designer dogfood gate (F1-F6) + restore F6 wording #1941
Merged

os-zhuang mentioned this pull request Jun 24, 2026
feat(studio): add "Local / Custom (this env)" scope to the package selector #1946
Merged

This was referenced Jun 24, 2026
chore: release packages #1924
Closed
chore: release packages #1961
Merged

os-zhuang mentioned this pull request Jul 5, 2026
AppNavInspector 编辑 off-spec 的 nav path/kind(运行期不生效)——应改为 type + 分类型目标选择器 #2245
Closed

Navigation Menu

Uh oh!

fix(studio): localize lookup picker config + keep published org objects editable - #1937

fix(studio): localize lookup picker config + keep published org objects editable#1937
os-zhuang merged 2 commits into
mainfrom
fix/studio-field-inspector-ux

os-zhuang commented Jun 24, 2026

Uh oh!

vercelBot commented Jun 24, 2026

Uh oh!

github-actionsBot commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jun 24, 2026

1. i18n — lookup "Picker config" sub-panel was hard-coded English

2. Published org objects read back as read-only

Verification

Uh oh!

vercelBot commented Jun 24, 2026

Uh oh!

github-actionsBot commented Jun 24, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant