Skip to content

fix(charts): resolve select-dimension value→label so grouped charts don't zero out (cloud#667) - #2045

Merged
os-zhuang merged 1 commit into
mainfrom
claude/nervous-wright-4e043c
Jun 28, 2026
Merged

fix(charts): resolve select-dimension value→label so grouped charts don't zero out (cloud#667)#2045
os-zhuang merged 1 commit into
mainfrom
claude/nervous-wright-4e043c

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Problem

An ObjectStack dashboard chart that groups a count by a select field (e.g. a bar chart "客户数量按状态") rendered every bar at 0, even though the object's list clearly has rows.

Real-machine root cause (DB ground truth): the tk5f_customer.status field stores English values (active/lost/potential) with localized labels (合作中/已流失/潜在). The dataset groups by the stored value, so the grouped rows are value-keyed with correct counts. The chart, however, expected the analytics server to have already resolved the dimension value→label — when it hasn't, the raw enum values reach the axis, and the option-keyed colour/category wiring (built from the field labels) no longer lines up with the value-keyed rows, so categories read empty.

This is the default product of the AI build agent (English value + localized label), so Chinese AI apps hit it constantly. It does not reproduce when a select's value == its label.

Root cause: chart layer, not dataset layer

The framework analytics service does have value→label resolution (service-analytics/src/dimension-labels.ts), but it silently no-ops when it can't read the field options (common for AI-built selects) — then rows arrive value-keyed. The objectui dataset chart path (DatasetWidget + ObjectChart's dataset branch) does no value→label resolution of its own and assumes the server did it — unlike the legacy aggregate path, which already resolves labels via resolveGroupByLabels. So the fix belongs in the chart layer.

Fix

Make the chart layer authoritative: resolve value→label from the object field options, keying chart data by value (so grouped counts always attach) and displaying the label.

  • @object-ui/corechart-series.ts — two new shared, pure helpers:
    • buildDimensionLabelMap(options){ value → label } (mirrors buildOptionColorMap; drops no-op label==value entries).
    • relabelDimensions(rows, labelMaps) → rewrites each select-dimension value to its label, leaving measures attached. Idempotent (already-resolved labels / lookup ids / free text pass through) and never mutates the input, so server-resolved labels and the raw drillRawRows both survive.
  • plugin-dashboard/DatasetWidget and plugin-charts/ObjectChart — build the {value→label} maps from the same object-schema fetch they already run for per-category colours (no extra request), then relabelDimensions before buildChartSeries. chartRows stay index-aligned with drillRawRows, so drill-through still filters by the raw stored value.

No framework / dataset-server changes; no new network calls.

Verification

Honest about depth — verified at code + build + unit/component levels:

  • @object-ui/corechart-series.test.ts15 passed, incl. new tests for buildDimensionLabelMap, relabelDimensions, and the composition with buildChartSeries for the exact value≠label scenario (single dimension and pivoted second dimension): every count lands on its label category.
  • plugin-dashboardDatasetWidget36 passed (34 existing + 2 new). The new DatasetWidget.relabel.test.tsx drives the realDatasetWidget + SchemaRenderer: value-keyed rows {active:6, lost:2, potential:4} + object-schema options ⇒ the chart receives label-keyed data {合作中:6, 已流失:2, 潜在:4} with the raw active gone from the axis; and a no-options fallback that passes raw rows through without crashing.
  • plugin-charts26 passed (no regression from the ObjectChart change).
  • ✅ Full objectui suite — 4756 passed / 24 skipped / 0 failed with the source changes.
  • @object-ui/types + @object-ui/core + plugin-dashboard + plugin-charts build clean (declaration files generated, so the TSX typechecks against the new core exports).

Not done: live browser repro against framework/examples/app-showcase (would need a standing backend + a value≠label seeded select + dashboard). The two new tests reproduce the bug deterministically at the component/data level instead, which is the layer the bug lives in.

Notes / follow-ups

  • Runtime rollout: this won't reach the running stack until cloud bumps its .objectui-sha. Not bumped here (separate cloud change).
  • Related gap (not in scope):plugin-report's DatasetReportRenderer charts dataset dimensions the same way (data: state.rows straight to the chart) and would benefit from the same relabel — left out to keep this PR focused on the reported dashboard surface.

Closes objectstack-ai/cloud#667

🤖 Generated with Claude Code

…on't zero out (cloud#667)
A dataset chart grouped by a `select` field whose stored value is English
(active/lost/potential) but whose option labels are localized (合作中/已流失/潜在)
rendered every bar at 0. The dataset chart path handed the dimension's stored
value straight to the axis with no value→label resolution — unlike the legacy
aggregate path's resolveGroupByLabels — relying on the analytics server to have
resolved labels. When the server can't (an AI-built select whose options its
resolveDimensionLabels never sees), rows arrive value-keyed: the axis shows raw
enums and the option-keyed colour/category wiring no longer lines up with the
value-keyed rows.
Make the chart layer authoritative: resolve value→label from the object field
options, keying chart data by VALUE (so grouped counts always attach) and
displaying the LABEL. New shared `relabelDimensions` + `buildDimensionLabelMap`
helpers in @object-ui/core, wired into DatasetWidget (dashboard) and ObjectChart
(chart view) from the same object-schema fetch they already run for colours.
- relabelDimensions is idempotent and never mutates input rows, so server-
resolved labels and the raw drillRawRows both survive.
- chartRows stay index-aligned with drillRawRows, so drill-through still maps
to the raw stored value.
Tests: core composition (value≠label single-dim + pivot) and a DatasetWidget
regression asserting the chart receives label-keyed data with every count intact.
Closesobjectstack-ai/cloud#667
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJun 28, 2026 5:02am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.0 KB350 KB
Entry fileindex-CWqNuJUe.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)6.93KB2.48KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.90KB3.67KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)422.37KB89.87KB
core (index.js)1.52KB0.55KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)99.69KB24.89KB
fields (index.js)164.60KB39.84KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.98KB12.65KB
plugin-charts (index.js)45.88KB12.91KB
plugin-chatbot (index.js)170.28KB40.52KB
plugin-dashboard (index.js)107.64KB26.74KB
plugin-designer (index.js)213.42KB42.94KB
plugin-detail (index.js)198.30KB47.91KB
plugin-editor (index.js)2.38KB1.06KB
plugin-form (index.js)93.23KB22.71KB
plugin-gantt (index.js)136.68KB33.88KB
plugin-grid (index.js)121.64KB32.95KB
plugin-kanban (index.js)48.82KB13.13KB
plugin-list (index.js)94.53KB22.32KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.58KB4.64KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)84.45KB20.36KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (index.js)0.76KB0.42KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 39c8f97 into mainJun 28, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the claude/nervous-wright-4e043c branch June 28, 2026 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang