Skip to content

fix(metadata-admin): drop policy client-validator (PolicySchema removed in spec 11.2.0)#2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jun 29, 2026
Merged

fix(metadata-admin): drop policy client-validator (PolicySchema removed in spec 11.2.0) #2098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/app-shell/src/views/metadata-admin/clientValidation.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,12 @@ type SchemaLoader = () => Promise<ZodLikeSchema | undefined>;
// Types still falling through to server-only validation:
// - `validation`: not a top-level metadata file; lives inside object. (DataValidationRuleSchema
// exists but has empty shape, so it's not useful for client validation.)
// - `profile`: spec ships no top-level ProfileSchema (7.1 confirmed).
// - `policy`: spec 11.2.0 (PR #2078) removed the generic `PolicySchema` (the org-wide
// password/network/session/audit policy) from `@objectstack/spec/security`, and the
// canonical metadata-type→schema registry (spec kernel/metadata-type-schemas.ts) has
// no `policy` entry — so there is no client schema. `RowLevelSecurityPolicySchema`
// remains on /security but is a different shape (a per-object RLS rule), NOT the
// `policy` metadata file, so it must not be substituted.
// - `trigger`: no standalone TriggerSchema export at runtime (only
// ConnectorTriggerSchema / WebhookEventSchema variants).
// - `sharing_rule`: SharingRuleSchema is declared but has empty shape — server-only.
Expand DownExpand Up@@ -89,7 +94,8 @@ const LOADERS: Record<string, SchemaLoader> = {
// packages/spec/src/kernel/metadata-type-schemas.ts for the canonical mapping.
permission: async () => (await import('@objectstack/spec/security')).PermissionSetSchema as unknown as ZodLikeSchema,
profile: async () => (await import('@objectstack/spec/security')).PermissionSetSchema as unknown as ZodLikeSchema,
policy: async () => (await import('@objectstack/spec/security')).PolicySchema as unknown as ZodLikeSchema,
// `policy` intentionally omitted — spec 11.2.0 dropped `PolicySchema` and the metadata-type
// registry has no `policy` schema; drafts fall through to server-side validation (see top).

// identity
role: async () => (await import('@objectstack/spec/identity')).RoleSchema as unknown as ZodLikeSchema,
Expand Down
Loading