Uh oh!
There was an error while loading. Please reload this page.
test(data-objectstack): guard getObjectSchema's validations pass-through (inert-metadata regression) - #2117
Merged
Conversation
…h (inert-metadata guard) The inline select editor filters its options by the object's `state_machine` validation (#2110); that only works because `getObjectSchema` passes the served `validations` through untouched. Today that's verified only by hand (curl the endpoint + grep the adapter). Codify it: a fetch-mocked test asserts the state-machine transitions survive the adapter intact, so a future change that strips or reshapes top-level metadata trips a red test instead of silently turning the feature inert (valid-but-inert, the failure mode behind several prior "shipped but runtime-dead" bugs). Test-only; no changeset (no version-affecting change). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A fetch-mocked seam test pinning that
ObjectStackAdapter.getObjectSchemapasses the servedvalidations(incl.state_machinetransitions) through untouched.Why
The inline select editor filters its dropdown by the object's
state_machinevalidation (#2110). That feature is only alive because the adapter doesn't stripvalidationsfrom the served schema — which today is verified only by hand (curl the endpoint + grep the adapter).This is the valid-but-inert failure mode: if a future change here started stripping or reshaping top-level metadata, the filter would silently no-op with no error, no crash — "shipped but runtime-dead" (the same class as several prior bugs the platform's completeness gates target). This test turns that silent failure into a red CI check.
It's the smallest, non-noisy version of "make inert-metadata catchable": rather than warning on every absent config (which can't tell a legitimate default from dropped data), it pins the one seam the feature depends on.
Test
getObjectSchema.test.ts— asserts the state machine survives the adapter with its exact transition map (done → [in_progress], so the editor must not offerin_review). 3/3 in the file pass. Test-only; no changeset.🤖 Generated with Claude Code