Skip to content

fix(app-shell): don't show recovery-password reminder on a user's first landing#2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 3, 2026
Merged

fix(app-shell): don't show recovery-password reminder on a user's first landing #2183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/app-shell/src/console/home/HomePage.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -188,6 +188,15 @@ function RecoveryPasswordReminder({ t }: { t: (key: string, opts?: any) => strin
const [show, setShow] = useState(false);
useEffect(() => {
if (typeof localStorage !== 'undefined' && localStorage.getItem('os:recovery-pw-dismissed') === '1') return;
// Don't nag on the very first landing: let a brand-new SSO user reach
// their magic moment (build their first app) before asking them to set a
// recovery password. Record the first home visit; show the reminder only
// from the next one on. (The component already intends 'not before the
// first session'; previously the code still fired on the very first screen.)
if (typeof localStorage !== 'undefined' && localStorage.getItem('os:recovery-pw-first-seen') !== '1') {
try { localStorage.setItem('os:recovery-pw-first-seen', '1'); } catch { /* ignore */ }
return;
}
let cancelled = false;
Promise.resolve(hasLocalPassword?.())
.then((has) => { if (!cancelled && has === false) setShow(true); })
Expand Down
Loading