Uh oh!
There was an error while loading. Please reload this page.
fix(app-shell): don't show recovery-password reminder on SSO-enforced envs - #2184
Merged
Conversation
… envs The RecoveryPasswordReminder nudges the user to set a local recovery password "so you can still sign in if SSO is ever unavailable". But on an SSO-enforced env, password login is DISABLED (LoginForm already hides the password field) — so a recovery password can't actually be used. Showing the nudge there is misleading and gives a false sense of security (set one, SSO goes down, still locked out). Gate the reminder on password-login availability using the same signal LoginForm reads from getAuthConfig(): features.ssoEnforced === true || emailPassword.enabled === false. Only show when a password fallback is actually usable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SSO-enforced envs password login is disabled (LoginForm hides the password field), so the recovery password can't be used — nudging for one is misleading + false security. Gate RecoveryPasswordReminder on password-login availability using the same getAuthConfig signal LoginForm uses (features.ssoEnforced || emailPassword.enabled===false). Follows #2183 (first-run gate).