fix(form): evaluate view-level FormField.visibleOn with the canonical CEL engine by baozhoutao · Pull Request #2214 · objectstack-ai/objectui

baozhoutao · 2026-07-04T05:16:05Z

Fixes#2212 — view-level FormField.visibleOn (CEL) never took effect anywhere in the form chain, while field-level visibleWhen worked.

Root causes (all confirmed by source scan, file:line in #2212)

Expression-object wire shape discarded — the server ships visibleOn as { dialect: 'cel', source } (what the spec P template emits). sectionFields.tsattachVisibility and ObjectForm.tsxnormalizeVisibility only accepted typeof expr === 'string', so the object shape was silently dropped.
Dead closure, wrong engine — even for strings, the old code attached a visible() closure built on evaluateCondition, which is not a CEL evaluator (it only understands {field, operator, value} legacy objects and defaults unknown input to true) — and no renderer ever called that closure anyway. The form renderer destructured visibleOn out of the field config and dropped it.
Page mode lost sections entirely — RecordFormPage only forwarded sections for tabbed/wizard/split, so a simple form view's authored field selection, grouping, and visibleOn predicates were all discarded in page-mode create/edit, while the New/Edit modal honored the same view via resolveFormViewLayout.
Grouped-sections path dropped per-field overrides — ObjectForm's simple-sections branch matched section fields by name only, losing the section field def's visibleOn.

Fix

visibleOn flows through normalization verbatim (both wire shapes) and the form renderer evaluates it reactively with evalFieldPredicate — the same canonical engine, record scope, and fail-open semantics as field-level visibleWhen (ADR-0036). When both visibleOn and visibleWhen are present, both must allow the field.
RecordFormPage now forwards curated sections for every layout family, aligned with the modal path.
Sectioned (fromObjectSchema) and ModalForm flat normalization now also copy field-level visibleWhen/readonlyWhen/requiredWhen rules they previously lost.

Tests

New form-visibleon.test.tsx (4): object shape hides/shows reactively, bare-string shape, broken-CEL fail-open, visibleOn × visibleWhen combination.
sectionFields.test.ts +5: both wire shapes survive normalization (no dead closure), runtime FormField shape, field-level rule copying.
Suites: plugin-form 165/165, app-shell 969/969, components (5131 pass; the single DATEFORMAT failure is a pre-existing timezone flake also failing on unmodified main).

Browser verification (examples/app-showcase, `showcase_task.notes` with `visibleOn: record.priority == 'urgent'`)

Page-mode edit: priority = Low → 备注 hidden; switching to Urgent shows it live; back to Low hides it again. Sections (Task group header, authored 7-field selection) now render in page mode.
New-record modal: 备注 hidden by default, appears when priority is set to Urgent.

Co-Authored-By: Claude noreply@anthropic.com

vercel · 2026-07-04T05:16:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 4, 2026 5:16am

github-actions · 2026-07-04T05:19:59Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	59.5 KB	350 KB
Entry file	`index-B9xZM56l.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.51KB	2.72KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.90KB	3.67KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	9.55KB	3.36KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	26.07KB	6.30KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.29KB	0.82KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	435.96KB	93.64KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	109.24KB	26.96KB
fields (index.js)	184.84KB	45.12KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	36.30KB	10.04KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.10KB	12.33KB
plugin-charts (index.js)	46.11KB	12.99KB
plugin-chatbot (index.js)	172.75KB	41.13KB
plugin-dashboard (index.js)	108.28KB	26.86KB
plugin-designer (index.js)	213.48KB	42.95KB
plugin-detail (index.js)	201.40KB	48.47KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	99.50KB	24.18KB
plugin-gantt (index.js)	136.67KB	33.88KB
plugin-grid (index.js)	165.48KB	43.77KB
plugin-kanban (index.js)	48.15KB	12.94KB
plugin-list (index.js)	97.89KB	23.09KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	84.50KB	20.37KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

… CEL engine Fixes#2212. The spec ships `visibleOn` as an Expression object `{ dialect: 'cel', source }` (what the P template emits) or a bare string, but the chain dropped it end to end: - sectionFields.ts attachVisibility and ObjectForm's normalizeVisibility only accepted the bare-string shape, and even then attached a dead `visible()` closure no renderer ever called; the Expression object was silently discarded. - The form renderer destructured `visibleOn` out of the field config and never evaluated it. - RecordFormPage dropped a `simple` form view's `sections` entirely, so page-mode create/edit fell back to the raw schema (every field, no authored selection or conditional visibility) while the New/Edit modal honored the same view via resolveFormViewLayout. - ObjectForm's grouped-sections path matched section fields by name only, dropping per-field `visibleOn` overrides. `visibleOn` now flows through normalization verbatim (both wire shapes) and the form renderer evaluates it reactively with `evalFieldPredicate` — the same canonical engine, record scope, and fail-open semantics as field-level `visibleWhen` (ADR-0036); visibleOn AND visibleWhen must both allow a field. Sectioned/flat normalization also copies the field-level visibleWhen / readonlyWhen / requiredWhen rules it previously lost. Verified in the browser against examples/app-showcase showcase_task (`notes` with visibleOn `record.priority == 'urgent'`): page-mode edit and the New-record modal both hide/show the field reactively as priority changes. Co-Authored-By: Claude <noreply@anthropic.com>

`apps/console/src/components/FormPage.tsx` is a second, independent form renderer — it serves both `/f/:slug` (public, anonymous) and `/forms/:name` (internal) — and it read neither spelling of the FormView field visibility predicate. A field conditioned on `record.priority == 'urgent'` rendered unconditionally on both routes: fail-open and silent. objectui#2212 recorded the same symptom and PR #2214 fixed it on the OTHER chain (ModalForm -> resolveFormViewLayout -> plugin-form sectionFields.ts -> components renderers/form/form.tsx), which this file is on at no point, and that fix's regression pin lives with that chain. Applies #2212's ruling verbatim rather than inventing a second predicate semantics: the predicate is routed through the canonical engine, `evalFieldPredicate` (@object-ui/core, evaluator/fieldRules.ts), with the same `record.`/`previous.` scope, the same accepted wire shapes (bare CEL string and `{ dialect, source }`), and the same fail-open-but-loud behaviour. Resolution is canonical-first — `visibleWhen ?? visibleOn` — matching plugin-form's `sectionFields.ts` and app-shell's `readVisibility`. The regression pin lives with THIS renderer, next to the copy it describes: a pin that cannot see the second copy is how the first gap survived. Out of scope by triage fence: FormPage is not folded onto the plugin-form chain. The second-renderer convergence question stays with the #5596 track. Fixes#5594 Claude-Session: https://claude.ai/code/session_012u2pRjcqAYtoEjgr3wwhnK

github-actionsBot added package: types package: components plugin tests labels Jul 4, 2026

os-zhuang merged commit c38d107 into mainJul 4, 2026
10 checks passed

os-zhuang deleted the fix/formfield-visibleon-cel branch July 4, 2026 09:20

This was referenced Aug 21, 2026
Console FormPage (the standalone /forms and internal FormView renderer) never evaluates visibleWhen/visibleOn — objectui#2212 was fixed in the OTHER form renderer #5594
Closed
console: read the converged FormFieldSpec instead of a third copy of it #5597
Merged

Navigation Menu

Uh oh!

fix(form): evaluate view-level FormField.visibleOn with the canonical CEL engine - #2214

fix(form): evaluate view-level FormField.visibleOn with the canonical CEL engine#2214
os-zhuang merged 1 commit into
mainfrom
fix/formfield-visibleon-cel

baozhoutao commented Jul 4, 2026

Uh oh!

vercelBot commented Jul 4, 2026

Uh oh!

github-actionsBot commented Jul 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

baozhoutao commented Jul 4, 2026

Root causes (all confirmed by source scan, file:line in #2212)

Fix

Tests

Browser verification (examples/app-showcase, showcase_task.notes with visibleOn: record.priority == 'urgent')

Uh oh!

vercelBot commented Jul 4, 2026

Uh oh!

github-actionsBot commented Jul 4, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Browser verification (examples/app-showcase, `showcase_task.notes` with `visibleOn: record.priority == 'urgent'`)