Skip to content

feat(studio): 包 Access 门改走草稿/发布(ADR-0086 P2 · D6/D7) - #2225

Merged
os-zhuang merged 1 commit into
mainfrom
claude/adr-0086-p2-package-access-door
Jul 4, 2026
Merged

feat(studio): 包 Access 门改走草稿/发布(ADR-0086 P2 · D6/D7)#2225
os-zhuang merged 1 commit into
mainfrom
claude/adr-0086-p2-package-access-door

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

概述

ADR-0086 P2「两道门分离」的 objectui 半边。框架半边(块1 发布物化 + 块2 数据层写门)在 framework#2573;本 PR 把 studio 包 Access 门从"实时写活动记录"改成"写草稿、随包发布"——与 Data/Interfaces 门一致(D6/D7)。

问题(D6 违背):包 Access 门(/studio/:packageId/access)编辑权限集时直接 client.save(...) 写活动记录(live),banner 甚至明写"保存即生效 · 顶栏发布不涉及它"。而同一 studio 里 Data/Interfaces 门都是 {mode:'draft'} 草稿 + 顶栏 Publish 原子发布。两道门共用了同一条 live 写路径。

变更

包门 → 写草稿:

  • PermissionMatrixEditPage.doSave(有 packageId 分支)+ AccessPillar 新建集 creator,改为 client.save(..., { mode:'draft', packageId })。框架给草稿盖上包归属,顶栏 Publish 随整个包原子发布(框架侧物化进 sys_permission_set)。
  • env-admin 门(无 packageId)保持 live(config),符合 D7——两道门各写各的。

草稿感知读:

  • 编辑器加载时先读 pending draft(getDraft),草稿覆盖已发布基线显示——否则"存了没发布"的编辑重开会像丢了。
  • 侧栏合并 已发布 ∪ 草稿 权限集(listDrafts),所以草稿态/仅草稿的集在发布前也可见(与 Data/Interfaces 一致)。
  • 保存 bump 顶栏 pending 计数;发布后 publishNonce 触发重载,草稿收敛回已发布基线。(onDraftSaved/publishNonce 从 surface 线到 AccessPillar + 编辑器。)

banner 修正: 不再声称"保存即生效 / 发布不涉及"——改为"保存为软件包草稿,发布后随整个包生效"(EN + ZH 双语)。

验证

  • PermissionMatrixEditor.scope.test.tsx:新增断言——包门保存携带 { mode:'draft', packageId },且其他包切片仍逐字保留(ADR-0086 P0 切片合并不回退)。1 passed。
  • app-shell tsc --noEmit 0 error;改动文件 lint 0 error(仅既有 warning 模式)。
  • 全 workspace build 绿。

端到端(配合 framework#2573)

包门编辑 → Save 写草稿 + pending 计数 +1 → 顶栏 Publish → POST /packages/:id/publish-drafts → 框架发布 permission 草稿 → 块1 物化进 sys_permission_set(managed_by:'package') → publishNonce 重载 → 草稿收敛。块2 写门确保 env-admin 不能绕过直接改包行。

关联

  • framework#2573(P2 框架半边:块1 发布物化 + 块2 写门)
  • ADR-0086 D6(包门=draft/publish metadata)· D7(两道门,各写各的)
  • 前序:ADR-0086 P0(objectui#2222,Access 矩阵按包 scope + 切片合并)

🤖 Generated with Claude Code

https://claude.ai/code/session_014y5kiH3aPLWtRRRGcVrXcT


Generated by Claude Code

…086 P2 · D6/D7)
The package Access pillar edited permission sets live (wrote the active record
directly), unlike Data/Interfaces which draft→publish with the package — a D6
violation. Now the package door writes drafts:
- PermissionMatrixEditPage.doSave (package scope) + AccessPillar's new-set
creator save with { mode:'draft', packageId }; the top-bar Publish promotes
them (framework materializes into sys_permission_set, ADR-0086 P2 块1). The
env-admin door (no packageId) stays live (config), per D7.
- Draft-aware reads: editor loads the pending draft over the published
baseline; the rail merges published ∪ draft sets so a draft-only/edited set
stays visible pre-publish. Save bumps the pending-changes counter; publish
reloads the published baseline (onDraftSaved / publishNonce threaded from the
surface into AccessPillar + the editor).
- Banner corrected: no longer claims "saved = live" — states edits save as
package drafts and go live on Publish.
Test: scope test now asserts the package-door save carries { mode:'draft',
packageId } and preserves other packages' slices.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014y5kiH3aPLWtRRRGcVrXcT
@vercel

vercelBot commented Jul 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 4, 2026 12:36pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.5 KB350 KB
Entry fileindex-DEJvjSH3.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.90KB3.67KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)435.99KB93.64KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)109.24KB26.96KB
fields (index.js)185.23KB45.20KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.09KB12.99KB
plugin-chatbot (index.js)172.75KB41.13KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.48KB42.95KB
plugin-detail (index.js)201.40KB48.47KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)99.50KB24.18KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)165.48KB43.77KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)84.50KB20.37KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 4, 2026 13:33
@os-zhuang
os-zhuang merged commit d9f5ccd into mainJul 4, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the claude/adr-0086-p2-package-access-door branch July 4, 2026 13:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude