Uh oh!
There was an error while loading. Please reload this page.
test(studio): extend create-conformance gate to the inline pillar creators - #2243
Merged
Conversation
…ators createConformance.test.ts only read the metadata-admin registry, so the Studio's inline "New X" creators (object/flow/app/permission — built directly in StudioDesignSurface.tsx) were uncovered: a future skeleton edit could make a "New" button a silent create→save 422 dead-end with nothing to catch it. Extract the 4 inline skeletons into pure exported builders (studio-design/ skeletons.ts) used by BOTH the pillars and a new gate block, so the test can't drift from what "New" emits. No behavior change (byte-identical skeletons); the gate now covers all create paths (registry + inline), 4 inline skeletons valid. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why (UX eval #3 — create-flow consistency gate)
createConformance.test.tsguards that every authorable type's default create-form output passes spec validation — catching the recurring "the designer emits a minimal shape the spec rejects, so create→save 422s" dead-end family (dashboardlayout, report anchors, action missingbody, …).But it read only the metadata-admin registry. The Studio's inline "New X" creators — Data →
object, Automations →flow, Interfaces →app, Access →permission— build their skeletons directly inStudioDesignSurface.tsx, bypassing the registry, so they were uncovered. A future edit to one of those shapes could turn its "New" button into a silent dead-end with nothing to catch it. (The knownaction/etc. dead-ends are already fixed and gated; this closes the last uncovered create path.)What
Extracted the four inline skeletons into pure, exported builders (
studio-design/skeletons.ts) consumed by both the pillars and a new gate block increateConformance.test.ts— so the test can't drift from what the "New" button actually emits.No behavior change — the builders return byte-identical skeletons (
object: 1 text field;flow: start→end autolaunched;app: empty nav;permission: empty matrix). The gate now covers all create paths (registry + inline).Verification
createConformancesuite 15 green (11 registry + 4 new inline: object/flow/app/permission each spec-valid). app-shell type-check clean (29/29). Behavior-preserving refactor, so no runtime change to the create flows.🤖 Generated with Claude Code