Skip to content

fix(app-shell): stop double-firing action error/success toasts in RecordDetailView & delete handler - #2253

Merged
os-zhuang merged 1 commit into
mainfrom
fix/dedupe-recorddetail-delete-toast
Jul 5, 2026
Merged

fix(app-shell): stop double-firing action error/success toasts in RecordDetailView & delete handler#2253
os-zhuang merged 1 commit into
mainfrom
fix/dedupe-recorddetail-delete-toast

Conversation

@baozhoutao

@baozhoutaobaozhoutao commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Closes#2252

问题

Console 记录详情页点一个会失败的 script 动作(如「分配线索」触发后端 RECORD_LOCKED)时,同一条错误 toast 弹两次。后端只抛一次,是纯 UI 重复。排查中一并发现 删除动作 同类重复:失败弹两条、成功也弹两条。

根因

ActionRunner.handlePostExecution 已负责把结果 error 弹成 toast(成功则按 showOnSuccess 弹)。若某 handler 自己又调 toast.* 且 返回 {success:false, error}(成功时未标 silent),而 runner 又设了 onToast,就会被弹第二遍。

  • RecordDetailView.serverActionHandler(script):失败分支与 catch 分支各自 toast.error 后又返回 error。fix(app-shell): stop double-toasting failed script/modal action errors #2177 只修了孪生副本 useConsoleActionRuntime(interface page),记录详情页这份没修 → 仍双弹。也解释了「两天前修过还在」「同事没 clone objectui 也复现」(都吃同一份已发布的 @objectstack/console)。
  • useObjectActions.delete(ObjectView 装配 onToast):失败自弹+返回 error → 双弹;成功自弹+未标 silent → runner 追加通用「Action completed successfully」;批量部分失败同理。

改动

测试

① 单元测试 — 新增 useObjectActions.test.tsx,把 onToast 接到与真实 ObjectView 相同的 sonner sink,断言用户实际所见:

  • 删除失败 → error 恰好 1 次(修前 2 次)
  • 删除成功 → success 恰好 1 次(此条修前报 got 2 times,揪出了成功路径的第 3 处双弹)
  • 批量部分失败 → error 恰好 1 次且带汇总

3 新增 + 83 相关回归(含 #2177 的用例)全绿。

② 产物级证据 — 从本分支构建 console,grep 打包后的 RecordDetailView chunk,对照当初坐实 bug 的同一签名:

bundle自弹签名 .error(X),{success:!1,error:X}
旧发布版 @objectstack/console@12.1.02 处
本 PR 构建0 处

发货代码里两处自弹已消失。

@vercel

vercelBot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 5, 2026 5:10am

Request Review

@github-actions

github-actionsBot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.5 KB350 KB
Entry fileindex-BRAN8zH1.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.90KB3.67KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)436.90KB93.87KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)109.66KB27.05KB
fields (index.js)185.28KB45.20KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.09KB12.99KB
plugin-chatbot (index.js)172.75KB41.13KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.48KB42.95KB
plugin-detail (index.js)203.08KB48.92KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)101.47KB24.65KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)165.48KB43.77KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.46KB20.80KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 4fbf910 into mainJul 5, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the fix/dedupe-recorddetail-delete-toast branch July 5, 2026 06:36
@baozhoutao
fix(app-shell): stop double-firing action error/success toasts (#2252)
74ed372
RecordDetailView's serverActionHandler (script actions) and useObjectActions'
delete handler each toasted an error/success themselves AND returned it to the
ActionRunner, whose post-execution hook toasts again when onToast is wired — so
the same message fired twice (the reported RECORD_LOCKED double-toast, plus a
double on delete success/failure).
- RecordDetailView: drop the self toast.error in both failure branches; return
the error and let the runner surface it once (mirrors #2177's twin fix in
useConsoleActionRuntime).
- useObjectActions.delete: keep the richer localized toast, return without
`error` on failure and mark successful deletes `silent` so the runner
doesn't re-toast.
- Add useObjectActions.test.tsx asserting a single toast on delete
success/failure/partial-bulk-failure.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Console 记录详情页 script 动作失败时错误 toast 弹两次(删除动作同样成功/失败都重复)

2 participants

@baozhoutao@os-zhuang