Skip to content

feat(app-shell): studio dogfood follow-ups — API-name derive, read-only gating, publish confirm, nav scaffold, i18n sweep - #2270

Merged
os-zhuang merged 8 commits into
mainfrom
studio-dogfood-followups
Jul 5, 2026
Merged

feat(app-shell): studio dogfood follow-ups — API-name derive, read-only gating, publish confirm, nav scaffold, i18n sweep#2270
os-zhuang merged 8 commits into
mainfrom
studio-dogfood-followups

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

What

Implements all five console-side findings from the Studio package-create UX dogfood (objectstack-ai/objectstack#2615, audit docs/audits/2026-07-studio-package-create-ux-dogfood.md):

Closes#2259, closes#2260, closes#2261, closes#2262, closes#2264.

  • Studio: new field's API name doesn't follow the label before first save (permanent field_N columns) #2260 — field API name derives from the label for generic auto names.maybeDeriveName only recognised type-based auto names (text_2, status); the Data pillar's "+ Add field" produces field_N, so relabeling never derived and records kept field_N data columns forever. Both shapes now derive; custom names, CJK-only labels, and sibling collisions unchanged. +5 unit tests.
  • Studio: read-only packages accept edit gestures client-side, fail only at server write #2259 — read-only packages gate authoring client-side (ADR-0057 D10 courtesy gate).StudioDesignSurface resolves the package's writability once and passes readOnly to all four pillars: Add field, New object/flow/permission set, nav Edit, Save draft, Publish and Create app hide or disable with a readonlyHint tooltip; the field inspector opens read-only; records stay fully usable; the server ADR-0070 gate remains the authority (unknown writability stays ungated).
  • Studio: Publish needs a confirm step; Changes panel needs field-level detail #2261 — publish is review-then-confirm. The header Publish button opens DraftChangesPanel; its new footer button ("Publish N change(s)") fires the atomic publish. Panel entries now expand to a lazy per-item diff: object fields added/removed/changed plus changed top-level properties vs the live version.
  • Studio: offer to scaffold navigation from existing objects when creating an app #2262 — create-app scaffolds navigation from the package's objects (checkbox, default on): buildAppSkeleton seeds one type: 'object' nav item per object — the missing type discriminator was caught by the createConformance spec gate on the first attempt, which is exactly what that gate is for. Conformance case added for the nav-seeded skeleton.
  • Studio design surface: ~88 hardcoded Chinese strings bypass the existing i18n layer (mixed-language screens) #2264 — studio-design's hardcoded Chinese now routes through i18n. BuilderLanding / ObjectFormDesigner / ObjectValidationsPanel / ObjectSettingsPanel rendered hardcoded Chinese regardless of locale (the mixed-language screens from the dogfood, and an English-only-codebase violation). All user-visible strings resolve via t()/tFormat() with English defaults + zh-CN translations (58 keys added under engine.studio.landing/designer/rules/settings, existing keys reused).

Verification

  • tsc --noEmit clean; full @object-ui/app-shell suite 1044/1044 green (3 assertions updated to the new en-US defaults).
  • Browser-verified end-to-end against a live framework showcase backend (HMR console → seeded admin):
    • read-only com.example.showcase: Add field / New object gone, Publish disabled, Read-only badge intact, records grid still works;
    • writable package: new field field_3 → label "Priority" → API name becomes priority on blur;
    • Publish opens the panel; entry expands to + field priority; footer publish succeeds with the existing toast;
    • fresh package: Create app with the scaffold checkbox produces a draft app whose navigation carries the object item, _diagnostics.valid: true;
    • Studio landing renders fully in English (and zh-CN via the locale switch path).
  • Changeset included (@object-ui/app-shell: minor). Pre-existing react-hooks/static-components eslint error in ObjectSettingsPanel is on main unchanged (out of scope).

🤖 Generated with Claude Code

https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt


Generated by Claude Code

claude added 3 commits July 5, 2026 06:58
…auto names
The Data pillar's '+ Add field' names new fields field_N, but
maybeDeriveName only recognised type-based auto names (text_2, status),
so relabeling never derived the API name and records kept meaningless
field_N data columns forever (#2260).
Recognise both auto-name shapes; custom names, CJK-only labels, and
sibling collisions keep today's behaviour.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
…affolding
Three follow-ups from the Studio package-create UX dogfood
(objectstack-ai/objectstack#2615), which all live on the same surface:
- objectui#2259 — resolve the package's writability once in
StudioDesignSurface and courtesy-gate authoring affordances on
read-only packages (ADR-0057 D10): Add field, New object/flow/
permission set, nav Edit, Save draft, Publish, and Create app hide or
disable with a readonlyHint tooltip; the field inspector opens
read-only, records stay usable, and the server gate remains the
authority.
- objectui#2261 — Publish is review-then-confirm: the header button now
opens DraftChangesPanel, whose footer 'Publish N change(s)' fires the
atomic publish; entries expand to a lazy per-item diff (object fields
added/removed/changed + changed top-level properties vs the live
version).
- objectui#2262 — the create-app popover offers 'add this package's
objects as menu items' (default on): buildAppSkeleton seeds one
spec-valid object nav item per object (type discriminator caught by
the createConformance gate on first try).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
…gh i18n
BuilderLanding, ObjectFormDesigner, ObjectValidationsPanel and
ObjectSettingsPanel rendered hardcoded Chinese regardless of locale,
while partially using the same files' i18n layer — producing the
mixed-language screens found by the Studio package-create UX dogfood
(objectui#2264, framework#2615) and violating the English-only-codebase
rule. All user-visible strings now resolve via t()/tFormat() with
English defaults and zh-CN translations (58 keys added under
engine.studio.landing/designer/rules/settings; existing pkg/data keys
reused where they fit). Test assertions follow the en-US defaults.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
@vercel

vercelBot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 5, 2026 8:13am

Request Review

@os-zhuang
os-zhuang marked this pull request as ready for review July 5, 2026 07:48
claude added 3 commits July 5, 2026 07:49
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
…8n sweep
Upstream landed read-only gating + live API-name sync (#2263) and
review-then-publish + changes detail (#2271) in parallel — take those
implementations wholesale (they supersede this branch's #2259/#2260/#2261
work, including per-keystroke name sync and a structured diffFields-based
detail). Kept from this branch: create-app nav scaffolding (#2262), the
studio-design i18n sweep (#2264), ObjectFormDesigner's full read-only
mode, and the nav-seeded skeleton conformance case; dropped the now-
redundant blur-based derive tests in favour of upstream's.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DHQc5BdGhTzPfazex3vWdt
…name derive and changes-panel implementation, keep this PR's four-pillar readOnly gating, nav scaffold and i18n sweep
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.5 KB350 KB
Entry fileindex-DOR_Gc62.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)18.34KB3.80KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)437.19KB93.97KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)109.66KB27.05KB
fields (index.js)185.40KB45.26KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.92KB10.17KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.18KB13.02KB
plugin-chatbot (index.js)173.06KB41.28KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.56KB42.96KB
plugin-detail (index.js)203.63KB49.07KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)102.48KB24.90KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)165.48KB43.77KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.78KB5.23KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.78KB20.89KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.5 KB350 KB
Entry fileindex-DnOXZKp-.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)18.34KB3.80KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)437.19KB93.97KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)109.66KB27.05KB
fields (index.js)185.40KB45.26KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.92KB10.17KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.18KB13.02KB
plugin-chatbot (index.js)173.06KB41.28KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.56KB42.96KB
plugin-detail (index.js)203.63KB49.07KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)102.48KB24.90KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)165.48KB43.77KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.78KB5.23KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.78KB20.89KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 7a6837c into mainJul 5, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the studio-dogfood-followups branch July 5, 2026 08:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment