Skip to content

fix(plugin-detail): fix React #300 crash on master-detail drill-in (hoist DetailSection early return below hooks) - #2310

Merged
os-zhuang merged 2 commits into
mainfrom
fix/detail-section-hooks-order
Jul 6, 2026
Merged

fix(plugin-detail): fix React #300 crash on master-detail drill-in (hoist DetailSection early return below hooks)#2310
os-zhuang merged 2 commits into
mainfrom
fix/detail-section-hooks-order

Conversation

@baozhoutao

Copy link
Copy Markdown
Contributor

Problem

Drilling from a master record's related sub-table into a child record crashed with a minified React error #300 ("rendered more hooks than during the previous render"). The record detail page showed the orange error boundary, and refreshing bounced the user away.

Repro (showcase): Accounts list → open Northwind detail → Projects tab → click a project row → the child project detail page crashes.

Root cause

DetailSection had its all-empty early return placed before a hook:

// BEFOREif(visibleFields.length===0&&emptyCount===section.fields.length)returnnull;// ← early return
...
React.useEffect(()=>{/* virtual-scroll batching */},[vsEnabled,layoutFields.length,vsBatchSize]);// ← hook AFTER the return

When the same reconciled fiber rendered all-empty on one pass (early return → effect skipped → N hooks) and populated on the next (no early return → effect runs → N+1 hooks), the hook count changed between renders — the classic Rules-of-Hooks violation React reports as #300.

The master-detail drill-in reuses the RecordDetailView / DetailSection fiber (only objectName/recordId change via the router), and the sections flip from empty to populated, so it trips reliably.

Fix

Move the all-empty guard to run after every hook (including the useEffect), so the hook count is invariant to field/data/visibleCount. Render output is unchanged.

Verification (showcase console)

  • ✅ Accounts → Northwind detail → Projects tab → Website Relaunch drill-in now renders (客户/状态/健康度/预算/负责人/已花费/日期 all show), no crash, zero console errors.
  • ✅ Back-nav via breadcrumb (project → account) works, no crash.
  • ✅ Inline edit + field validation ("Tax ID must look like…") + save round-trip all work.

Fixes the master-detail browse/edit/return flow reported as broken.

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 6, 2026 4:25am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.5 KB350 KB
Entry fileindex-DrRXJLme.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)18.34KB3.80KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)438.93KB94.50KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)110.51KB27.26KB
fields (index.js)186.03KB45.53KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)38.41KB10.65KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.25KB13.04KB
plugin-chatbot (index.js)173.23KB41.32KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.56KB42.96KB
plugin-detail (index.js)204.09KB49.20KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)103.92KB25.15KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)170.94KB45.11KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.78KB5.23KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.42KB20.79KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.79KB0.43KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 47e72b8 into mainJul 6, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the fix/detail-section-hooks-order branch July 6, 2026 06:29
…hooks
DetailSection had an early `return null` (all-empty section, user hasn't
revealed empties) placed BEFORE the virtual-scroll `useEffect`. When the same
reconciled fiber rendered all-empty on one pass (N hooks, effect skipped) and
populated on the next (N+1 hooks, effect runs), the hook count changed between
renders and React threw error #300 ("rendered more hooks than during the
previous render").
This is the master-detail drill-in crash: navigating from an account detail
into a child project detail reuses the RecordDetailView / DetailSection fiber,
and the sections flip from empty to populated — reliably tripping the mismatch.
The orange error boundary appeared and a refresh bounced the user away.
Fix: move the all-empty guard to AFTER every hook (including the useEffect) so
the hook count is invariant to field/data/visibleCount. No behavior change for
the render output.
Verified in the showcase console: Accounts -> Northwind detail -> Projects tab
-> Website Relaunch drill-in now renders with no crash; back-nav to the account
and inline edit + validation + save all work.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@baozhoutao@os-zhuang