Uh oh!
There was an error while loading. Please reload this page.
feat(detail): honor enable.feeds / enable.activities opt-out gates (framework#2707) - #2370
Merged
Merged
Conversation
…ramework#2707) RecordDetailView rendered the discussion panel and merged the sys_activity timeline unconditionally. Both now honor the object capability flags with opt-OUT semantics (spec default flips to true in the companion framework PR, so absent block/flag = unchanged behavior): - feeds:false hides the discussion panel (page-schema auto-append + legacy discussionSlot) and skips the sys_comment fetch; the server independently rejects new comments (403 FEEDS_DISABLED). - activities:false skips the sys_activity fetch/merge (the server stops mirroring such objects, so this also keeps the network quiet). Also fixes the long-wrong comment claiming plugin-audit's writers were gated by enable.activities opt-IN (they were unconditional; the contract is now opt-out). History tab gate (enable.trackHistory === true) unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
framework#2707 处置的 objectui 半边:RecordDetailView 此前无条件渲染讨论面板并合并 sys_activity timeline——对象能力 flag
enable.feeds/enable.activities在渲染层是 dead 的。本 PR 让两者按 opt-out 契约生效(配套 framework PR 把 spec 默认值翻成true,所以缺省行为完全不变,只有显式false才关):feeds: false→ 隐藏讨论面板(page-schema 自动追加 + legacydiscussionSlot两处),并跳过 sys_comment 拉取;服务端同时 fail-closed(403FEEDS_DISABLED,framework 侧)。activities: false→ 跳过 sys_activity 拉取/合并(服务端已停止镜像该对象,拉了也是空——顺带省一次请求)。另修正 1140 行错误注释(声称 writer 由
enable.activitiesopt-in 门控——实际此前无条件写;新契约是 opt-out)。History 标签页闸门(enable.trackHistory === true)保持不变。验证
turbo build --filter=@object-ui/app-shell(tsc)✓turbo test --filter=@object-ui/app-shell✓配套:objectstack-ai/framework PR(feat/2707-enable-capability-gates 分支,含 spec 默认翻转 + writer/hook 闸门 + ledger 修正)。
🤖 Generated with Claude Code