Skip to content

feat(detail): honor enable.feeds / enable.activities opt-out gates (framework#2707) - #2370

Merged
os-zhuang merged 1 commit into
mainfrom
feat/2707-enable-capability-gates
Jul 10, 2026
Merged

feat(detail): honor enable.feeds / enable.activities opt-out gates (framework#2707)#2370
os-zhuang merged 1 commit into
mainfrom
feat/2707-enable-capability-gates

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

概述

framework#2707 处置的 objectui 半边:RecordDetailView 此前无条件渲染讨论面板并合并 sys_activity timeline——对象能力 flag enable.feeds/enable.activities 在渲染层是 dead 的。本 PR 让两者按 opt-out 契约生效(配套 framework PR 把 spec 默认值翻成 true,所以缺省行为完全不变,只有显式 false 才关):

  • feeds: false → 隐藏讨论面板(page-schema 自动追加 + legacy discussionSlot 两处),并跳过 sys_comment 拉取;服务端同时 fail-closed(403 FEEDS_DISABLED,framework 侧)。
  • activities: false → 跳过 sys_activity 拉取/合并(服务端已停止镜像该对象,拉了也是空——顺带省一次请求)。

另修正 1140 行错误注释(声称 writer 由 enable.activitiesopt-in 门控——实际此前无条件写;新契约是 opt-out)。History 标签页闸门(enable.trackHistory === true)保持不变。

验证

  • turbo build --filter=@object-ui/app-shell(tsc)✓
  • turbo test --filter=@object-ui/app-shell
  • 配套 framework 分支端到端冒烟:探针对象(两 flag 显式 false)0 条 activity 镜像、评论 403;默认对象行为不变(activity 镜像 + 评论 201)。

配套:objectstack-ai/framework PR(feat/2707-enable-capability-gates 分支,含 spec 默认翻转 + writer/hook 闸门 + ledger 修正)。

🤖 Generated with Claude Code

…ramework#2707)
RecordDetailView rendered the discussion panel and merged the sys_activity
timeline unconditionally. Both now honor the object capability flags with
opt-OUT semantics (spec default flips to true in the companion framework PR,
so absent block/flag = unchanged behavior):
- feeds:false hides the discussion panel (page-schema auto-append + legacy
discussionSlot) and skips the sys_comment fetch; the server independently
rejects new comments (403 FEEDS_DISABLED).
- activities:false skips the sys_activity fetch/merge (the server stops
mirroring such objects, so this also keeps the network quiet).
Also fixes the long-wrong comment claiming plugin-audit's writers were
gated by enable.activities opt-IN (they were unconditional; the contract
is now opt-out). History tab gate (enable.trackHistory === true) unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 10, 2026 3:33am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.7 KB350 KB
Entry fileindex-ddh5yGE8.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.54KB2.74KB
app-shell (runtime-config.js)5.79KB2.08KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)19.11KB4.04KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)440.80KB95.06KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)110.51KB27.26KB
fields (index.js)186.64KB45.58KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)38.41KB10.65KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)173.83KB41.47KB
plugin-dashboard (index.js)108.35KB26.87KB
plugin-designer (index.js)213.95KB43.04KB
plugin-detail (index.js)204.81KB49.36KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)104.12KB25.19KB
plugin-gantt (index.js)136.81KB33.91KB
plugin-grid (index.js)171.02KB45.15KB
plugin-kanban (index.js)48.16KB12.94KB
plugin-list (index.js)98.18KB23.16KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.47KB20.80KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.79KB0.43KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 98a7cfb into mainJul 10, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the feat/2707-enable-capability-gates branch July 10, 2026 03:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang